Work on tests and removed Set/GetDefaultValue

Author: KathleenDollard

src/System.CommandLine.Subsystems.Tests/ValueSubsystemTests.cs

@@ -30,28 +30,31 @@ public void Value_is_always_activated()
         isActive.Should().BeTrue();
     }
 
-    [Fact]
+    [Fact(Skip ="WIP")]
     public void ValueSubsystem_returns_values_that_are_entered()
     {
+        var consoleHack = new ConsoleHack().RedirectToBuffer(true);
+        var pipeline = Pipeline.Create();
+        CliOption<int> option1 = new CliOption<int>("--intValue");
         CliRootCommand rootCommand = [
             new CliCommand("x")
             {
-                new CliOption<int>("--intValue"),
-                new CliOption<string>("--stringValue"),
-                new CliOption<bool>("--boolValue")
+                option1
             }];
         var configuration = new CliConfiguration(rootCommand);
-        var subsystem = new ValueSubsystem();
         const int expected1 = 42;
-        const string expected2 = "43";
-        var input = $"x --intValue {expected1} --stringValue \"{expected2}\" --boolValue";
-        var args = CliParser.SplitCommandLine(input).ToList();
+        var input = $"x --intValue {expected1}";
 
-        Subsystem.Initialize(subsystem, configuration, args);
-        var parseResult = CliParser.Parse(rootCommand, input, configuration);
+        pipeline.Parse(configuration, input);
+        pipeline.Execute(configuration, input, consoleHack);
+
+        pipeline.Value.GetValue<int>(option1).Should().Be(expected1);
+    }
+
+
+    [Fact(Skip = "WIP")]
+    public void ValueSubsystem_returns_default_value_when_no_value_is_entered()
+    {
 
-        parseResult.GetValue<int>("--intValue").Should().Be(expected1);
-        parseResult.GetValue<string>("--stringValue").Should().Be(expected2);
-        parseResult.GetValue<bool>("--boolValue").Should().Be(true);
     }
 }

src/System.CommandLine.Subsystems/ValueSubsystem.cs

@@ -18,13 +18,13 @@ public ValueSubsystem(IAnnotationProvider? annotationProvider = null)
         : base(ValueAnnotations.Prefix, SubsystemKind.Version, annotationProvider)
     { }
 
-    internal void SetDefaultValue(CliSymbol symbol, object? defaultValue)
-        => SetAnnotation(symbol, ValueAnnotations.DefaultValue, defaultValue);
-    internal object? GetDefaultValue(CliSymbol symbol)
-      => TryGetAnnotation(symbol, ValueAnnotations.DefaultValue, out var defaultValue)
-                ? defaultValue
-                : "";
-    internal bool TryGetDefaultValue<T>(CliSymbol symbol, out T? defaultValue)
+    //internal void SetDefaultValue(CliSymbol symbol, object? defaultValue)
+    //    => SetAnnotation(symbol, ValueAnnotations.DefaultValue, defaultValue);
+    //internal object? GetDefaultValue(CliSymbol symbol)
+    //  => TryGetAnnotation(symbol, ValueAnnotations.DefaultValue, out var defaultValue)
+    //            ? defaultValue
+    //            : "";
+    private bool TryGetDefaultValue<T>(CliSymbol symbol, out T? defaultValue)
     {
         if (TryGetAnnotation(symbol, ValueAnnotations.Value, out var objectValue))
         {