Skip to content

Commit 098913c

Browse files
Added thoughts from conversation with Chet
1 parent 603bd30 commit 098913c

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/System.CommandLine.Subsystems/CompletionSubsystem.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,15 @@
66

77
namespace System.CommandLine;
88

9+
// Notes from Chet's work on static shells and further thoughts
10+
// - Chet has work he can later upstream for completion script creation - static when it can be
11+
// - Completions need to know - what it is, whether it is static or dynamic, and how many items would be in the list.
12+
// - Not sure whether these need to be in the Completer or the trait
13+
// - Validation can have many validators per type. Completions may need to have a single one.
14+
// - Probably two steps - determining the available values and matching the current word
15+
// - The code in CompletionContext of main/Extended to get current word requires tokens and is pretty gnarly
16+
// - File and directory are special as they can get handed off to shell ro the work
17+
918
public class CompletionSubsystem : CliSubsystem
1019
{
1120
public CompletionSubsystem(IAnnotationProvider? annotationProvider = null)

0 commit comments

Comments
 (0)