Added GetValue to PipelineResults and added tests

Not sure where along the way GetValue got lost :(

Author: KathleenDollard

src/System.CommandLine.Subsystems.Tests/ValueSubsystemTests.cs

@@ -5,11 +5,61 @@
 using System.CommandLine.Directives;
 using System.CommandLine.Parsing;
 using Xunit;
+using static System.CommandLine.Subsystems.Tests.TestData;
 
 namespace System.CommandLine.Subsystems.Tests;
 
 public class ValueSubsystemTests
 {
+    [Fact]
+    public void Values_that_are_entered_are_retrieved()
+    {
+        var option = new CliOption<int>("--intOpt");
+        var rootCommand = new CliRootCommand { option };
+        var configuration = new CliConfiguration(rootCommand);
+        var pipeline = Pipeline.Create();
+        var consoleHack = new ConsoleHack().RedirectToBuffer(true);
+        var input = "--intOpt 42";
+
+        var parseResult = CliParser.Parse(rootCommand, input, configuration);
+        var pipelineResult = new PipelineResult(parseResult, input, pipeline);
+
+        pipelineResult.Should().NotBeNull();
+        var optionValueResult = pipelineResult.GetValueResult(option);
+        var optionValue = pipelineResult.GetValue<int>(option);
+        optionValueResult.Should().NotBeNull();
+        optionValue.Should().Be(42);
+    }
+
+    [Fact]
+    public void Values_that_are_not_entered_are_type_default_with_no_default_values()
+    {
+        var stringOption = new CliOption<string>("--stringOption");
+        var intOption = new CliOption<int>("--intOption");
+        var dateOption = new CliOption<DateTime>("--dateOption");
+        var nullableIntOption = new CliOption<int?>("--nullableIntOption");
+        var guidOption = new CliOption<Guid>("--guidOption");
+        var rootCommand = new CliRootCommand { stringOption, intOption, dateOption, nullableIntOption, guidOption };
+        var configuration = new CliConfiguration(rootCommand);
+        var pipeline = Pipeline.Create();
+        var input = "";
+
+        var parseResult = CliParser.Parse(rootCommand, input, configuration);
+        var pipelineResult = new PipelineResult(parseResult, input, pipeline);
+
+        pipelineResult.Should().NotBeNull();
+        var stringOptionValue = pipelineResult.GetValue<string>(stringOption);
+        var intOptionValue = pipelineResult.GetValue<int>(intOption);
+        var dateOptionValue = pipelineResult.GetValue<DateTime>(dateOption);
+        var nullableIntOptionValue = pipelineResult.GetValue<int?>(nullableIntOption);
+        var guidOptionValue = pipelineResult.GetValue<Guid>(guidOption);
+        stringOptionValue.Should().BeNull();
+        intOptionValue.Should().Be(0);
+        dateOptionValue.Should().Be(DateTime.MinValue);
+        nullableIntOptionValue.Should().BeNull();
+        guidOptionValue.Should().Be(Guid.Empty);
+    }
+
     // TODO: Add various default value tests
 
     /* Hold these tests until we determine if ValueSubsystem is replaceable

src/System.CommandLine.Subsystems/PipelineResult.cs

@@ -7,6 +7,7 @@ namespace System.CommandLine;
 
 public class PipelineResult(ParseResult? parseResult, string rawInput, Pipeline? pipeline, ConsoleHack? consoleHack = null)
 {
+    // TODO: Try to build workflow so it is illegal to create this without a ParseResult
     private readonly List<ParseError> errors = [];
     public ParseResult? ParseResult { get; } = parseResult;
     private ValueProvider valueProvider { get; } = new ValueProvider(parseResult);
@@ -19,6 +20,16 @@ public class PipelineResult(ParseResult? parseResult, string rawInput, Pipeline?
     public bool AlreadyHandled { get; set; }
     public int ExitCode { get; set; }
 
+    public T? GetValue<T>(CliValueSymbol dataSymbol)
+     => valueProvider.GetValue<T>(dataSymbol);
+
+    public object? GetValue(CliValueSymbol option)
+        => valueProvider.GetValue<object?>(option);
+
+    public CliValueResult GetValueResult(CliValueSymbol dataSymbol)
+     => parseResult.GetValueResult(dataSymbol);
+
+
     public void AddErrors(IEnumerable<ParseError> errors)
     {
         if (errors is not null)

src/System.CommandLine/ParseResult.cs

@@ -203,20 +203,12 @@ CommandLineText is null
         */
 
         /// <summary>
-        /// Gets the ValueResult, if any, for the specified option.
+        /// Gets the ValueResult, if any, for the specified option or argument
         /// </summary>
         /// <param name="option">The option for which to find a result.</param>
         /// <returns>A result for the specified option, or <see langword="null"/> if it was not entered by the user.</returns>
-        public CliValueResult? GetValueResult(CliOption option)
-            => GetValueResultInternal(option);
-
-        /// <summary>
-        /// Gets the result, if any, for the specified argument.
-        /// </summary>
-        /// <param name="argument">The argument for which to find a result.</param>
-        /// <returns>A result for the specified argument, or <see langword="null"/> if it was not entered by the user.</returns>
-        public CliValueResult? GetValueResult(CliArgument argument)
-            => GetValueResultInternal(argument);
+        public CliValueResult? GetValueResult(CliValueSymbol valueSymbol)
+            => GetValueResultInternal(valueSymbol);
 
         private CliValueResult? GetValueResultInternal(CliSymbol symbol)
             => valueResultDictionary.TryGetValue(symbol, out var result)