Merge pull request #2421 from KathleenDollard/powderhouse-kad-rename-pipelinecontext

KathleenDollard · web-flow · commit 2946046fadd2 · 2024-05-26T14:43:59.000-04:00
PipelineContext replaced with PipelineResult
diff --git a/src/System.CommandLine.Subsystems.Tests/AlternateSubsystems.cs b/src/System.CommandLine.Subsystems.Tests/AlternateSubsystems.cs
@@ -10,11 +10,11 @@ internal class AlternateSubsystems
     {
         internal class AlternateVersion : VersionSubsystem
         {
-            protected override CliExit Execute(PipelineContext pipelineContext)
+            protected override CliExit Execute(PipelineResult pipelineResult)
             {
-                pipelineContext.ConsoleHack.WriteLine($"***{CliExecutable.ExecutableVersion}***");
-                pipelineContext.AlreadyHandled = true;
-                return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);
+                pipelineResult.ConsoleHack.WriteLine($"***{CliExecutable.ExecutableVersion}***");
+                pipelineResult.AlreadyHandled = true;
+                return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);
             }
         }
 
@@ -29,12 +29,12 @@ public VersionThatUsesHelpData(CliSymbol symbol)
 
             private CliSymbol Symbol { get; }
 
-            protected override CliExit Execute(PipelineContext pipelineContext)
+            protected override CliExit Execute(PipelineResult pipelineResult)
             {
                 TryGetAnnotation(Symbol, HelpAnnotations.Description, out string? description);
-                pipelineContext.ConsoleHack.WriteLine(description);
-                pipelineContext.AlreadyHandled = true;
-                return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);
+                pipelineResult.ConsoleHack.WriteLine(description);
+                pipelineResult.AlreadyHandled = true;
+                return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);
             }
         }
 
@@ -51,10 +51,10 @@ protected override CliConfiguration Initialize(InitializationContext context)
                 return base.Initialize(context);
             }
 
-            protected override CliExit Execute(PipelineContext pipelineContext)
+            protected override CliExit Execute(PipelineResult pipelineResult)
             {
                 ExecutionWasRun = true;
-                return base.Execute(pipelineContext);
+                return base.Execute(pipelineResult);
             }
 
             protected override CliExit TearDown(CliExit cliExit)
diff --git a/src/System.CommandLine.Subsystems.Tests/VersionSubsystemTests.cs b/src/System.CommandLine.Subsystems.Tests/VersionSubsystemTests.cs
@@ -52,7 +52,7 @@ public void Outputs_assembly_version()
         {
             var consoleHack = new ConsoleHack().RedirectToBuffer(true);
             var versionSubsystem = new VersionSubsystem();
-            Subsystem.Execute(versionSubsystem, new PipelineContext(null, "", null, consoleHack));
+            Subsystem.Execute(versionSubsystem, new PipelineResult(null, "", null, consoleHack));
             consoleHack.GetBuffer().Trim().Should().Be(Constants.version);
         }
 
@@ -64,7 +64,7 @@ public void Outputs_specified_version()
             {
                 SpecificVersion = "42"
             };
-            Subsystem.Execute(versionSubsystem, new PipelineContext(null, "", null, consoleHack));
+            Subsystem.Execute(versionSubsystem, new PipelineResult(null, "", null, consoleHack));
             consoleHack.GetBuffer().Trim().Should().Be("42");
         }
 
@@ -76,7 +76,7 @@ public void Outputs_assembly_version_when_specified_version_set_to_null()
             {
                 SpecificVersion = null
             };
-            Subsystem.Execute(versionSubsystem, new PipelineContext(null, "", null, consoleHack));
+            Subsystem.Execute(versionSubsystem, new PipelineResult(null, "", null, consoleHack));
             consoleHack.GetBuffer().Trim().Should().Be(Constants.version);
         }
 
@@ -88,7 +88,7 @@ public void Console_output_can_be_tested()
 
             var consoleHack = new ConsoleHack().RedirectToBuffer(true);
             var versionSubsystem = new VersionSubsystem();
-            Subsystem.Execute(versionSubsystem, new PipelineContext(null, "", null, consoleHack));
+            Subsystem.Execute(versionSubsystem, new PipelineResult(null, "", null, consoleHack));
             consoleHack.GetBuffer().Trim().Should().Be(Constants.version);
         }
 
diff --git a/src/System.CommandLine.Subsystems/CliExit.cs b/src/System.CommandLine.Subsystems/CliExit.cs
@@ -8,8 +8,8 @@ namespace System.CommandLine;
     // TODO: Consider what info is needed after invocation. If it's the whole pipeline context, consider collapsing this with that class.
 public class CliExit
 {
-    internal CliExit(PipelineContext pipelineContext)
-        : this(pipelineContext.ParseResult, pipelineContext.AlreadyHandled, pipelineContext.ExitCode)
+    internal CliExit(PipelineResult pipelineResult)
+        : this(pipelineResult.ParseResult, pipelineResult.AlreadyHandled, pipelineResult.ExitCode)
     { }
 
     private CliExit(ParseResult? parseResult, bool handled, int exitCode)
diff --git a/src/System.CommandLine.Subsystems/CompletionSubsystem.cs b/src/System.CommandLine.Subsystems/CompletionSubsystem.cs
@@ -18,9 +18,9 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)
             ? false
             : false;
 
-    protected internal override CliExit Execute(PipelineContext pipelineContext)
+    protected internal override CliExit Execute(PipelineResult pipelineResult)
     {
-        pipelineContext.ConsoleHack.WriteLine("Not yet implemented");
-        return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);
+        pipelineResult.ConsoleHack.WriteLine("Not yet implemented");
+        return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);
     }
 }
diff --git a/src/System.CommandLine.Subsystems/Directives/DiagramSubsystem.cs b/src/System.CommandLine.Subsystems/Directives/DiagramSubsystem.cs
@@ -13,14 +13,14 @@ public class DiagramSubsystem( IAnnotationProvider? annotationProvider = null)
     //protected internal override bool GetIsActivated(ParseResult? parseResult)
     //   => parseResult is not null && option is not null && parseResult.GetValue(option);
 
-    protected internal override CliExit Execute(PipelineContext pipelineContext)
+    protected internal override CliExit Execute(PipelineResult pipelineResult)
     {
         // Gather locations
-        //var locations = pipelineContext.ParseResult.LocationMap
-        //                   .Concat(Map(pipelineContext.ParseResult.Configuration.PreProcessedLocations));
+        //var locations = pipelineResult.ParseResult.LocationMap
+        //                   .Concat(Map(pipelineResult.ParseResult.Configuration.PreProcessedLocations));
 
-        pipelineContext.ConsoleHack.WriteLine("Output diagram");
-        return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);
+        pipelineResult.ConsoleHack.WriteLine("Output diagram");
+        return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);
     }
 
 
diff --git a/src/System.CommandLine.Subsystems/ErrorReportingSubsystem.cs b/src/System.CommandLine.Subsystems/ErrorReportingSubsystem.cs
@@ -23,14 +23,14 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)
         => parseResult is not null && parseResult.Errors.Any();
 
     // TODO: properly test execute directly when parse result is usable in tests
-    protected internal override CliExit Execute(PipelineContext pipelineContext)
+    protected internal override CliExit Execute(PipelineResult pipelineResult)
     {
-        var _ = pipelineContext.ParseResult
-            ?? throw new ArgumentException("The parse result has not been set", nameof(pipelineContext));
+        var _ = pipelineResult.ParseResult
+            ?? throw new ArgumentException("The parse result has not been set", nameof(pipelineResult));
 
-        Report(pipelineContext.ConsoleHack, pipelineContext.ParseResult.Errors);
+        Report(pipelineResult.ConsoleHack, pipelineResult.ParseResult.Errors);
 
-        return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);
+        return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);
     }
 
     public void Report(ConsoleHack consoleHack, IReadOnlyList<ParseError> errors)
diff --git a/src/System.CommandLine.Subsystems/HelpSubsystem.cs b/src/System.CommandLine.Subsystems/HelpSubsystem.cs
@@ -34,11 +34,11 @@ protected internal override CliConfiguration Initialize(InitializationContext co
     protected internal override bool GetIsActivated(ParseResult? parseResult)
         => parseResult is not null && parseResult.GetValue(HelpOption);
 
-    protected internal override CliExit Execute(PipelineContext pipelineContext)
+    protected internal override CliExit Execute(PipelineResult pipelineResult)
     {
         // TODO: Match testable output pattern
-        pipelineContext.ConsoleHack.WriteLine("Help me!");
-        return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);
+        pipelineResult.ConsoleHack.WriteLine("Help me!");
+        return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);
     }
 
     public bool TryGetDescription (CliSymbol symbol, out string? description)
diff --git a/src/System.CommandLine.Subsystems/Pipeline.cs b/src/System.CommandLine.Subsystems/Pipeline.cs
@@ -62,9 +62,9 @@ public CliExit Execute(CliConfiguration configuration, string[] args, string raw
 
     public CliExit Execute(ParseResult parseResult, string rawInput, ConsoleHack? consoleHack = null)
     {
-        var pipelineContext = new PipelineContext(parseResult, rawInput, this, consoleHack ?? new ConsoleHack());
-        ExecuteSubsystems(pipelineContext);
-        return new CliExit(pipelineContext);
+        var pipelineResult = new PipelineResult(parseResult, rawInput, this, consoleHack ?? new ConsoleHack());
+        ExecuteSubsystems(pipelineResult);
+        return new CliExit(pipelineResult);
     }
 
     // TODO: Consider whether this should be public. It would simplify testing, but would it do anything else
@@ -94,7 +94,7 @@ protected virtual void InitializeSubsystems(InitializationContext context)
     /// <summary>
     /// Perform any cleanup operations
     /// </summary>
-    /// <param name="pipelineContext">The context of the current execution</param>
+    /// <param name="pipelineResult">The context of the current execution</param>
     protected virtual CliExit TearDownSubsystems(CliExit cliExit)
     {
         // TODO: Work on this design as the last cliExit wins and they may not all be well behaved
@@ -109,24 +109,24 @@ protected virtual CliExit TearDownSubsystems(CliExit cliExit)
         return cliExit;
     }
 
-    protected virtual void ExecuteSubsystems(PipelineContext pipelineContext)
+    protected virtual void ExecuteSubsystems(PipelineResult pipelineResult)
     {
-        // TODO: Consider redesign where pipelineContext is not modifiable. 
+        // TODO: Consider redesign where pipelineResult is not modifiable. 
         // 
         foreach (var subsystem in Subsystems)
         {
             if (subsystem is not null)
             {
-                pipelineContext = subsystem.ExecuteIfNeeded(pipelineContext);
+                pipelineResult = subsystem.ExecuteIfNeeded(pipelineResult);
             }
         }
     }
 
-    protected static void ExecuteIfNeeded(CliSubsystem? subsystem, PipelineContext pipelineContext)
+    protected static void ExecuteIfNeeded(CliSubsystem? subsystem, PipelineResult pipelineResult)
     {
-        if (subsystem is not null && (!pipelineContext.AlreadyHandled || subsystem.RunsEvenIfAlreadyHandled))
+        if (subsystem is not null && (!pipelineResult.AlreadyHandled || subsystem.RunsEvenIfAlreadyHandled))
         {
-            subsystem.ExecuteIfNeeded(pipelineContext);
+            subsystem.ExecuteIfNeeded(pipelineResult);
         }
     }
 
diff --git a/src/System.CommandLine.Subsystems/Subsystems/CliSubsystem.cs b/src/System.CommandLine.Subsystems/Subsystems/CliSubsystem.cs
@@ -65,21 +65,21 @@ protected internal bool TryGetAnnotation<TValue>(CliSymbol symbol, AnnotationId<
     /// <summary>
     /// Executes the behavior of the subsystem. For example, help would write information to the console.
     /// </summary>
-    /// <param name="pipelineContext">The context contains data like the ParseResult, and allows setting of values like whether execution was handled and the CLI should terminate </param>
+    /// <param name="pipelineResult">The context contains data like the ParseResult, and allows setting of values like whether execution was handled and the CLI should terminate </param>
     /// <returns>A CliExit object with information such as whether the CLI should terminate</returns>
-    protected internal virtual CliExit Execute(PipelineContext pipelineContext)
-        => CliExit.NotRun(pipelineContext.ParseResult);
+    protected internal virtual CliExit Execute(PipelineResult pipelineResult)
+        => CliExit.NotRun(pipelineResult.ParseResult);
 
-    internal PipelineContext ExecuteIfNeeded(PipelineContext pipelineContext)
-        => ExecuteIfNeeded(pipelineContext.ParseResult, pipelineContext);
+    internal PipelineResult ExecuteIfNeeded(PipelineResult pipelineResult)
+        => ExecuteIfNeeded(pipelineResult.ParseResult, pipelineResult);
 
-    internal PipelineContext ExecuteIfNeeded(ParseResult? parseResult, PipelineContext pipelineContext)
+    internal PipelineResult ExecuteIfNeeded(ParseResult? parseResult, PipelineResult pipelineResult)
     {
         if (GetIsActivated(parseResult))
         {
-            Execute(pipelineContext);
+            Execute(pipelineResult);
         }
-        return pipelineContext;
+        return pipelineResult;
     }
 
 
diff --git a/src/System.CommandLine.Subsystems/Subsystems/PipelineResult.cs b/src/System.CommandLine.Subsystems/Subsystems/PipelineResult.cs
@@ -3,7 +3,7 @@
 
 namespace System.CommandLine.Subsystems;
 
-public class PipelineContext(ParseResult? parseResult, string rawInput, Pipeline? pipeline, ConsoleHack? consoleHack = null)
+public class PipelineResult(ParseResult? parseResult, string rawInput, Pipeline? pipeline, ConsoleHack? consoleHack = null)
 {
     public ParseResult? ParseResult { get; } = parseResult;
     public string RawInput { get; } = rawInput;
diff --git a/src/System.CommandLine.Subsystems/Subsystems/Subsystem.cs b/src/System.CommandLine.Subsystems/Subsystems/Subsystem.cs
@@ -8,22 +8,22 @@ public class Subsystem
     public static void Initialize(CliSubsystem subsystem, CliConfiguration configuration, IReadOnlyList<string> args)
         => subsystem.Initialize(new InitializationContext(configuration, args));
 
-    public static CliExit Execute(CliSubsystem subsystem, PipelineContext pipelineContext)
-        => subsystem.Execute(pipelineContext);
+    public static CliExit Execute(CliSubsystem subsystem, PipelineResult pipelineResult)
+        => subsystem.Execute(pipelineResult);
 
     public static bool GetIsActivated(CliSubsystem subsystem, ParseResult parseResult)
         => subsystem.GetIsActivated(parseResult);
 
     public static CliExit ExecuteIfNeeded(CliSubsystem subsystem, ParseResult parseResult, string rawInput, ConsoleHack? consoleHack = null)
-        => new(subsystem.ExecuteIfNeeded(new PipelineContext(parseResult, rawInput, null, consoleHack)));
+        => new(subsystem.ExecuteIfNeeded(new PipelineResult(parseResult, rawInput, null, consoleHack)));
 
     public static CliExit Execute(CliSubsystem subsystem, ParseResult parseResult, string rawInput, ConsoleHack? consoleHack = null)
-        => subsystem.Execute(new PipelineContext(parseResult, rawInput, null, consoleHack));
+        => subsystem.Execute(new PipelineResult(parseResult, rawInput, null, consoleHack));
 
 
-    internal static PipelineContext ExecuteIfNeeded(CliSubsystem subsystem, ParseResult parseResult, string rawInput, ConsoleHack? consoleHack, PipelineContext? pipelineContext = null)
-        => subsystem.ExecuteIfNeeded(pipelineContext ?? new PipelineContext(parseResult, rawInput, null, consoleHack));
+    internal static PipelineResult ExecuteIfNeeded(CliSubsystem subsystem, ParseResult parseResult, string rawInput, ConsoleHack? consoleHack, PipelineResult? pipelineResult = null)
+        => subsystem.ExecuteIfNeeded(pipelineResult ?? new PipelineResult(parseResult, rawInput, null, consoleHack));
 
-    internal static PipelineContext ExecuteIfNeeded(CliSubsystem subsystem, PipelineContext pipelineContext)
-        => subsystem.ExecuteIfNeeded(pipelineContext);
+    internal static PipelineResult ExecuteIfNeeded(CliSubsystem subsystem, PipelineResult pipelineResult)
+        => subsystem.ExecuteIfNeeded(pipelineResult);
 }
diff --git a/src/System.CommandLine.Subsystems/ValueSubsystem.cs b/src/System.CommandLine.Subsystems/ValueSubsystem.cs
@@ -29,10 +29,10 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)
     /// <remarks>
     /// Note to inheritors: Call base for all ValueSubsystem methods that you override to ensure correct behavior
     /// </remarks>
-    protected internal override CliExit Execute(PipelineContext pipelineContext)
+    protected internal override CliExit Execute(PipelineResult pipelineResult)
     {
-        parseResult ??= pipelineContext.ParseResult;
-        return base.Execute(pipelineContext);
+        parseResult ??= pipelineResult.ParseResult;
+        return base.Execute(pipelineResult);
     }
 
     private void SetValue<T>(CliSymbol symbol, object? value)
diff --git a/src/System.CommandLine.Subsystems/VersionSubsystem.cs b/src/System.CommandLine.Subsystems/VersionSubsystem.cs
@@ -49,15 +49,15 @@ protected internal override CliConfiguration Initialize(InitializationContext co
     protected internal override bool GetIsActivated(ParseResult? parseResult)
         => parseResult is not null && parseResult.GetValue<bool>("--version");
 
-    protected internal override CliExit Execute(PipelineContext pipelineContext)
+    protected internal override CliExit Execute(PipelineResult pipelineResult)
     {
         var subsystemVersion = SpecificVersion;
         var version = subsystemVersion is null
             ? CliExecutable.ExecutableVersion
             : subsystemVersion;
-        pipelineContext.ConsoleHack.WriteLine(version);
-        pipelineContext.AlreadyHandled = true;
-        return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);
+        pipelineResult.ConsoleHack.WriteLine(version);
+        pipelineResult.AlreadyHandled = true;
+        return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -10,11 +10,11 @@ internal class AlternateSubsystems`
`10`	`10`	`{`
`11`	`11`	`internal class AlternateVersion : VersionSubsystem`
`12`	`12`	`{`
`13`		`- protected override CliExit Execute(PipelineContext pipelineContext)`
	`13`	`+ protected override CliExit Execute(PipelineResult pipelineResult)`
`14`	`14`	`{`
`15`		`- pipelineContext.ConsoleHack.WriteLine($"*{CliExecutable.ExecutableVersion}*");`
`16`		`- pipelineContext.AlreadyHandled = true;`
`17`		`- return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);`
	`15`	`+ pipelineResult.ConsoleHack.WriteLine($"*{CliExecutable.ExecutableVersion}*");`
	`16`	`+ pipelineResult.AlreadyHandled = true;`
	`17`	`+ return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);`
`18`	`18`	`}`
`19`	`19`	`}`
`20`	`20`
`@@ -29,12 +29,12 @@ public VersionThatUsesHelpData(CliSymbol symbol)`
`29`	`29`
`30`	`30`	`private CliSymbol Symbol { get; }`
`31`	`31`
`32`		`- protected override CliExit Execute(PipelineContext pipelineContext)`
	`32`	`+ protected override CliExit Execute(PipelineResult pipelineResult)`
`33`	`33`	`{`
`34`	`34`	`TryGetAnnotation(Symbol, HelpAnnotations.Description, out string? description);`
`35`		`- pipelineContext.ConsoleHack.WriteLine(description);`
`36`		`- pipelineContext.AlreadyHandled = true;`
`37`		`- return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);`
	`35`	`+ pipelineResult.ConsoleHack.WriteLine(description);`
	`36`	`+ pipelineResult.AlreadyHandled = true;`
	`37`	`+ return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`
`@@ -51,10 +51,10 @@ protected override CliConfiguration Initialize(InitializationContext context)`
`51`	`51`	`return base.Initialize(context);`
`52`	`52`	`}`
`53`	`53`
`54`		`- protected override CliExit Execute(PipelineContext pipelineContext)`
	`54`	`+ protected override CliExit Execute(PipelineResult pipelineResult)`
`55`	`55`	`{`
`56`	`56`	`ExecutionWasRun = true;`
`57`		`- return base.Execute(pipelineContext);`
	`57`	`+ return base.Execute(pipelineResult);`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`protected override CliExit TearDown(CliExit cliExit)`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public void Outputs_assembly_version()`
`52`	`52`	`{`
`53`	`53`	`var consoleHack = new ConsoleHack().RedirectToBuffer(true);`
`54`	`54`	`var versionSubsystem = new VersionSubsystem();`
`55`		`- Subsystem.Execute(versionSubsystem, new PipelineContext(null, "", null, consoleHack));`
	`55`	`+ Subsystem.Execute(versionSubsystem, new PipelineResult(null, "", null, consoleHack));`
`56`	`56`	`consoleHack.GetBuffer().Trim().Should().Be(Constants.version);`
`57`	`57`	`}`
`58`	`58`
`@@ -64,7 +64,7 @@ public void Outputs_specified_version()`
`64`	`64`	`{`
`65`	`65`	`SpecificVersion = "42"`
`66`	`66`	`};`
`67`		`- Subsystem.Execute(versionSubsystem, new PipelineContext(null, "", null, consoleHack));`
	`67`	`+ Subsystem.Execute(versionSubsystem, new PipelineResult(null, "", null, consoleHack));`
`68`	`68`	`consoleHack.GetBuffer().Trim().Should().Be("42");`
`69`	`69`	`}`
`70`	`70`
`@@ -76,7 +76,7 @@ public void Outputs_assembly_version_when_specified_version_set_to_null()`
`76`	`76`	`{`
`77`	`77`	`SpecificVersion = null`
`78`	`78`	`};`
`79`		`- Subsystem.Execute(versionSubsystem, new PipelineContext(null, "", null, consoleHack));`
	`79`	`+ Subsystem.Execute(versionSubsystem, new PipelineResult(null, "", null, consoleHack));`
`80`	`80`	`consoleHack.GetBuffer().Trim().Should().Be(Constants.version);`
`81`	`81`	`}`
`82`	`82`
`@@ -88,7 +88,7 @@ public void Console_output_can_be_tested()`
`88`	`88`
`89`	`89`	`var consoleHack = new ConsoleHack().RedirectToBuffer(true);`
`90`	`90`	`var versionSubsystem = new VersionSubsystem();`
`91`		`- Subsystem.Execute(versionSubsystem, new PipelineContext(null, "", null, consoleHack));`
	`91`	`+ Subsystem.Execute(versionSubsystem, new PipelineResult(null, "", null, consoleHack));`
`92`	`92`	`consoleHack.GetBuffer().Trim().Should().Be(Constants.version);`
`93`	`93`	`}`
`94`	`94`
Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,9 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)`
`18`	`18`	`? false`
`19`	`19`	`: false;`
`20`	`20`
`21`		`- protected internal override CliExit Execute(PipelineContext pipelineContext)`
	`21`	`+ protected internal override CliExit Execute(PipelineResult pipelineResult)`
`22`	`22`	`{`
`23`		`- pipelineContext.ConsoleHack.WriteLine("Not yet implemented");`
`24`		`- return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);`
	`23`	`+ pipelineResult.ConsoleHack.WriteLine("Not yet implemented");`
	`24`	`+ return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);`
`25`	`25`	`}`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,11 @@ protected internal override CliConfiguration Initialize(InitializationContext co`
`34`	`34`	`protected internal override bool GetIsActivated(ParseResult? parseResult)`
`35`	`35`	`=> parseResult is not null && parseResult.GetValue(HelpOption);`
`36`	`36`
`37`		`- protected internal override CliExit Execute(PipelineContext pipelineContext)`
	`37`	`+ protected internal override CliExit Execute(PipelineResult pipelineResult)`
`38`	`38`	`{`
`39`	`39`	`// TODO: Match testable output pattern`
`40`		`- pipelineContext.ConsoleHack.WriteLine("Help me!");`
`41`		`- return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);`
	`40`	`+ pipelineResult.ConsoleHack.WriteLine("Help me!");`
	`41`	`+ return CliExit.SuccessfullyHandled(pipelineResult.ParseResult);`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`public bool TryGetDescription (CliSymbol symbol, out string? description)`
Original file line number	Diff line number	Diff line change
`@@ -62,9 +62,9 @@ public CliExit Execute(CliConfiguration configuration, string[] args, string raw`
`62`	`62`
`63`	`63`	`public CliExit Execute(ParseResult parseResult, string rawInput, ConsoleHack? consoleHack = null)`
`64`	`64`	`{`
`65`		`- var pipelineContext = new PipelineContext(parseResult, rawInput, this, consoleHack ?? new ConsoleHack());`
`66`		`- ExecuteSubsystems(pipelineContext);`
`67`		`- return new CliExit(pipelineContext);`
	`65`	`+ var pipelineResult = new PipelineResult(parseResult, rawInput, this, consoleHack ?? new ConsoleHack());`
	`66`	`+ ExecuteSubsystems(pipelineResult);`
	`67`	`+ return new CliExit(pipelineResult);`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`// TODO: Consider whether this should be public. It would simplify testing, but would it do anything else`
`@@ -94,7 +94,7 @@ protected virtual void InitializeSubsystems(InitializationContext context)`
`94`	`94`	`/// <summary>`
`95`	`95`	`/// Perform any cleanup operations`
`96`	`96`	`/// </summary>`
`97`		`- /// <param name="pipelineContext">The context of the current execution</param>`
	`97`	`+ /// <param name="pipelineResult">The context of the current execution</param>`
`98`	`98`	`protected virtual CliExit TearDownSubsystems(CliExit cliExit)`
`99`	`99`	`{`
`100`	`100`	`// TODO: Work on this design as the last cliExit wins and they may not all be well behaved`
`@@ -109,24 +109,24 @@ protected virtual CliExit TearDownSubsystems(CliExit cliExit)`
`109`	`109`	`return cliExit;`
`110`	`110`	`}`
`111`	`111`
`112`		`- protected virtual void ExecuteSubsystems(PipelineContext pipelineContext)`
	`112`	`+ protected virtual void ExecuteSubsystems(PipelineResult pipelineResult)`
`113`	`113`	`{`
`114`		`- // TODO: Consider redesign where pipelineContext is not modifiable.`
	`114`	`+ // TODO: Consider redesign where pipelineResult is not modifiable.`
`115`	`115`	`//`
`116`	`116`	`foreach (var subsystem in Subsystems)`
`117`	`117`	`{`
`118`	`118`	`if (subsystem is not null)`
`119`	`119`	`{`
`120`		`- pipelineContext = subsystem.ExecuteIfNeeded(pipelineContext);`
	`120`	`+ pipelineResult = subsystem.ExecuteIfNeeded(pipelineResult);`
`121`	`121`	`}`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`
`125`		`- protected static void ExecuteIfNeeded(CliSubsystem? subsystem, PipelineContext pipelineContext)`
	`125`	`+ protected static void ExecuteIfNeeded(CliSubsystem? subsystem, PipelineResult pipelineResult)`
`126`	`126`	`{`
`127`		`- if (subsystem is not null && (!pipelineContext.AlreadyHandled \|\| subsystem.RunsEvenIfAlreadyHandled))`
	`127`	`+ if (subsystem is not null && (!pipelineResult.AlreadyHandled \|\| subsystem.RunsEvenIfAlreadyHandled))`
`128`	`128`	`{`
`129`		`- subsystem.ExecuteIfNeeded(pipelineContext);`
	`129`	`+ subsystem.ExecuteIfNeeded(pipelineResult);`
`130`	`130`	`}`
`131`	`131`	`}`
`132`	`132`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`namespace System.CommandLine.Subsystems;`
`5`	`5`
`6`		`-public class PipelineContext(ParseResult? parseResult, string rawInput, Pipeline? pipeline, ConsoleHack? consoleHack = null)`
	`6`	`+public class PipelineResult(ParseResult? parseResult, string rawInput, Pipeline? pipeline, ConsoleHack? consoleHack = null)`
`7`	`7`	`{`
`8`	`8`	`public ParseResult? ParseResult { get; } = parseResult;`
`9`	`9`	`public string RawInput { get; } = rawInput;`