Skip to content

Commit 336f568

Browse files
Updated Pipeline to use PipelinePhases
* Removed nested Pipelin.Subsystems * Removed tests due to immutable ValueSubsystem * Fixed bugs found in testing: * Kind needs to be passed to PipelinePhase constructor, Subsystem may be null so is not userful for retrieving * Phase list needs to be added in Pipeline constructor so is available to empty pipeline * PipelinePhrase needs to be a reference type as changes need to be available * Logic for getting specific subsystems didn't account for nulls correclty * Teardown now consistently runs Execute * Invocation and Validation are phases
1 parent f0ead71 commit 336f568

File tree

4 files changed

+252
-146
lines changed

4 files changed

+252
-146
lines changed

src/System.CommandLine.Subsystems.Tests/ValueSubsystemTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public void ValueSubsystem_is_activated_by_default()
2929

3030
isActive.Should().BeTrue();
3131
}
32-
32+
/* Hold these tests until we determine if ValueSubsystem is replaceable
3333
[Fact]
3434
public void ValueSubsystem_returns_values_that_are_entered()
3535
{
@@ -90,4 +90,5 @@ public void ValueSubsystem_returns_calculated_default_value_when_no_value_is_ent
9090
9191
pipeline.Value.GetValue<int>(option).Should().Be(expected);
9292
}
93+
*/
9394
}

src/System.CommandLine.Subsystems/Pipeline.Subsystems.cs

Lines changed: 0 additions & 79 deletions
This file was deleted.

0 commit comments

Comments
 (0)