Fix threading issue with StandardStreamWriter.WriteLine

remcoros · jonsequitur · commit 46289793f57b · 2022-01-19T10:22:57.000-08:00
Fixes #1590 by doing only one Write call to IStandardStreamWriter
diff --git a/src/System.CommandLine/IO/StandardStreamWriter.cs b/src/System.CommandLine/IO/StandardStreamWriter.cs
@@ -63,8 +63,7 @@ public static void WriteLine(this IStandardStreamWriter writer, string value)
                 throw new ArgumentNullException(nameof(writer));
             }
 
-            writer.Write(value);
-            writer.Write(Environment.NewLine);
+            writer.Write(value + Environment.NewLine);
         }
 
         private class TextWriterThatWritesToStandardStreamWriter : TextWriter

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,7 @@ public static void WriteLine(this IStandardStreamWriter writer, string value)`
`63`	`63`	`throw new ArgumentNullException(nameof(writer));`
`64`	`64`	`}`
`65`	`65`
`66`		`- writer.Write(value);`
`67`		`- writer.Write(Environment.NewLine);`
	`66`	`+ writer.Write(value + Environment.NewLine);`
`68`	`67`	`}`
`69`	`68`
`70`	`69`	`private class TextWriterThatWritesToStandardStreamWriter : TextWriter`