Fluent style obscures that there is a single PipelineResult that is mutated.

KathleenDollard · KathleenDollard · commit 7013b470f684 · 2024-05-26T21:08:23.000-04:00
diff --git a/src/System.CommandLine.Subsystems.Tests/AlternateSubsystems.cs b/src/System.CommandLine.Subsystems.Tests/AlternateSubsystems.cs
@@ -10,11 +10,10 @@ internal class AlternateSubsystems
     {
         internal class AlternateVersion : VersionSubsystem
         {
-            protected override PipelineResult Execute(PipelineResult pipelineResult)
+            protected override void Execute(PipelineResult pipelineResult)
             {
                 pipelineResult.ConsoleHack.WriteLine($"***{CliExecutable.ExecutableVersion}***");
                 pipelineResult.SetSuccess();
-                return pipelineResult;
             }
         }
 
@@ -29,13 +28,12 @@ public VersionThatUsesHelpData(CliSymbol symbol)
 
             private CliSymbol Symbol { get; }
 
-            protected override PipelineResult Execute(PipelineResult pipelineResult)
+            protected override void Execute(PipelineResult pipelineResult)
             {
                 TryGetAnnotation(Symbol, HelpAnnotations.Description, out string? description);
                 pipelineResult.ConsoleHack.WriteLine(description);
                 pipelineResult.AlreadyHandled = true;
                 pipelineResult.SetSuccess();
-                return pipelineResult;
             }
         }
 
@@ -45,23 +43,23 @@ internal class VersionWithInitializeAndTeardown : VersionSubsystem
             internal bool ExecutionWasRun;
             internal bool TeardownWasRun;
 
-            protected override CliConfiguration Initialize(InitializationContext context)
+            protected override void Initialize(InitializationContext context)
             {
+                base.Initialize(context);
                 // marker hack needed because ConsoleHack not available in initialization
                 InitializationWasRun = true;
-                return base.Initialize(context);
             }
 
-            protected override PipelineResult Execute(PipelineResult pipelineResult)
+            protected override void Execute(PipelineResult pipelineResult)
             {
                 ExecutionWasRun = true;
-                return base.Execute(pipelineResult);
+                base.Execute(pipelineResult);
             }
 
-            protected override PipelineResult TearDown(PipelineResult pipelineResult)
+            protected override void TearDown(PipelineResult pipelineResult)
             {
                 TeardownWasRun = true;
-                return base.TearDown(pipelineResult);
+                base.TearDown(pipelineResult);
             }
         }
 
diff --git a/src/System.CommandLine.Subsystems/CompletionSubsystem.cs b/src/System.CommandLine.Subsystems/CompletionSubsystem.cs
@@ -18,10 +18,9 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)
             ? false
             : false;
 
-    protected internal override PipelineResult Execute(PipelineResult pipelineResult)
+    protected internal override void Execute(PipelineResult pipelineResult)
     {
         pipelineResult.ConsoleHack.WriteLine("Not yet implemented");
         pipelineResult.SetSuccess();
-        return pipelineResult;
     }
 }
diff --git a/src/System.CommandLine.Subsystems/Directives/DiagramSubsystem.cs b/src/System.CommandLine.Subsystems/Directives/DiagramSubsystem.cs
@@ -13,15 +13,14 @@ public class DiagramSubsystem( IAnnotationProvider? annotationProvider = null)
     //protected internal override bool GetIsActivated(ParseResult? parseResult)
     //   => parseResult is not null && option is not null && parseResult.GetValue(option);
 
-    protected internal override PipelineResult Execute(PipelineResult pipelineResult)
+    protected internal override void Execute(PipelineResult pipelineResult)
     {
         // Gather locations
         //var locations = pipelineResult.ParseResult.LocationMap
         //                   .Concat(Map(pipelineResult.ParseResult.Configuration.PreProcessedLocations));
 
         pipelineResult.ConsoleHack.WriteLine("Output diagram");
         pipelineResult.SetSuccess();
-        return pipelineResult;
     }
 
 
diff --git a/src/System.CommandLine.Subsystems/Directives/DirectiveSubsystem.cs b/src/System.CommandLine.Subsystems/Directives/DirectiveSubsystem.cs
@@ -19,7 +19,7 @@ public DirectiveSubsystem(string name, SubsystemKind kind, IAnnotationProvider?
         Id = id ?? name;
     }
 
-    protected internal override CliConfiguration Initialize(InitializationContext context)
+    protected internal override void Initialize(InitializationContext context)
     {
         for (int i = 0; i < context.Args.Count; i++)
         {
@@ -50,8 +50,6 @@ protected internal override CliConfiguration Initialize(InitializationContext co
                 break;
             }
         }
-
-        return context.Configuration;
     }
 
     protected internal override bool GetIsActivated(ParseResult? parseResult)
diff --git a/src/System.CommandLine.Subsystems/Directives/ResponseSubsystem.cs b/src/System.CommandLine.Subsystems/Directives/ResponseSubsystem.cs
@@ -9,11 +9,8 @@ namespace System.CommandLine.Directives;
 public class ResponseSubsystem()
     : CliSubsystem("Response", SubsystemKind.Response, null)
 {
-    protected internal override CliConfiguration Initialize(InitializationContext context)
-    {
-        context.Configuration.ResponseFileTokenReplacer = Replacer;
-        return context.Configuration;
-    }
+    protected internal override void Initialize(InitializationContext context) 
+        => context.Configuration.ResponseFileTokenReplacer = Replacer;
 
     public static (List<string>? tokens, List<string>? errors) Replacer(string responseSourceName)
     {
diff --git a/src/System.CommandLine.Subsystems/ErrorReportingSubsystem.cs b/src/System.CommandLine.Subsystems/ErrorReportingSubsystem.cs
@@ -23,15 +23,14 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)
         => parseResult is not null && parseResult.Errors.Any();
 
     // TODO: properly test execute directly when parse result is usable in tests
-    protected internal override PipelineResult Execute(PipelineResult pipelineResult)
+    protected internal override void Execute(PipelineResult pipelineResult)
     {
         var _ = pipelineResult.ParseResult
             ?? throw new ArgumentException("The parse result has not been set", nameof(pipelineResult));
 
         Report(pipelineResult.ConsoleHack, pipelineResult.ParseResult.Errors);
 
         pipelineResult.SetSuccess();
-        return pipelineResult;
     }
 
     public void Report(ConsoleHack consoleHack, IReadOnlyList<ParseError> errors)
diff --git a/src/System.CommandLine.Subsystems/HelpSubsystem.cs b/src/System.CommandLine.Subsystems/HelpSubsystem.cs
@@ -24,22 +24,17 @@ public class HelpSubsystem(IAnnotationProvider? annotationProvider = null)
         Arity = ArgumentArity.Zero
     };
 
-    protected internal override CliConfiguration Initialize(InitializationContext context)
-    {
-        context.Configuration.RootCommand.Add(HelpOption);
-
-        return context.Configuration;
-    }
+    protected internal override void Initialize(InitializationContext context) 
+        => context.Configuration.RootCommand.Add(HelpOption);
 
     protected internal override bool GetIsActivated(ParseResult? parseResult)
         => parseResult is not null && parseResult.GetValue(HelpOption);
 
-    protected internal override PipelineResult Execute(PipelineResult pipelineResult)
+    protected internal override void Execute(PipelineResult pipelineResult)
     {
         // TODO: Match testable output pattern
         pipelineResult.ConsoleHack.WriteLine("Help me!");
         pipelineResult.SetSuccess();
-        return pipelineResult;
     }
 
     public bool TryGetDescription (CliSymbol symbol, out string? description)
diff --git a/src/System.CommandLine.Subsystems/Pipeline.cs b/src/System.CommandLine.Subsystems/Pipeline.cs
@@ -57,7 +57,8 @@ public PipelineResult Execute(CliConfiguration configuration, string rawInput, C
     public PipelineResult Execute(CliConfiguration configuration, string[] args, string rawInput, ConsoleHack? consoleHack = null)
     {
         var pipelineResult = Execute(Parse(configuration, args), rawInput, consoleHack);
-        return TearDownSubsystems(pipelineResult);
+        TearDownSubsystems(pipelineResult);
+        return pipelineResult;
     }
 
     public PipelineResult Execute(ParseResult parseResult, string rawInput, ConsoleHack? consoleHack = null)
@@ -95,18 +96,17 @@ protected virtual void InitializeSubsystems(InitializationContext context)
     /// Perform any cleanup operations
     /// </summary>
     /// <param name="pipelineResult">The context of the current execution</param>
-    protected virtual PipelineResult TearDownSubsystems(PipelineResult pipelineResult)
+    protected virtual void TearDownSubsystems(PipelineResult pipelineResult)
     {
         // TODO: Work on this design as the last pipelineResult wins and they may not all be well behaved
         var subsystems = Subsystems.Reverse();
         foreach (var subsystem in subsystems)
         {
             if (subsystem is not null)
             {
-                pipelineResult = subsystem.TearDown(pipelineResult);
+                subsystem.TearDown(pipelineResult);
             }
         }
-        return pipelineResult;
     }
 
     protected virtual void ExecuteSubsystems(PipelineResult pipelineResult)
@@ -117,7 +117,7 @@ protected virtual void ExecuteSubsystems(PipelineResult pipelineResult)
         {
             if (subsystem is not null)
             {
-                pipelineResult = subsystem.ExecuteIfNeeded(pipelineResult);
+                subsystem.ExecuteIfNeeded(pipelineResult);
             }
         }
     }
diff --git a/src/System.CommandLine.Subsystems/Subsystems/CliSubsystem.cs b/src/System.CommandLine.Subsystems/Subsystems/CliSubsystem.cs
@@ -67,11 +67,8 @@ protected internal bool TryGetAnnotation<TValue>(CliSymbol symbol, AnnotationId<
     /// </summary>
     /// <param name="pipelineResult">The context contains data like the ParseResult, and allows setting of values like whether execution was handled and the CLI should terminate </param>
     /// <returns>A PipelineResult object with information such as whether the CLI should terminate</returns>
-    protected internal virtual PipelineResult Execute(PipelineResult pipelineResult)
-    {
-        pipelineResult.NotRun(pipelineResult.ParseResult);
-        return pipelineResult;
-    }
+    protected internal virtual void Execute(PipelineResult pipelineResult) 
+        => pipelineResult.NotRun(pipelineResult.ParseResult);
 
     internal PipelineResult ExecuteIfNeeded(PipelineResult pipelineResult)
         => ExecuteIfNeeded(pipelineResult.ParseResult, pipelineResult);
@@ -110,11 +107,11 @@ internal PipelineResult ExecuteIfNeeded(ParseResult? parseResult, PipelineResult
     /// <returns>True if parsing should continue</returns> // there might be a better design that supports a message
     // TODO: Because of this and similar usage, consider combining CLI declaration and config. ArgParse calls this the parser, which I like
     // TODO: Why does Intitialize return a configuration?
-    protected internal virtual CliConfiguration Initialize(InitializationContext context)
-        => context.Configuration;
+    protected internal virtual void Initialize(InitializationContext context)
+    {}
 
     // TODO: Determine if this is needed.
-    protected internal virtual PipelineResult TearDown(PipelineResult pipelineResult)
-        => pipelineResult;
+    protected internal virtual void TearDown(PipelineResult pipelineResult)
+    {}
 
 }
diff --git a/src/System.CommandLine.Subsystems/Subsystems/Subsystem.cs b/src/System.CommandLine.Subsystems/Subsystems/Subsystem.cs
@@ -8,7 +8,7 @@ public class Subsystem
     public static void Initialize(CliSubsystem subsystem, CliConfiguration configuration, IReadOnlyList<string> args)
         => subsystem.Initialize(new InitializationContext(configuration, args));
 
-    public static PipelineResult Execute(CliSubsystem subsystem, PipelineResult pipelineResult)
+    public static void Execute(CliSubsystem subsystem, PipelineResult pipelineResult)
         => subsystem.Execute(pipelineResult);
 
     public static bool GetIsActivated(CliSubsystem subsystem, ParseResult parseResult)
@@ -18,12 +18,19 @@ public static PipelineResult ExecuteIfNeeded(CliSubsystem subsystem, ParseResult
         => subsystem.ExecuteIfNeeded(new PipelineResult(parseResult, rawInput, null, consoleHack));
 
     public static PipelineResult Execute(CliSubsystem subsystem, ParseResult parseResult, string rawInput, ConsoleHack? consoleHack = null)
-        => subsystem.Execute(new PipelineResult(parseResult, rawInput, null, consoleHack));
-
+    {
+        var pipelineResult = new PipelineResult(parseResult, rawInput,null, consoleHack);
+        subsystem.Execute(pipelineResult);
+        return pipelineResult;
+    }
 
     internal static PipelineResult ExecuteIfNeeded(CliSubsystem subsystem, ParseResult parseResult, string rawInput, ConsoleHack? consoleHack, PipelineResult? pipelineResult = null)
-        => subsystem.ExecuteIfNeeded(pipelineResult ?? new PipelineResult(parseResult, rawInput, null, consoleHack));
+    {
+        pipelineResult ??= new PipelineResult(parseResult, rawInput, null, consoleHack);
+        subsystem.ExecuteIfNeeded(pipelineResult );
+        return pipelineResult;
+    }
 
-    internal static PipelineResult ExecuteIfNeeded(CliSubsystem subsystem, PipelineResult pipelineResult)
+    internal static void ExecuteIfNeeded(CliSubsystem subsystem, PipelineResult pipelineResult)
         => subsystem.ExecuteIfNeeded(pipelineResult);
 }
diff --git a/src/System.CommandLine.Subsystems/ValueSubsystem.cs b/src/System.CommandLine.Subsystems/ValueSubsystem.cs
@@ -29,10 +29,10 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)
     /// <remarks>
     /// Note to inheritors: Call base for all ValueSubsystem methods that you override to ensure correct behavior
     /// </remarks>
-    protected internal override PipelineResult Execute(PipelineResult pipelineResult)
+    protected internal override void Execute(PipelineResult pipelineResult)
     {
         parseResult ??= pipelineResult.ParseResult;
-        return base.Execute(pipelineResult);
+        base.Execute(pipelineResult);
     }
 
     private void SetValue<T>(CliSymbol symbol, object? value)
diff --git a/src/System.CommandLine.Subsystems/VersionSubsystem.cs b/src/System.CommandLine.Subsystems/VersionSubsystem.cs
@@ -34,30 +34,27 @@ public string? SpecificVersion
             ?.GetCustomAttribute<AssemblyInformationalVersionAttribute>()
             ?.InformationalVersion;
 
-    protected internal override CliConfiguration Initialize(InitializationContext context)
+    protected internal override void Initialize(InitializationContext context)
     {
         var option = new CliOption<bool>("--version", ["-v"])
         {
             Arity = ArgumentArity.Zero
         };
         context.Configuration.RootCommand.Add(option);
-
-        return context.Configuration;
     }
 
     // TODO: Stash option rather than using string
     protected internal override bool GetIsActivated(ParseResult? parseResult)
         => parseResult is not null && parseResult.GetValue<bool>("--version");
 
-    protected internal override PipelineResult Execute(PipelineResult pipelineResult)
+    protected internal override void Execute(PipelineResult pipelineResult)
     {
         var subsystemVersion = SpecificVersion;
         var version = subsystemVersion is null
             ? CliExecutable.ExecutableVersion
             : subsystemVersion;
         pipelineResult.ConsoleHack.WriteLine(version);
         pipelineResult.SetSuccess();
-        return pipelineResult;
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -10,11 +10,10 @@ internal class AlternateSubsystems`
`10`	`10`	`{`
`11`	`11`	`internal class AlternateVersion : VersionSubsystem`
`12`	`12`	`{`
`13`		`- protected override PipelineResult Execute(PipelineResult pipelineResult)`
	`13`	`+ protected override void Execute(PipelineResult pipelineResult)`
`14`	`14`	`{`
`15`	`15`	`pipelineResult.ConsoleHack.WriteLine($"*{CliExecutable.ExecutableVersion}*");`
`16`	`16`	`pipelineResult.SetSuccess();`
`17`		`- return pipelineResult;`
`18`	`17`	`}`
`19`	`18`	`}`
`20`	`19`
`@@ -29,13 +28,12 @@ public VersionThatUsesHelpData(CliSymbol symbol)`
`29`	`28`
`30`	`29`	`private CliSymbol Symbol { get; }`
`31`	`30`
`32`		`- protected override PipelineResult Execute(PipelineResult pipelineResult)`
	`31`	`+ protected override void Execute(PipelineResult pipelineResult)`
`33`	`32`	`{`
`34`	`33`	`TryGetAnnotation(Symbol, HelpAnnotations.Description, out string? description);`
`35`	`34`	`pipelineResult.ConsoleHack.WriteLine(description);`
`36`	`35`	`pipelineResult.AlreadyHandled = true;`
`37`	`36`	`pipelineResult.SetSuccess();`
`38`		`- return pipelineResult;`
`39`	`37`	`}`
`40`	`38`	`}`
`41`	`39`
`@@ -45,23 +43,23 @@ internal class VersionWithInitializeAndTeardown : VersionSubsystem`
`45`	`43`	`internal bool ExecutionWasRun;`
`46`	`44`	`internal bool TeardownWasRun;`
`47`	`45`
`48`		`- protected override CliConfiguration Initialize(InitializationContext context)`
	`46`	`+ protected override void Initialize(InitializationContext context)`
`49`	`47`	`{`
	`48`	`+ base.Initialize(context);`
`50`	`49`	`// marker hack needed because ConsoleHack not available in initialization`
`51`	`50`	`InitializationWasRun = true;`
`52`		`- return base.Initialize(context);`
`53`	`51`	`}`
`54`	`52`
`55`		`- protected override PipelineResult Execute(PipelineResult pipelineResult)`
	`53`	`+ protected override void Execute(PipelineResult pipelineResult)`
`56`	`54`	`{`
`57`	`55`	`ExecutionWasRun = true;`
`58`		`- return base.Execute(pipelineResult);`
	`56`	`+ base.Execute(pipelineResult);`
`59`	`57`	`}`
`60`	`58`
`61`		`- protected override PipelineResult TearDown(PipelineResult pipelineResult)`
	`59`	`+ protected override void TearDown(PipelineResult pipelineResult)`
`62`	`60`	`{`
`63`	`61`	`TeardownWasRun = true;`
`64`		`- return base.TearDown(pipelineResult);`
	`62`	`+ base.TearDown(pipelineResult);`
`65`	`63`	`}`
`66`	`64`	`}`
`67`	`65`
Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,9 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)`
`18`	`18`	`? false`
`19`	`19`	`: false;`
`20`	`20`
`21`		`- protected internal override PipelineResult Execute(PipelineResult pipelineResult)`
	`21`	`+ protected internal override void Execute(PipelineResult pipelineResult)`
`22`	`22`	`{`
`23`	`23`	`pipelineResult.ConsoleHack.WriteLine("Not yet implemented");`
`24`	`24`	`pipelineResult.SetSuccess();`
`25`		`- return pipelineResult;`
`26`	`25`	`}`
`27`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,15 +13,14 @@ public class DiagramSubsystem( IAnnotationProvider? annotationProvider = null)`
`13`	`13`	`//protected internal override bool GetIsActivated(ParseResult? parseResult)`
`14`	`14`	`// => parseResult is not null && option is not null && parseResult.GetValue(option);`
`15`	`15`
`16`		`- protected internal override PipelineResult Execute(PipelineResult pipelineResult)`
	`16`	`+ protected internal override void Execute(PipelineResult pipelineResult)`
`17`	`17`	`{`
`18`	`18`	`// Gather locations`
`19`	`19`	`//var locations = pipelineResult.ParseResult.LocationMap`
`20`	`20`	`// .Concat(Map(pipelineResult.ParseResult.Configuration.PreProcessedLocations));`
`21`	`21`
`22`	`22`	`pipelineResult.ConsoleHack.WriteLine("Output diagram");`
`23`	`23`	`pipelineResult.SetSuccess();`
`24`		`- return pipelineResult;`
`25`	`24`	`}`
`26`	`25`
`27`	`26`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public DirectiveSubsystem(string name, SubsystemKind kind, IAnnotationProvider?`
`19`	`19`	`Id = id ?? name;`
`20`	`20`	`}`
`21`	`21`
`22`		`- protected internal override CliConfiguration Initialize(InitializationContext context)`
	`22`	`+ protected internal override void Initialize(InitializationContext context)`
`23`	`23`	`{`
`24`	`24`	`for (int i = 0; i < context.Args.Count; i++)`
`25`	`25`	`{`
`@@ -50,8 +50,6 @@ protected internal override CliConfiguration Initialize(InitializationContext co`
`50`	`50`	`break;`
`51`	`51`	`}`
`52`	`52`	`}`
`53`		`-`
`54`		`- return context.Configuration;`
`55`	`53`	`}`
`56`	`54`
`57`	`55`	`protected internal override bool GetIsActivated(ParseResult? parseResult)`
Original file line number	Diff line number	Diff line change
`@@ -9,11 +9,8 @@ namespace System.CommandLine.Directives;`
`9`	`9`	`public class ResponseSubsystem()`
`10`	`10`	`: CliSubsystem("Response", SubsystemKind.Response, null)`
`11`	`11`	`{`
`12`		`- protected internal override CliConfiguration Initialize(InitializationContext context)`
`13`		`- {`
`14`		`- context.Configuration.ResponseFileTokenReplacer = Replacer;`
`15`		`- return context.Configuration;`
`16`		`- }`
	`12`	`+ protected internal override void Initialize(InitializationContext context)`
	`13`	`+ => context.Configuration.ResponseFileTokenReplacer = Replacer;`
`17`	`14`
`18`	`15`	`public static (List<string>? tokens, List<string>? errors) Replacer(string responseSourceName)`
`19`	`16`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,15 +23,14 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)`
`23`	`23`	`=> parseResult is not null && parseResult.Errors.Any();`
`24`	`24`
`25`	`25`	`// TODO: properly test execute directly when parse result is usable in tests`
`26`		`- protected internal override PipelineResult Execute(PipelineResult pipelineResult)`
	`26`	`+ protected internal override void Execute(PipelineResult pipelineResult)`
`27`	`27`	`{`
`28`	`28`	`var _ = pipelineResult.ParseResult`
`29`	`29`	`?? throw new ArgumentException("The parse result has not been set", nameof(pipelineResult));`
`30`	`30`
`31`	`31`	`Report(pipelineResult.ConsoleHack, pipelineResult.ParseResult.Errors);`
`32`	`32`
`33`	`33`	`pipelineResult.SetSuccess();`
`34`		`- return pipelineResult;`
`35`	`34`	`}`
`36`	`35`
`37`	`36`	`public void Report(ConsoleHack consoleHack, IReadOnlyList<ParseError> errors)`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,8 @@ public PipelineResult Execute(CliConfiguration configuration, string rawInput, C`
`57`	`57`	`public PipelineResult Execute(CliConfiguration configuration, string[] args, string rawInput, ConsoleHack? consoleHack = null)`
`58`	`58`	`{`
`59`	`59`	`var pipelineResult = Execute(Parse(configuration, args), rawInput, consoleHack);`
`60`		`- return TearDownSubsystems(pipelineResult);`
	`60`	`+ TearDownSubsystems(pipelineResult);`
	`61`	`+ return pipelineResult;`
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`public PipelineResult Execute(ParseResult parseResult, string rawInput, ConsoleHack? consoleHack = null)`
`@@ -95,18 +96,17 @@ protected virtual void InitializeSubsystems(InitializationContext context)`
`95`	`96`	`/// Perform any cleanup operations`
`96`	`97`	`/// </summary>`
`97`	`98`	`/// <param name="pipelineResult">The context of the current execution</param>`
`98`		`- protected virtual PipelineResult TearDownSubsystems(PipelineResult pipelineResult)`
	`99`	`+ protected virtual void TearDownSubsystems(PipelineResult pipelineResult)`
`99`	`100`	`{`
`100`	`101`	`// TODO: Work on this design as the last pipelineResult wins and they may not all be well behaved`
`101`	`102`	`var subsystems = Subsystems.Reverse();`
`102`	`103`	`foreach (var subsystem in subsystems)`
`103`	`104`	`{`
`104`	`105`	`if (subsystem is not null)`
`105`	`106`	`{`
`106`		`- pipelineResult = subsystem.TearDown(pipelineResult);`
	`107`	`+ subsystem.TearDown(pipelineResult);`
`107`	`108`	`}`
`108`	`109`	`}`
`109`		`- return pipelineResult;`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`protected virtual void ExecuteSubsystems(PipelineResult pipelineResult)`
`@@ -117,7 +117,7 @@ protected virtual void ExecuteSubsystems(PipelineResult pipelineResult)`
`117`	`117`	`{`
`118`	`118`	`if (subsystem is not null)`
`119`	`119`	`{`
`120`		`- pipelineResult = subsystem.ExecuteIfNeeded(pipelineResult);`
	`120`	`+ subsystem.ExecuteIfNeeded(pipelineResult);`
`121`	`121`	`}`
`122`	`122`	`}`
`123`	`123`	`}`