Move ConsoleHelpers to internal in subsystems

Author: JeanJoeris

src/System.CommandLine/ConsoleHelpers.cs renamed to src/System.CommandLine.Subsystems/ConsoleHelpers.cs

@@ -5,8 +5,7 @@
 
 namespace System.CommandLine
 {
-    // TODO: Added to project and made public for use in ErrorReportingSubsystem
-    public static class ConsoleHelpers
+    internal static class ConsoleHelpers
     {
         private static readonly bool ColorsAreSupported = GetColorsAreSupported();
 
@@ -21,15 +20,15 @@ private static bool GetColorsAreSupported()
 #endif
             && !Console.IsOutputRedirected;
 
-        public static void SetTerminalForegroundRed()
+        internal static void SetTerminalForegroundRed()
         {
             if (ColorsAreSupported)
             {
                 Console.ForegroundColor = ConsoleColor.Red;
             }
         }
 
-        public static void ResetTerminalForegroundColor()
+        internal static void ResetTerminalForegroundColor()
         {
             if (ColorsAreSupported)
             {

src/System.CommandLine.Subsystems/ErrorReportingSubsystem.cs

@@ -26,7 +26,7 @@ protected internal override bool GetIsActivated(ParseResult? parseResult)
     protected internal override CliExit Execute(PipelineContext pipelineContext)
     {
         var _ = pipelineContext.ParseResult
-            ?? throw new ArgumentNullException($"{nameof(pipelineContext)}.ParseResult");
+            ?? throw new ArgumentException("The parse result has not been set", nameof(pipelineContext));
 
         Report(pipelineContext.ConsoleHack, pipelineContext.ParseResult.Errors);
 

src/System.CommandLine/System.CommandLine.csproj

@@ -46,7 +46,6 @@
     <Compile Include="CliOption{T}.cs" />
     <Compile Include="CliRootCommand.cs" />
     <Compile Include="CliSymbol.cs" />
-    <Compile Include="ConsoleHelpers.cs" />
     <Compile Include="LocalizationResources.cs" />
     <Compile Include="ParseResult.cs" />
     <Compile Include="Parsing\ArgumentResult.cs" />