Skip to content

Commit 7aff35a

Browse files
Respond to review
1 parent f14d7d0 commit 7aff35a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/System.CommandLine.Subsystems/Validation/InclusiveGroupValidator.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ public override void Validate(CliCommandResult commandResult,
4141
}
4242
if (missingMembers is not null && missingMembers.Any())
4343
{
44+
// TODO: Rework to allow localization
4445
var pluralToBe = "are";
4546
var singularToBe = "is";
4647
validationContext.PipelineResult.AddError(new ParseError( $"The members {string.Join(", ", groupMembers.Select(m => m.Name))} " +

src/System.CommandLine.Subsystems/Validation/Validator.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ namespace System.CommandLine.Validation;
88
/// <summary>
99
/// Base class for CommandValidator and ValueValidator.
1010
/// </summary>
11+
// TODO: Discuss visibility and custom validators
1112
public abstract class Validator
1213
{
1314
public Validator(string name, Type valueConditionType, params Type[] moreValueConditionTypes)

0 commit comments

Comments
 (0)