Cleanup formatting and make CI pass

Fix CI

Use environment newline

Author: JeanJoeris

src/System.CommandLine.Subsystems.Tests/ErrorReportingFunctionalTests.cs

@@ -131,4 +131,4 @@ public void When_no_help_option_is_present_then_help_is_not_shown_for_parse_erro
         output.ToString().Should().NotShowHelp();
     }
     */
-}
+}

src/System.CommandLine.Subsystems.Tests/ErrorReportingSubsystemTests.cs

@@ -1,70 +1,68 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System.Reflection;
 using FluentAssertions;
 using Xunit;
 using System.CommandLine.Parsing;
-using static System.Runtime.InteropServices.JavaScript.JSType;
 
-namespace System.CommandLine.Subsystems.Tests
+namespace System.CommandLine.Subsystems.Tests;
+
+public class ErrorReportingSubsystemTests
 {
-    public class ErrorReportingSubsystemTests
+    [Fact]
+    public void Report_when_single_error_writes_to_console_hack()
     {
-        [Fact]
-        public void Report_when_single_error_writes_to_console_hack()
-        {
-            var error = new ParseError("a sweet error message");
-            var errors = new List<ParseError> { error };
-            var errorSubsystem = new ErrorReportingSubsystem();
-            var consoleHack = new ConsoleHack().RedirectToBuffer(true);
+        var error = new ParseError("a sweet error message");
+        var errors = new List<ParseError> { error };
+        var errorSubsystem = new ErrorReportingSubsystem();
+        var consoleHack = new ConsoleHack().RedirectToBuffer(true);
 
-            errorSubsystem.Report(consoleHack, errors);
+        errorSubsystem.Report(consoleHack, errors);
 
-            consoleHack.GetBuffer().Trim().Should().Be(error.Message);
-        }
+        consoleHack.GetBuffer().Trim().Should().Be(error.Message);
+    }
 
-        [Fact]
-        public void Report_when_multiple_error_writes_to_console_hack()
-        {
-            var error = new ParseError("a sweet error message");
-            var anotherError = new ParseError("another sweet error message");
-            var errors = new List<ParseError> { error, anotherError };
-            var errorSubsystem = new ErrorReportingSubsystem();
-            var consoleHack = new ConsoleHack().RedirectToBuffer(true);
+    [Fact]
+    public void Report_when_multiple_error_writes_to_console_hack()
+    {
+        var error = new ParseError("a sweet error message");
+        var anotherError = new ParseError("another sweet error message");
+        var errors = new List<ParseError> { error, anotherError };
+        var errorSubsystem = new ErrorReportingSubsystem();
+        var consoleHack = new ConsoleHack().RedirectToBuffer(true);
 
-            errorSubsystem.Report(consoleHack, errors);
+        errorSubsystem.Report(consoleHack, errors);
 
-            consoleHack.GetBuffer().Trim().Should().Be($"{error.Message}\r\n{anotherError.Message}");
-        }
+        consoleHack.GetBuffer().Trim().Should().Be($"{error.Message}{Environment.NewLine}{anotherError.Message}");
+    }
 
-        [Fact]
-        public void Report_when_no_errors_writes_nothing_to_console_hack()
-        {
-            var errors = new List<ParseError> { };
-            var errorSubsystem = new ErrorReportingSubsystem();
-            var consoleHack = new ConsoleHack().RedirectToBuffer(true);
+    [Fact]
+    public void Report_when_no_errors_writes_nothing_to_console_hack()
+    {
+        var errors = new List<ParseError> { };
+        var errorSubsystem = new ErrorReportingSubsystem();
+        var consoleHack = new ConsoleHack().RedirectToBuffer(true);
 
-            errorSubsystem.Report(consoleHack, errors);
+        errorSubsystem.Report(consoleHack, errors);
 
-            consoleHack.GetBuffer().Trim().Should().Be("");
-        }
+        consoleHack.GetBuffer().Trim().Should().Be("");
+    }
 
-        [Theory]
-        [InlineData("-v", false)]
-        [InlineData("-x", true)]
-        [InlineData("", false)]
-        public void GetIsActivated_tests(string input, bool result)
-        {
-            var rootCommand = new CliRootCommand {new CliOption<bool>("-v")};
-            var configuration = new CliConfiguration(rootCommand);
-            var errorSubsystem = new ErrorReportingSubsystem();
-            Subsystem.Initialize(errorSubsystem, configuration);
+    [Theory]
+    [InlineData("-v", false)]
+    [InlineData("-x", true)]
+    [InlineData("", false)]
+    public void GetIsActivated_tests(string input, bool result)
+    {
+        var rootCommand = new CliRootCommand {new CliOption<bool>("-v")};
+        var configuration = new CliConfiguration(rootCommand);
+        var errorSubsystem = new ErrorReportingSubsystem();
+        IReadOnlyList<string> args = [""];
+        Subsystem.Initialize(errorSubsystem, configuration, args);
 
-            var parseResult = CliParser.Parse(rootCommand, input, configuration);
-            var isActive = Subsystem.GetIsActivated(errorSubsystem, parseResult);
+        var parseResult = CliParser.Parse(rootCommand, input, configuration);
+        var isActive = Subsystem.GetIsActivated(errorSubsystem, parseResult);
 
-            isActive.Should().Be(result);
-        }
+        isActive.Should().Be(result);
     }
 }

src/System.CommandLine.Subsystems/ErrorReportingSubsystem.cs

@@ -8,9 +8,10 @@
 namespace System.CommandLine;
 
 /// <summary>
-/// 
+/// Subsystem for reporting errors
 /// </summary>
 /// <remarks>
+/// This class, including interface, is likey to change as powderhouse continues
 /// </remarks>
 public class ErrorReportingSubsystem : CliSubsystem
 {
@@ -21,6 +22,7 @@ public ErrorReportingSubsystem(IAnnotationProvider? annotationProvider = null)
     protected internal override bool GetIsActivated(ParseResult? parseResult)
         => parseResult is not null && parseResult.Errors.Any();
 
+    // TODO: properly test execute directly when parse result is usable in tests
     protected internal override CliExit Execute(PipelineContext pipelineContext)
     {
         var _ = pipelineContext.ParseResult
@@ -31,7 +33,6 @@ protected internal override CliExit Execute(PipelineContext pipelineContext)
         return CliExit.SuccessfullyHandled(pipelineContext.ParseResult);
     }
 
-    // TODO: internal, protected virtual?
     public void Report(ConsoleHack consoleHack, IReadOnlyList<ParseError> errors)
     {
         ConsoleHelpers.ResetTerminalForegroundColor();