Fixed some places Create should have been CreateEmpty

Author: KathleenDollard

src/System.CommandLine.Subsystems.Tests/PipelineTests.cs

@@ -10,7 +10,12 @@ namespace System.CommandLine.Subsystems.Tests
     public class PipelineTests
     {
         private static Pipeline GetTestPipeline(VersionSubsystem versionSubsystem)
-        => Pipeline.Create(version: versionSubsystem);
+        {
+            var pipeline = Pipeline.CreateEmpty();
+            pipeline.Version = versionSubsystem;
+            return pipeline;
+        }
+
         private static CliConfiguration GetNewTestConfiguration()
         => new(new CliRootCommand { new CliOption<bool>("-x") }); // Add option expected by test data
 

src/System.CommandLine.Subsystems.Tests/VersionFunctionalTests.cs

@@ -19,7 +19,7 @@ public class VersionFunctionalTests
         public void When_the_version_option_is_specified_then_the_version_is_written_to_standard_out()
         {
             var configuration = new CliConfiguration(new CliRootCommand());
-            var pipeline = Pipeline.Create();
+            var pipeline = Pipeline.CreateEmpty();
             var consoleHack = new ConsoleHack().RedirectToBuffer(true);
             pipeline.Version = new VersionSubsystem();
 

src/System.CommandLine.Subsystems.Tests/VersionSubsystemTests.cs

@@ -17,7 +17,8 @@ public void When_version_subsystem_is_used_the_version_option_is_added_to_the_ro
                 new CliOption<bool>("-x") // add option that is expected for the test data used here
             };
             var configuration = new CliConfiguration(rootCommand);
-            var pipeline = Pipeline.Create(version: new VersionSubsystem());
+            var pipeline = Pipeline.CreateEmpty();
+            pipeline.Version = new VersionSubsystem();
 
             // Parse is used because directly calling Initialize would be unusual
             var result = pipeline.Parse(configuration, "");
@@ -95,7 +96,8 @@ public void Console_output_can_be_tested()
         public void Custom_version_subsystem_can_be_used()
         {
             var consoleHack = new ConsoleHack().RedirectToBuffer(true);
-            var pipeline = Pipeline.Create(version: new AlternateSubsystems.AlternateVersion());
+            var pipeline = Pipeline.CreateEmpty();
+            pipeline.Version = new AlternateSubsystems.AlternateVersion();
 
             pipeline.Execute(new CliConfiguration(new CliRootCommand()), "-v", consoleHack);
             consoleHack.GetBuffer().Trim().Should().Be($"***{Constants.version}***");
@@ -105,7 +107,8 @@ public void Custom_version_subsystem_can_be_used()
         public void Custom_version_subsystem_can_replace_standard()
         {
             var consoleHack = new ConsoleHack().RedirectToBuffer(true);
-            var pipeline = Pipeline.Create(version: new AlternateSubsystems.AlternateVersion());
+            var pipeline = Pipeline.CreateEmpty();
+            pipeline.Version = new AlternateSubsystems.AlternateVersion();
 
             pipeline.Execute(new CliConfiguration(new CliRootCommand()), "-v", consoleHack);
             consoleHack.GetBuffer().Trim().Should().Be($"***{Constants.version}***");

src/System.CommandLine.Subsystems/Subsystems/PipelineContext.cs

@@ -7,7 +7,7 @@ public class PipelineContext(ParseResult? parseResult, string rawInput, Pipeline
 {
     public ParseResult? ParseResult { get; } = parseResult;
     public string RawInput { get; } = rawInput;
-    public Pipeline Pipeline { get; } = pipeline ?? Pipeline.Create();
+    public Pipeline Pipeline { get; } = pipeline ?? Pipeline.CreateEmpty();
     public ConsoleHack ConsoleHack { get; } = consoleHack ?? new ConsoleHack();
 
     public bool AlreadyHandled { get; set; }