Fix OOM exception thrown in case insensitive replace for an empty string (#11001)

hughbe · jkotas · commit 08c80c57b086 · 2017-04-16T11:36:47.000-07:00
diff --git a/src/mscorlib/src/System/String.Manipulation.cs b/src/mscorlib/src/System/String.Manipulation.cs
@@ -1022,6 +1022,8 @@ private unsafe String ReplaceCore(string oldValue, string newValue, CultureInfo
         {
             if (oldValue == null)
                 throw new ArgumentNullException(nameof(oldValue));
+            if (oldValue.Length == 0)
+                throw new ArgumentException(SR.Argument_StringZeroLength, nameof(oldValue));
 
             // If they asked to replace oldValue with a null, replace all occurences
             // with the empty string.

Original file line number	Diff line number	Diff line change
`@@ -1022,6 +1022,8 @@ private unsafe String ReplaceCore(string oldValue, string newValue, CultureInfo`
`1022`	`1022`	`{`
`1023`	`1023`	`if (oldValue == null)`
`1024`	`1024`	`throw new ArgumentNullException(nameof(oldValue));`
	`1025`	`+ if (oldValue.Length == 0)`
	`1026`	`+ throw new ArgumentException(SR.Argument_StringZeroLength, nameof(oldValue));`
`1025`	`1027`
`1026`	`1028`	`// If they asked to replace oldValue with a null, replace all occurences`
`1027`	`1029`	`// with the empty string.`