Use FD_CLOEXEC instead of equivalent 1 in InternalCreatePipe

stephentoub · stephentoub · commit 0ad3d0d84cf9 · 2017-06-01T09:28:19.000-04:00
diff --git a/src/pal/src/file/file.cpp b/src/pal/src/file/file.cpp
@@ -4056,14 +4056,14 @@ CorUnix::InternalCreatePipe(
 
     /* enable close-on-exec for both pipes; if one gets passed to CreateProcess
        it will be "uncloseonexeced" in order to be inherited */
-    if(-1 == fcntl(readWritePipeDes[0],F_SETFD,1))
+    if(-1 == fcntl(readWritePipeDes[0],F_SETFD,FD_CLOEXEC))
     {
         ASSERT("can't set close-on-exec flag; fcntl() failed. errno is %d "
              "(%s)\n", errno, strerror(errno));
         palError = ERROR_INTERNAL_ERROR;
         goto InternalCreatePipeExit;
     }
-    if(-1 == fcntl(readWritePipeDes[1],F_SETFD,1))
+    if(-1 == fcntl(readWritePipeDes[1],F_SETFD,FD_CLOEXEC))
     {
         ASSERT("can't set close-on-exec flag; fcntl() failed. errno is %d "
              "(%s)\n", errno, strerror(errno));

Original file line number	Diff line number	Diff line change
`@@ -4056,14 +4056,14 @@ CorUnix::InternalCreatePipe(`
`4056`	`4056`
`4057`	`4057`	`/* enable close-on-exec for both pipes; if one gets passed to CreateProcess`
`4058`	`4058`	`it will be "uncloseonexeced" in order to be inherited */`
`4059`		`- if(-1 == fcntl(readWritePipeDes[0],F_SETFD,1))`
	`4059`	`+ if(-1 == fcntl(readWritePipeDes[0],F_SETFD,FD_CLOEXEC))`
`4060`	`4060`	`{`
`4061`	`4061`	`ASSERT("can't set close-on-exec flag; fcntl() failed. errno is %d "`
`4062`	`4062`	`"(%s)\n", errno, strerror(errno));`
`4063`	`4063`	`palError = ERROR_INTERNAL_ERROR;`
`4064`	`4064`	`goto InternalCreatePipeExit;`
`4065`	`4065`	`}`
`4066`		`- if(-1 == fcntl(readWritePipeDes[1],F_SETFD,1))`
	`4066`	`+ if(-1 == fcntl(readWritePipeDes[1],F_SETFD,FD_CLOEXEC))`
`4067`	`4067`	`{`
`4068`	`4068`	`ASSERT("can't set close-on-exec flag; fcntl() failed. errno is %d "`
`4069`	`4069`	`"(%s)\n", errno, strerror(errno));`