Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 13b6b8f

Browse files
committed
Add CI support for updated run-corefx-tests.py
Change CI to build a "GenerateLayoutOnly" drop for corefx testing, specifically to cause the corefx package to be restored, so we can determine its version.
1 parent 9612440 commit 13b6b8f

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

netci.groovy

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1650,7 +1650,12 @@ def static calculateBuildCommands(def newJob, def scenario, def branch, def isPR
16501650
}
16511651

16521652
if (enableCorefxTesting) {
1653-
buildOpts += ' skiptests';
1653+
// We shouldn't need to build the tests. However, run-corefx-tests.py currently depends on having the restored corefx
1654+
// package available, to determine the correct corefx version git commit hash, and we need to build the tests before
1655+
// running "tests\\runtest.cmd GenerateLayoutOnly". So build the pri-0 tests to make this happen.
1656+
//
1657+
// buildOpts += ' skiptests';
1658+
buildOpts += " -priority=0"
16541659
} else {
16551660
buildOpts += " -priority=${priority}"
16561661
}
@@ -1748,6 +1753,10 @@ def static calculateBuildCommands(def newJob, def scenario, def branch, def isPR
17481753
runtestArguments = "${lowerConfiguration} ${arch} ${testOpts}"
17491754

17501755
if (enableCorefxTesting) {
1756+
// Generate the test layout because it restores the corefx package which allows run-corefx-tests.py
1757+
// to determine the correct matching corefx version git commit hash.
1758+
buildCommands += "tests\\runtest.cmd ${runtestArguments} GenerateLayoutOnly"
1759+
17511760
def workspaceRelativeFxRoot = "_/fx"
17521761
def absoluteFxRoot = "%WORKSPACE%\\_\\fx"
17531762

@@ -1916,6 +1925,10 @@ def static calculateBuildCommands(def newJob, def scenario, def branch, def isPR
19161925
// Build coreclr
19171926
buildCommands += "./build.sh verbose ${lowerConfiguration} ${architecture}"
19181927

1928+
// Generate the test layout, which restores the corefx package, and allows run-corefx-tests.py to determine the
1929+
// matching corefx version git commit hash.
1930+
buildCommands += "./build-test.sh ${architecture} ${lowerConfiguration} generatelayoutonly"
1931+
19191932
def scriptFileName = "\$WORKSPACE/set_stress_test_env.sh"
19201933

19211934
def envScriptCmds = envScriptCreate(os, scriptFileName)

0 commit comments

Comments
 (0)