Merged PR 15716: [release/3.1] Use user read+write access for coredump file descriptor open

hoyosjs · wtgodbe · commit 1ef5feaba4dc · 2021-07-08T16:08:32.000Z
diff --git a/src/debug/createdump/dumpwriter.cpp b/src/debug/createdump/dumpwriter.cpp
@@ -61,7 +61,7 @@ DumpWriter::Release()
 bool
 DumpWriter::OpenDump(const char* dumpFileName)
 {
-    m_fd = open(dumpFileName, O_WRONLY|O_CREAT|O_TRUNC, 0664);
+    m_fd = open(dumpFileName, O_WRONLY|O_CREAT|O_TRUNC, S_IWUSR | S_IRUSR);
     if (m_fd == -1)
     {
         fprintf(stderr, "Could not open output %s: %s\n", dumpFileName, strerror(errno));

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ DumpWriter::Release()`
`61`	`61`	`bool`
`62`	`62`	`DumpWriter::OpenDump(const char* dumpFileName)`
`63`	`63`	`{`
`64`		`- m_fd = open(dumpFileName, O_WRONLY\|O_CREAT\|O_TRUNC, 0664);`
	`64`	`+ m_fd = open(dumpFileName, O_WRONLY\|O_CREAT\|O_TRUNC, S_IWUSR \| S_IRUSR);`
`65`	`65`	`if (m_fd == -1)`
`66`	`66`	`{`
`67`	`67`	`fprintf(stderr, "Could not open output %s: %s\n", dumpFileName, strerror(errno));`