Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 461a029

Browse files
committed
Merge pull request #3883 from wtgodbe/rc2_centOS
Switch per-commit CentOS jobs from Checked to Release
2 parents 2b9b04f + 61ba058 commit 461a029

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

netci.groovy

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -245,18 +245,12 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os,
245245
case 'pri1':
246246
// Pri one gets a push trigger, and only for release
247247
if (architecture == 'x64') {
248-
if (configuration == 'Release' && os != 'CentOS7.1') {
249-
// We expect release jobs to be Windows, Ubuntu, or OSX
248+
if (configuration == 'Release') {
249+
// We expect release jobs to be Windows, Ubuntu, CentOS or OSX
250250
assert (os == 'Windows_NT') || (os in Constants.crossList)
251251
if (isFlowJob || os == 'Windows_NT') {
252252
Utilities.addGithubPushTrigger(job)
253253
}
254-
} else if (configuration == 'Checked' && os == 'CentOS7.1') {
255-
// We expect checked jobs to be CentOS flow jobs
256-
assert (os in Constants.crossList)
257-
if (isFlowJob) {
258-
Utilities.addGithubPushTrigger(job)
259-
}
260254
}
261255
}
262256
break
@@ -283,7 +277,7 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os,
283277
break
284278
case 'ilrt':
285279
// ILASM/ILDASM roundtrip one gets a daily build, and only for release
286-
if (architecture == 'x64' && configuration == 'Release' && os != 'CentOS7.1') {
280+
if (architecture == 'x64' && configuration == 'Release') {
287281
// We don't expect to see a job generated except in these scenarios
288282
assert (os == 'Windows_NT') || (os in Constants.crossList)
289283
if (isFlowJob || os == 'Windows_NT') {
@@ -509,7 +503,7 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os,
509503
case 'CentOS7.1':
510504
switch (scenario) {
511505
case 'pri1':
512-
if (configuration == 'Checked') {
506+
if (configuration == 'Release') {
513507
Utilities.addGithubPRTriggerForBranch(job, branch, "${os} ${architecture} ${configuration} Priority 1 Build and Test", "(?i).*test\\W+${os}\\W+${scenario}.*")
514508
}
515509
break
@@ -1100,7 +1094,7 @@ combinedScenarios.each { scenario ->
11001094
} // isPR
11011095
} // scenario
11021096

1103-
// Create the Linux/OSX coreclr test leg for debug and release and each scenario
1097+
// Create the Linux/OSX/CentOS coreclr test leg for debug and release and each scenario
11041098
combinedScenarios.each { scenario ->
11051099
[true, false].each { isPR ->
11061100
// Architectures. x64 only at this point
@@ -1117,12 +1111,12 @@ combinedScenarios.each { scenario ->
11171111
return
11181112
}
11191113
}
1120-
// For CentOS, we only want Checked pri1 builds.
1114+
// For CentOS, we only want Checked/Release pri1 builds.
11211115
else if (os == 'CentOS7.1') {
11221116
if (scenario != 'pri1' && scenario != 'r2r' && scenario != 'pri1r2r') {
11231117
return
11241118
}
1125-
if (configuration != 'Checked') {
1119+
if (configuration != 'Checked' && configuration != 'Release') {
11261120
return
11271121
}
11281122
}

0 commit comments

Comments
 (0)