Remove AppDomainLeaks configuration option (#15956)

Removed all usages of AppDomainLeaks configuration option and
CHECK_APP_DOMAIN_LEAKS feature

Fix #12094

Author: antofik

src/gc/gcinterface.h

@@ -844,11 +844,11 @@ struct ScanContext
     uintptr_t stack_limit; // Lowest point on the thread stack that the scanning logic is permitted to read
     bool promotion; //TRUE: Promotion, FALSE: Relocation.
     bool concurrent; //TRUE: concurrent scanning 
-#if CHECK_APP_DOMAIN_LEAKS || defined (FEATURE_APPDOMAIN_RESOURCE_MONITORING) || defined (DACCESS_COMPILE)
+#if defined (FEATURE_APPDOMAIN_RESOURCE_MONITORING) || defined (DACCESS_COMPILE)
     AppDomain *pCurrentDomain;
 #else
     void* _unused1;
-#endif //CHECK_APP_DOMAIN_LEAKS || FEATURE_APPDOMAIN_RESOURCE_MONITORING || DACCESS_COMPILE
+#endif //FEATURE_APPDOMAIN_RESOURCE_MONITORING || DACCESS_COMPILE
 
 #if defined(GC_PROFILING) || defined (DACCESS_COMPILE)
     MethodDesc *pMD;

src/gc/handletable.cpp

@@ -368,15 +368,6 @@ void ValidateFetchObjrefForHandle(OBJECTREF objref, ADIndex appDomainIndex)
     _ASSERTE(pDomain != NULL);
     _ASSERTE(!pDomain->NoAccessToHandleTable());
 
-#if CHECK_APP_DOMAIN_LEAKS
-    if (g_pConfig->AppDomainLeaks() && objref != NULL)
-    {
-        if (appDomainIndex.m_dwIndex)
-            objref->TryAssignAppDomain(pDomain);
-        else
-            objref->TrySetAppDomainAgile();
-    }
-#endif
     END_DEBUG_ONLY_CODE;
 }
 
@@ -398,15 +389,6 @@ void ValidateAssignObjrefForHandle(OBJECTREF objref, ADIndex appDomainIndex)
     _ASSERTE(pDomain != NULL);
     _ASSERTE(!pDomain->NoAccessToHandleTable());
 
-#if CHECK_APP_DOMAIN_LEAKS
-    if (g_pConfig->AppDomainLeaks() && objref != NULL)
-    {
-        if (appDomainIndex.m_dwIndex)
-            objref->TryAssignAppDomain(pDomain);
-        else
-            objref->TrySetAppDomainAgile();
-    }
-#endif
     END_DEBUG_ONLY_CODE;
 }
 

src/inc/eetwain.h

@@ -40,11 +40,7 @@
 #define HAS_QUICKUNWIND
 #endif
 
-#if CHECK_APP_DOMAIN_LEAKS
-#define CHECK_APP_DOMAIN    GC_CALL_CHECK_APP_DOMAIN
-#else
 #define CHECK_APP_DOMAIN    0
-#endif
 
 #define NO_OVERRIDE_OFFSET (DWORD)-1
 

src/strongname/api/common.h

@@ -246,11 +246,6 @@ inline void* memcpyUnsafe(void *dest, const void *src, size_t len)
     extern "C" void *  __cdecl GCSafeMemCpy(void *, const void *, size_t);
     #define memcpy(dest, src, len) GCSafeMemCpy(dest, src, len)
     #endif // !defined(memcpy)
-
-
-    #if !defined(CHECK_APP_DOMAIN_LEAKS)
-    #define CHECK_APP_DOMAIN_LEAKS 1
-    #endif
 #else // !_DEBUG && !DACCESS_COMPILE && !CROSSGEN_COMPILE
     inline void* memcpyNoGCRefs(void * dest, const void * src, size_t len) {
             WRAPPER_NO_CONTRACT;

src/vm/amd64/JitHelpers_Fast.asm

@@ -754,22 +754,6 @@ LEAF_ENTRY JIT_Stelem_Ref, _TEXT
         test    r8, r8
         jz      AssigningNull
 
-ifdef CHECK_APP_DOMAIN_LEAKS
-        ; get Array TypeHandle
-        mov     r9, [r10 + OFFSETOF__MethodTable__m_ElementType]   ; 10h -> typehandle offset
-        ; check for non-MT
-        test    r9, 2
-        jnz     NoCheck
-
-        ; Check VMflags of element type
-        mov     r9, [r9 + OFFSETOF__MethodTable__m_pEEClass]
-        mov     r9d, dword ptr [r9 + OFFSETOF__EEClass__m_wAuxFlags]
-        test    r9d, EEClassFlags
-        jnz     ArrayStoreCheck_Helper
-
-    NoCheck:
-endif
-
         mov     r9, [r10 + OFFSETOF__MethodTable__m_ElementType]   ; 10h -> typehandle offset
 
         ; check for exact match

src/vm/amd64/jithelpers_fast.S

@@ -410,22 +410,6 @@ LEAF_ENTRY JIT_Stelem_Ref, _TEXT
         test    rdx, rdx
         jz      LOCAL_LABEL(AssigningNull)
 
-#ifdef CHECK_APP_DOMAIN_LEAKS     
-        // get Array TypeHandle
-        mov     rcx, [r10 + OFFSETOF__MethodTable__m_ElementType]   // 10h -> typehandle offset, 
-        // check for non-MT
-        test    rcx, 2
-        jnz     LOCAL_LABEL(NoCheck)
-
-        // Check VMflags of element type
-        mov     rcx, [rcx + OFFSETOF__MethodTable__m_pEEClass]
-        mov     ecx, dword ptr [rcx + OFFSETOF__EEClass__m_wAuxFlags]
-        test    ecx, EEClassFlags
-        jnz     C_FUNC(ArrayStoreCheck_Helper)
-
-    LOCAL_LABEL(NoCheck):
-#endif
-
         mov     rcx, [r10 + OFFSETOF__MethodTable__m_ElementType]   // 10h -> typehandle offset
 
         // check for exact match

src/vm/appdomain.cpp

@@ -2292,9 +2292,6 @@ void SystemDomain::PreallocateSpecialObjects()
     _ASSERTE(g_pPreallocatedSentinelObject == NULL);
 
     OBJECTREF pPreallocatedSentinalObject = AllocateObject(g_pObjectClass);
-#if CHECK_APP_DOMAIN_LEAKS
-    pPreallocatedSentinalObject->SetSyncBlockAppDomainAgile();
-#endif
     g_pPreallocatedSentinelObject = CreatePinningHandle( pPreallocatedSentinalObject );
 
 #ifdef FEATURE_PREJIT
@@ -2346,19 +2343,13 @@ void SystemDomain::CreatePreallocatedExceptions()
 
 
     EXCEPTIONREF pRudeAbortException = (EXCEPTIONREF)AllocateObject(g_pThreadAbortExceptionClass);
-#if CHECK_APP_DOMAIN_LEAKS
-    pRudeAbortException->SetSyncBlockAppDomainAgile();
-#endif
     pRudeAbortException->SetHResult(COR_E_THREADABORTED);
     pRudeAbortException->SetXCode(EXCEPTION_COMPLUS);
     _ASSERTE(g_pPreallocatedRudeThreadAbortException == NULL);
     g_pPreallocatedRudeThreadAbortException = CreateHandle(pRudeAbortException);
 
 
     EXCEPTIONREF pAbortException = (EXCEPTIONREF)AllocateObject(g_pThreadAbortExceptionClass);
-#if CHECK_APP_DOMAIN_LEAKS
-    pAbortException->SetSyncBlockAppDomainAgile();
-#endif
     pAbortException->SetHResult(COR_E_THREADABORTED);
     pAbortException->SetXCode(EXCEPTION_COMPLUS);
     _ASSERTE(g_pPreallocatedThreadAbortException == NULL);
@@ -8200,12 +8191,6 @@ void AppDomain::Close()
     LOG((LF_APPDOMAIN | LF_CORDB, LL_INFO10, "AppDomain::Domain [%d] %#08x %ls is collected.\n",
          GetId().m_dwId, this, GetFriendlyNameForLogging()));
 
-
-#if CHECK_APP_DOMAIN_LEAKS
-    if (g_pConfig->AppDomainLeaks())
-        // at this point shouldn't have any non-agile objects in the heap because we finalized all the non-agile ones.
-        SyncBlockCache::GetSyncBlockCache()->CheckForUnloadedInstances(GetIndex());
-#endif // CHECK_APP_DOMAIN_LEAKS
     {
         GCX_PREEMP();
         RemoveMemoryPressure();

src/vm/appdomain.hpp

@@ -1290,10 +1290,6 @@ class BaseDomain
     OBJECTHANDLE CreatePinningHandle(OBJECTREF object)
     {
         WRAPPER_NO_CONTRACT;
-#if CHECK_APP_DOMAIN_LEAKS
-        if(IsAppDomain())
-            object->TryAssignAppDomain((AppDomain*)this,TRUE);
-#endif
         return ::CreatePinningHandle(m_handleStore, object);
     }
 

src/vm/arm/stubs.cpp

@@ -2512,11 +2512,6 @@ void InitJITHelpers1()
 {
     STANDARD_VM_CONTRACT;
 
-#if CHECK_APP_DOMAIN_LEAKS
-    if(g_pConfig->AppDomainLeaks())
-        SetJitHelperFunction(CORINFO_HELP_ARRADDR_ST, JIT_Stelem_Ref_Portable);
-#endif
-
     // Allocation helpers, faster but non-logging.
     if (!(TrackAllocationsEnabled()
           || LoggingOn(LF_GCALLOC, LL_INFO10)

src/vm/array.cpp

@@ -432,7 +432,7 @@ MethodTable* Module::CreateArrayMethodTable(TypeHandle elemTypeHnd, CorElementTy
         pClass->SetArrayElementType (elemType);
         pClass->SetMethodTable (pMT);
 
-#if defined(CHECK_APP_DOMAIN_LEAKS) || defined(_DEBUG)
+#if defined(_DEBUG)
         // Non-covariant arrays of agile types are agile
         if (elemType != ELEMENT_TYPE_CLASS && elemTypeHnd.IsAppDomainAgile())
             pClass->SetAppDomainAgile();