Merge pull request #6106 from mikedn/modopt-feedback

BruceForstall · web-flow · commit 59c6500f2f10 · 2016-07-05T09:31:21.000-07:00
Address div/mod CR feedback
diff --git a/src/jit/codegenarm64.cpp b/src/jit/codegenarm64.cpp
@@ -2460,8 +2460,6 @@ CodeGen::genCodeForTreeNode(GenTreePtr treeNode)
             GenTreePtr divisorOp = treeNode->gtGetOp2();
             emitAttr   size      = EA_ATTR(genTypeSize(genActualType(treeNode->TypeGet())));
 
-            // TODO-ARM64-CQ: Optimize a divide by power of 2 as we do for AMD64
-
             if (divisorOp->IsIntegralConst(0))
             {
                 // We unconditionally throw a divide by zero exception
diff --git a/src/jit/lower.cpp b/src/jit/lower.cpp
@@ -4030,6 +4030,7 @@ void Lowering::LowerUnsignedDivOrMod(GenTree* tree)
 //
 // Arguments:
 //    pTree:   pointer to the parent node's link to the node we care about
+//    data:    fgWalkData which is used to get info about parents and fixup call args
 
 void Lowering::LowerSignedDivOrMod(GenTreePtr* ppTree, Compiler::fgWalkData* data)
 {

Original file line number	Diff line number	Diff line change
`@@ -2460,8 +2460,6 @@ CodeGen::genCodeForTreeNode(GenTreePtr treeNode)`
`2460`	`2460`	`GenTreePtr divisorOp = treeNode->gtGetOp2();`
`2461`	`2461`	`emitAttr size = EA_ATTR(genTypeSize(genActualType(treeNode->TypeGet())));`
`2462`	`2462`
`2463`		`- // TODO-ARM64-CQ: Optimize a divide by power of 2 as we do for AMD64`
`2464`		`-`
`2465`	`2463`	`if (divisorOp->IsIntegralConst(0))`
`2466`	`2464`	`{`
`2467`	`2465`	`// We unconditionally throw a divide by zero exception`
Original file line number	Diff line number	Diff line change
`@@ -4030,6 +4030,7 @@ void Lowering::LowerUnsignedDivOrMod(GenTree* tree)`
`4030`	`4030`	`//`
`4031`	`4031`	`// Arguments:`
`4032`	`4032`	`// pTree: pointer to the parent node's link to the node we care about`
	`4033`	`+// data: fgWalkData which is used to get info about parents and fixup call args`
`4033`	`4034`
`4034`	`4035`	`void Lowering::LowerSignedDivOrMod(GenTreePtr* ppTree, Compiler::fgWalkData* data)`
`4035`	`4036`	`{`