Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 63325a3

Browse files
author
José Rivero
committed
Allow to run all benchmarks and even upload, but fail the job.
1 parent 299946a commit 63325a3

File tree

1 file changed

+26
-2
lines changed

1 file changed

+26
-2
lines changed

tests/scripts/run-xunit-perf.cmd

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,23 @@ setlocal
3232
call :run_cmd xcopy /sy "%CORECLR_REPO%\bin\tests\Windows_NT.%TEST_ARCH%.%TEST_CONFIG%\Tests\Core_Root"\* . >> %RUNLOG% || exit /b 1
3333

3434
rem find and stage the tests
35+
set /A "LV_FAILURES=0"
3536
for /R %CORECLR_PERF% %%T in (*.%TEST_FILE_EXT%) do (
37+
rem Skip known failures
3638
call :run_benchmark %%T || (
37-
IF /I NOT "%BENCHVIEW_RUN_TYPE%" == "local" exit /b 1
39+
set /A "LV_FAILURES+=1"
3840
)
3941
)
4042

4143
rem optionally upload results to benchview
4244
if not [%BENCHVIEW_PATH%] == [] (
43-
call :upload_to_benchview
45+
call :upload_to_benchview || exit /b 1
46+
)
47+
48+
rem Numbers are limited to 32-bits of precision (Int32.MAX == 2^32 - 1).
49+
if %LV_FAILURES% NEQ 0 (
50+
call :print_error %LV_FAILURES% benchmarks has failed.
51+
exit /b %LV_FAILURES%
4452
)
4553

4654
exit /b %ERRORLEVEL%
@@ -307,3 +315,19 @@ rem ****************************************************************************
307315
call :print_to_console $ %*
308316
call %*
309317
exit /b %ERRORLEVEL%
318+
319+
:skip_failures
320+
rem ****************************************************************************
321+
rem Skip known failures
322+
rem ****************************************************************************
323+
IF /I [%TEST_ARCHITECTURE%] == [x86jit32] (
324+
IF /I "%~1" == "CscBench" (
325+
rem https://github.com/dotnet/coreclr/issues/11088
326+
exit /b 1
327+
)
328+
IF /I "%~1" == "SciMark2" (
329+
rem https://github.com/dotnet/coreclr/issues/11089
330+
exit /b 1
331+
)
332+
)
333+
exit /b 0

0 commit comments

Comments
 (0)