Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 6521f07

Browse files
committed
Update CheckProjects to not fail for non-dev CORE_ROOT
CheckProjects expects to be able to find the jit test project files relative to the value of the `CORE_ROOT` environment variable. This fails when we have test setups like cross-tests or helix where the test binary tree has been copied away from the repo after building. Tolerate these cases by returning a success code if the `CORE_ROOT` path is not pointing at the expected place. Fixes #11079. Fixes #10635.
1 parent fc3a969 commit 6521f07

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/src/JIT/CheckProjects/CheckProjects.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ private static int Main(string[] args)
5252

5353
if (binIndex < 0)
5454
{
55-
Console.WriteLine("CORE_ROOT must be set to full path to repo test dir; was '{0}'.",
56-
coreRoot);
57-
return -1;
55+
Console.WriteLine("No bin directory found in CORE_ROOT path `{0}`," +
56+
" so no checking will be performed.", coreRoot);
57+
return 100;
5858
}
5959

6060
string repoRoot = coreRoot.Substring(0, binIndex);
@@ -78,8 +78,8 @@ private static int Main(string[] args)
7878

7979
if (!Directory.Exists(projectRoot))
8080
{
81-
Console.WriteLine("Project directory does not exist");
82-
return -1;
81+
Console.WriteLine("Project directory does not exist, so no checking will be performed.");
82+
return 100;
8383
}
8484

8585
DirectoryInfo projectRootDir = new DirectoryInfo(projectRoot);

0 commit comments

Comments
 (0)