Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 6c7951b

Browse files
wtgodbedanmoseley
authored andcommitted
Port 'Pass --build-id=sha1 to linker explicitly' to 1.0.0 (#20326)
Without this, some Linux native binaries don't get a `BuildId` marker set, which causes the MSDL symbol server to reject them. We never caught this before because the old Symbol publish tool didn't publish these binaries. CC @mikem8361 @leecow @weshaggard @janvorli @leculver Port of #5937 #### Description This fixes an issue where some Linux native binaries were being built without a `BuildId` marker metadata. The symbol servers we publish to require that binaries have this marker, as they use it to create an ID for indexing. Without it, our symbol publish will fail during official releases (this happened this Tuesday, causing us to scramble and delay the release by a few hours). #### Customer Impact Customers had a bad experience on Release day because of this, as it caused the 1.x.x servicing release to be delayed. Fixing it will prevent this from causing that to happen again. #### Regression? No #### Risk None that I'm aware of
1 parent a901496 commit 6c7951b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,9 @@ elseif (CLR_CMAKE_PLATFORM_UNIX)
363363
endif(WIN32)
364364

365365
if(CLR_CMAKE_PLATFORM_LINUX)
366-
set(CMAKE_ASM_FLAGS "${CMAKE_ASM_FLAGS} -Wa,--noexecstack")
366+
set(CMAKE_ASM_FLAGS "${CMAKE_ASM_FLAGS} -Wa,--noexecstack")
367+
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--build-id=sha1")
368+
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--build-id=sha1")
367369
endif(CLR_CMAKE_PLATFORM_LINUX)
368370

369371
#------------------------------------

0 commit comments

Comments
 (0)