Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 93c5ea9

Browse files
committed
Revert "Add un-prefixed signatures as temporary workaround"
This reverts commit fb80bad.
1 parent cf66383 commit 93c5ea9

File tree

2 files changed

+0
-36
lines changed

2 files changed

+0
-36
lines changed

src/corefx/System.Globalization.Native/idna.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,6 @@ extern "C" int32_t GlobalizationNative_ToAscii(
5353
return ((U_SUCCESS(err) || (err == U_BUFFER_OVERFLOW_ERROR)) && (info.errors == 0)) ? asciiStrLen : 0;
5454
}
5555

56-
// TODO: temporarily keeping the un-prefixed signature of this method
57-
// to keep tests running in CI. This will be removed once the corefx managed assemblies
58-
// are synced up with the native assemblies.
59-
extern "C" int32_t ToAscii(
60-
uint32_t flags, const UChar* lpSrc, int32_t cwSrcLength, UChar* lpDst, int32_t cwDstLength)
61-
{
62-
return GlobalizationNative_ToAscii(flags, lpSrc, cwSrcLength, lpDst, cwDstLength);
63-
}
64-
6556
/*
6657
Function:
6758
ToUnicode
@@ -87,12 +78,3 @@ extern "C" int32_t GlobalizationNative_ToUnicode(
8778

8879
return ((U_SUCCESS(err) || (err == U_BUFFER_OVERFLOW_ERROR)) && (info.errors == 0)) ? unicodeStrLen : 0;
8980
}
90-
91-
// TODO: temporarily keeping the un-prefixed signature of this method
92-
// to keep tests running in CI. This will be removed once the corefx managed assemblies
93-
// are synced up with the native assemblies.
94-
extern "C" int32_t ToUnicode(
95-
int32_t flags, const UChar* lpSrc, int32_t cwSrcLength, UChar* lpDst, int32_t cwDstLength)
96-
{
97-
return GlobalizationNative_ToUnicode(flags, lpSrc, cwSrcLength, lpDst, cwDstLength);
98-
}

src/corefx/System.Globalization.Native/normalization.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,6 @@ extern "C" int32_t GlobalizationNative_IsNormalized(
6565
}
6666
}
6767

68-
// TODO: temporarily keeping the un-prefixed signature of this method
69-
// to keep tests running in CI. This will be removed once the corefx managed assemblies
70-
// are synced up with the native assemblies.
71-
extern "C" int32_t IsNormalized(
72-
NormalizationForm normalizationForm, const UChar* lpStr, int32_t cwStrLength)
73-
{
74-
return GlobalizationNative_IsNormalized(normalizationForm, lpStr, cwStrLength);
75-
}
76-
7768
/*
7869
Function:
7970
NormalizeString
@@ -95,12 +86,3 @@ extern "C" int32_t GlobalizationNative_NormalizeString(
9586

9687
return (U_SUCCESS(err) || (err == U_BUFFER_OVERFLOW_ERROR)) ? normalizedLen : 0;
9788
}
98-
99-
// TODO: temporarily keeping the un-prefixed signature of this method
100-
// to keep tests running in CI. This will be removed once the corefx managed assemblies
101-
// are synced up with the native assemblies.
102-
extern "C" int32_t NormalizeString(
103-
NormalizationForm normalizationForm, const UChar* lpSrc, int32_t cwSrcLength, UChar* lpDst, int32_t cwDstLength)
104-
{
105-
return GlobalizationNative_NormalizeString(normalizationForm, lpSrc, cwSrcLength, lpDst, cwDstLength);
106-
}

0 commit comments

Comments
 (0)