Fix ilasm managed resource lookup on Linux. (#28104)

* Fix ilasm path parsing on *nix.

ILAsm did not properly parse paths on *nix systems, which notably broke
the inclusion of managed resources in an assembly. This commit enables
ILAsm to support both types of directory separators by relying on the
DIRECTORY_SEPARATOR_CHAR_A macro where relevant.

* Only consider colon as a special path character on Windows.

We rely on the FEATURE_PAL macro to determine whether we are targeting a
*nix platform.

Author: MarkpageBxl

src/ilasm/asmman.cpp

@@ -965,8 +965,10 @@ HRESULT AsmMan::EmitManifest()
                 for(j=0; (hFile == INVALID_HANDLE_VALUE)&&(pwzInputFiles[j] != NULL); j++)
                 {
                     wcscpy_s(wzFileName,2048,pwzInputFiles[j]);
-                    pwz = wcsrchr(wzFileName,'\\');
+                    pwz = wcsrchr(wzFileName,DIRECTORY_SEPARATOR_CHAR_A);
+#ifndef FEATURE_PAL
                     if(pwz == NULL) pwz = wcsrchr(wzFileName,':');
+#endif
                     if(pwz == NULL) pwz = &wzFileName[0];
                     else pwz++;
                     wcscpy_s(pwz,2048-(pwz-wzFileName),wzUniBuf);

src/ilasm/grammar_after.cpp

@@ -845,7 +845,11 @@ int yylex()
                             if(wzFile != NULL)
                             {
                                 if((parser->wzIncludePath != NULL)
-                                 &&(wcschr(wzFile,'\\')==NULL)&&(wcschr(wzFile,':')==NULL))
+                                 &&(wcschr(wzFile,DIRECTORY_SEPARATOR_CHAR_A)==NULL)
+#ifndef FEATURE_PAL
+                                 &&(wcschr(wzFile,':')==NULL)
+#endif
+                                )
                                 {
                                     PathString wzFullName;
 

src/ilasm/main.cpp

@@ -67,7 +67,7 @@ void MakeProperSourceFileName(__in __nullterminated WCHAR* wzOrigName,
     {
         j--;
         if(wzProperName[j] == '.') break;
-        if((wzProperName[j] == '\\')||(j == 0))
+        if((wzProperName[j] == DIRECTORY_SEPARATOR_CHAR_A)||(j == 0))
         {
             wcscat_s(wzProperName,MAX_FILENAME_LENGTH,W(".il"));
             break;

src/ilasm/writer.cpp

@@ -332,8 +332,10 @@ HRESULT Assembler::CreateExportDirectory()
     char*                   szOutputFileName = new char[Ldllname];
     memset(szOutputFileName,0,wcslen(m_wzOutputFileName)*3+3);
     WszWideCharToMultiByte(CP_ACP,0,m_wzOutputFileName,-1,szOutputFileName,Ldllname,NULL,NULL);
-    pszDllName = strrchr(szOutputFileName,'\\');
+    pszDllName = strrchr(szOutputFileName,DIRECTORY_SEPARATOR_CHAR_A);
+#ifndef FEATURE_PAL
     if(pszDllName == NULL) pszDllName = strrchr(szOutputFileName,':');
+#endif
     if(pszDllName == NULL) pszDllName = szOutputFileName;
     Ldllname = (unsigned)strlen(pszDllName)+1;
 
@@ -1100,8 +1102,10 @@ HRESULT Assembler::CreatePEFile(__in __nullterminated WCHAR *pwzOutputFilename)
     else
     {
         WCHAR* pwc;
-        if ((pwc = wcsrchr(m_wzOutputFileName, '\\')) != NULL) pwc++;
+        if ((pwc = wcsrchr(m_wzOutputFileName, DIRECTORY_SEPARATOR_CHAR_A)) != NULL) pwc++;
+#ifndef FEATURE_PAL
         else if ((pwc = wcsrchr(m_wzOutputFileName, ':')) != NULL) pwc++;
+#endif
         else pwc = m_wzOutputFileName;
 
         wcsncpy_s(wzScopeName, MAX_SCOPE_LENGTH, pwc, _TRUNCATE);