Don't close the JIT func info file on shutdown (#18060)

kouvel · Koundinya Veluri · commit 9ea3d2ad5401 · 2018-08-27T11:52:51.000-07:00
Port of #18060 to 2.2 During shutdown there can be a race between closing/nulling `compJitFuncInfoFile` in `compShutdown` and a background thread trying to write to it after checking that it was not null.
diff --git a/src/jit/compiler.cpp b/src/jit/compiler.cpp
@@ -1437,14 +1437,6 @@ void Compiler::compShutdown()
     }
 #endif // FEATURE_JIT_METHOD_PERF
 
-#if FUNC_INFO_LOGGING
-    if (compJitFuncInfoFile != nullptr)
-    {
-        fclose(compJitFuncInfoFile);
-        compJitFuncInfoFile = nullptr;
-    }
-#endif // FUNC_INFO_LOGGING
-
 #if COUNT_RANGECHECKS
     if (optRangeChkAll > 0)
     {

Original file line number	Diff line number	Diff line change
`@@ -1437,14 +1437,6 @@ void Compiler::compShutdown()`
`1437`	`1437`	`}`
`1438`	`1438`	`#endif // FEATURE_JIT_METHOD_PERF`
`1439`	`1439`
`1440`		`-#if FUNC_INFO_LOGGING`
`1441`		`- if (compJitFuncInfoFile != nullptr)`
`1442`		`- {`
`1443`		`- fclose(compJitFuncInfoFile);`
`1444`		`- compJitFuncInfoFile = nullptr;`
`1445`		`- }`
`1446`		`-#endif // FUNC_INFO_LOGGING`
`1447`		`-`
`1448`	`1440`	`#if COUNT_RANGECHECKS`
`1449`	`1441`	`if (optRangeChkAll > 0)`
`1450`	`1442`	`{`