Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit a29cdf2

Browse files
mikednmikedn
committed
Remove misplaced call to genUnspillRegIfNeeded
1 parent 2f9e1c1 commit a29cdf2

File tree

4 files changed

+113
-2
lines changed

4 files changed

+113
-2
lines changed

‎src/jit/codegenxarch.cpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6019,8 +6019,6 @@ void CodeGen::genCallInstruction(GenTreePtr node)
60196019
regSet.rsSpillFPStack(call);
60206020
call->gtFlags |= GTF_SPILLED;
60216021
call->gtFlags &= ~GTF_SPILL;
6022-
6023-
genUnspillRegIfNeeded(call);
60246022
}
60256023
else
60266024
#endif // _TARGET_X86_

‎tests/src/JIT/Regression/JitBlue/GitHub_5047/GitHub_5047.cs‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
// Licensed to the .NET Foundation under one or more agreements.
2+
// The .NET Foundation licenses this file to you under the MIT license.
3+
// See the LICENSE file in the project root for more information.
4+
5+
using System;
6+
using System.Runtime.CompilerServices;
7+
8+
class Program
9+
{
10+
[MethodImpl(MethodImplOptions.NoInlining)]
11+
public static float Get42()
12+
{
13+
return 42;
14+
}
15+
16+
[MethodImpl(MethodImplOptions.NoInlining)]
17+
public static float Get43()
18+
{
19+
return 43;
20+
}
21+
22+
[MethodImpl(MethodImplOptions.NoInlining)]
23+
public static float Test()
24+
{
25+
float x = Get42();
26+
x *= Get43();
27+
return x;
28+
}
29+
30+
static int Main()
31+
{
32+
const int Pass = 100;
33+
const int Fail = -1;
34+
35+
if (Test() == 1806)
36+
{
37+
Console.WriteLine("Passed");
38+
return Pass;
39+
}
40+
else
41+
{
42+
Console.WriteLine("Failed");
43+
return Fail;
44+
}
45+
}
46+
}

‎tests/src/JIT/Regression/JitBlue/GitHub_5047/GitHub_5047.csproj‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
3+
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
4+
<PropertyGroup>
5+
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
6+
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
7+
<AssemblyName>$(MSBuildProjectName)</AssemblyName>
8+
<ProjectGuid>{95DFC527-4DC1-495E-97D7-E94EE1F7140D}</ProjectGuid>
9+
<OutputType>Exe</OutputType>
10+
<ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
11+
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
12+
<NuGetPackageImportStamp>7a9bfb7d</NuGetPackageImportStamp>
13+
</PropertyGroup>
14+
<!-- Default configurations to help VS understand the configurations -->
15+
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
16+
</PropertyGroup>
17+
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
18+
</PropertyGroup>
19+
<PropertyGroup>
20+
<DebugType></DebugType>
21+
<Optimize>True</Optimize>
22+
</PropertyGroup>
23+
<ItemGroup>
24+
<Compile Include="$(MSBuildProjectName).cs" />
25+
</ItemGroup>
26+
<ItemGroup>
27+
<None Include="$(JitPackagesConfigFileDirectory)minimal\project.json" />
28+
<None Include="app.config" />
29+
</ItemGroup>
30+
<ItemGroup>
31+
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
32+
</ItemGroup>
33+
<PropertyGroup>
34+
<ProjectJson>$(JitPackagesConfigFileDirectory)minimal\project.json</ProjectJson>
35+
<ProjectLockJson>$(JitPackagesConfigFileDirectory)minimal\project.lock.json</ProjectLockJson>
36+
</PropertyGroup>
37+
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
38+
<PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' ">
39+
</PropertyGroup>
40+
</Project>

‎tests/src/JIT/Regression/JitBlue/GitHub_5047/app.config‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<configuration>
3+
<runtime>
4+
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
5+
<dependentAssembly>
6+
<assemblyIdentity name="System.Runtime" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
7+
<bindingRedirect oldVersion="0.0.0.0-4.0.20.0" newVersion="4.0.20.0" />
8+
</dependentAssembly>
9+
<dependentAssembly>
10+
<assemblyIdentity name="System.Text.Encoding" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
11+
<bindingRedirect oldVersion="0.0.0.0-4.0.10.0" newVersion="4.0.10.0" />
12+
</dependentAssembly>
13+
<dependentAssembly>
14+
<assemblyIdentity name="System.Threading.Tasks" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
15+
<bindingRedirect oldVersion="0.0.0.0-4.0.10.0" newVersion="4.0.10.0" />
16+
</dependentAssembly>
17+
<dependentAssembly>
18+
<assemblyIdentity name="System.IO" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
19+
<bindingRedirect oldVersion="0.0.0.0-4.0.10.0" newVersion="4.0.10.0" />
20+
</dependentAssembly>
21+
<dependentAssembly>
22+
<assemblyIdentity name="System.Reflection" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
23+
<bindingRedirect oldVersion="0.0.0.0-4.0.10.0" newVersion="4.0.10.0" />
24+
</dependentAssembly>
25+
</assemblyBinding>
26+
</runtime>
27+
</configuration>

0 commit comments

Comments
 (0)