Add Span and ReadOnlySpan from CoreCLR

Signed-off-by: dotnet-bot <[email protected]>

Author: jkotas

src/mscorlib/shared/System/ReadOnlySpan.cs

@@ -20,6 +20,9 @@ public struct ReadOnlySpan<T>
         /// <summary>A byref or a native ptr.</summary>
         private readonly ByReference<T> _pointer;
         /// <summary>The number of elements this ReadOnlySpan contains.</summary>
+#if PROJECTN
+        [Bound]
+#endif
         private readonly int _length;
 
         /// <summary>
@@ -164,14 +167,21 @@ public ref T DangerousGetPinnableReference()
         /// </exception>
         public T this[int index]
         {
+#if PROJECTN
+            [BoundsChecking]
+            get
+            {
+                return Unsafe.Add(ref _pointer.Value, index);
+            }
+#else
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
             get
             {
                 if ((uint)index >= (uint)_length)
                     ThrowHelper.ThrowIndexOutOfRangeException();
-
                 return Unsafe.Add(ref _pointer.Value, index);
             }
+#endif
         }
 
         /// <summary>

src/mscorlib/shared/System/Span.NonGeneric.cs

@@ -165,12 +165,12 @@ internal static unsafe void ClearWithoutReferences(ref byte b, nuint byteLength)
             if (byteLength == 0)
                 return;
 
-#if AMD64
+#if AMD64 && CORECLR
             if (byteLength > 4096) goto PInvoke;
             Unsafe.InitBlockUnaligned(ref b, 0, (uint)byteLength);
             return;
-#else // AMD64
-            // TODO: Optimize this method on X86 machine
+#else
+            // TODO: Optimize other platforms to be on par with AMD64 CoreCLR
             // Note: It's important that this switch handles lengths at least up to 22.
             // See notes below near the main loop for why.
 
@@ -472,7 +472,7 @@ internal static unsafe void ClearWithoutReferences(ref byte b, nuint byteLength)
             }
 
             return;
-#endif // AMD64
+#endif
 
             PInvoke:
             RuntimeImports.RhZeroMemory(ref b, byteLength);

src/mscorlib/shared/System/Span.cs

@@ -27,6 +27,9 @@ public struct Span<T>
         /// <summary>A byref or a native ptr.</summary>
         private readonly ByReference<T> _pointer;
         /// <summary>The number of elements this Span contains.</summary>
+#if PROJECTN
+        [Bound]
+#endif
         private readonly int _length;
 
         /// <summary>
@@ -179,14 +182,21 @@ public ref T DangerousGetPinnableReference()
         /// </exception>
         public ref T this[int index]
         {
+#if PROJECTN
+            [BoundsChecking]
+            get
+            {
+                return ref Unsafe.Add(ref _pointer.Value, index);
+            }
+#else
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
             get
             {
                 if ((uint)index >= (uint)_length)
                     ThrowHelper.ThrowIndexOutOfRangeException();
-
                 return ref Unsafe.Add(ref _pointer.Value, index);
             }
+#endif
         }
 
         /// <summary>