Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit e13760c

Browse files
committed
When we have profile data we can have cross module references in our ZapSig's when building ReadyToRun images.
We should return a null TypeHandle to indicate failure so that we don't attempt to add generic types/methods that have cross module references. (i.e. MyList<System.Guid> )
1 parent 796cd8b commit e13760c

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/vm/siginfo.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1199,7 +1199,10 @@ TypeHandle SigPointer::GetTypeHandleThrowing(
11991199

12001200
PREFIX_ASSUME(pZapSigContext != NULL);
12011201
pModule = pZapSigContext->GetZapSigModule()->GetModuleFromIndex(ix);
1202-
if (pModule != NULL)
1202+
1203+
// For ReadyToRunCompilation we return a null TypeHandle when we reference a non-local module
1204+
//
1205+
if ((pModule != NULL) && pModule->IsInCurrentVersionBubble())
12031206
{
12041207
thRet = psig.GetTypeHandleThrowing(pModule,
12051208
pTypeContext,

0 commit comments

Comments
 (0)