Release/2.0.0 - Make coreclr exceptions serializable and add typeforwards (#14847)

* Make coreclr exceptions serializable and add typeforwards

* Make ContractException public in impl assembly to support corert typeforwarding (#14589)

* Make ContractException public in impl assembly to support corert typeforwarding

* Make EventSourcException serializable in corert scenarios (#14716)

* Use GenericEqualityComparer<string> instead of NonRandomizedStringEqualityComparer in serialization

* Wrapped Exception header rename in VM, change from 'share four exception types' and fix merge errors

* Update URLs to use for formatter job (#14785)

Author: ViktorHofer

src/mscorlib/shared/System/ApplicationException.cs

@@ -22,7 +22,8 @@ namespace System
     // to create their own exceptions do so by extending this class. 
     // ApplicationException extends but adds no new functionality to 
     // RecoverableException.
-    // 
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public class ApplicationException : Exception
     {
         // Creates a new ApplicationException with its message string set to
@@ -52,7 +53,6 @@ public ApplicationException(String message, Exception innerException)
 
         protected ApplicationException(SerializationInfo info, StreamingContext context) : base(info, context)
         {
-            throw new PlatformNotSupportedException();
         }
     }
 }

src/mscorlib/shared/System/ArgumentException.cs

@@ -19,7 +19,8 @@ namespace System
     // The ArgumentException is thrown when an argument does not meet 
     // the contract of the method.  Ideally it should give a meaningful error
     // message describing what was wrong and which parameter is incorrect.
-    // 
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public class ArgumentException : SystemException
     {
         private String _paramName;
@@ -64,12 +65,13 @@ public ArgumentException(String message, String paramName)
         protected ArgumentException(SerializationInfo info, StreamingContext context)
             : base(info, context)
         {
-            throw new PlatformNotSupportedException();
+            _paramName = info.GetString("ParamName");
         }
 
         public override void GetObjectData(SerializationInfo info, StreamingContext context)
         {
             base.GetObjectData(info, context);
+            info.AddValue("ParamName", _paramName, typeof(string));
         }
 
         public override String Message

src/mscorlib/shared/System/ArgumentNullException.cs

@@ -17,7 +17,8 @@ namespace System
 {
     // The ArgumentException is thrown when an argument 
     // is null when it shouldn't be.
-    // 
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public class ArgumentNullException : ArgumentException
     {
         // Creates a new ArgumentNullException with its message 
@@ -49,7 +50,6 @@ public ArgumentNullException(String paramName, String message)
 
         protected ArgumentNullException(SerializationInfo info, StreamingContext context) : base(info, context)
         {
-            throw new PlatformNotSupportedException();
         }
     }
 }

src/mscorlib/shared/System/ArgumentOutOfRangeException.cs

@@ -17,7 +17,9 @@
 namespace System
 {
     // The ArgumentOutOfRangeException is thrown when an argument 
-    // is outside the legal range for that argument.  
+    // is outside the legal range for that argument.
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public class ArgumentOutOfRangeException : ArgumentException
     {
         private Object _actualValue;
@@ -61,12 +63,13 @@ public ArgumentOutOfRangeException(String paramName, Object actualValue, String
         protected ArgumentOutOfRangeException(SerializationInfo info, StreamingContext context)
             : base(info, context)
         {
-            throw new PlatformNotSupportedException();
+            _actualValue = info.GetValue("ActualValue", typeof(object));
         }
 
         public override void GetObjectData(SerializationInfo info, StreamingContext context)
         {
             base.GetObjectData(info, context);
+            info.AddValue("ActualValue", _actualValue, typeof(object));
         }
 
         public override String Message

src/mscorlib/shared/System/ArithmeticException.cs

@@ -17,7 +17,8 @@ namespace System
 {
     // The ArithmeticException is thrown when overflow or underflow
     // occurs.
-    // 
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public class ArithmeticException : SystemException
     {
         // Creates a new ArithmeticException with its message string set to
@@ -47,7 +48,6 @@ public ArithmeticException(String message, Exception innerException)
 
         protected ArithmeticException(SerializationInfo info, StreamingContext context) : base(info, context)
         {
-            throw new PlatformNotSupportedException();
         }
     }
 }

src/mscorlib/shared/System/ArrayTypeMismatchException.cs

@@ -17,7 +17,8 @@ namespace System
 {
     // The ArrayMismatchException is thrown when an attempt to store
     // an object of the wrong type within an array occurs.
-    // 
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public class ArrayTypeMismatchException : SystemException
     {
         // Creates a new ArrayMismatchException with its message string set to
@@ -47,7 +48,6 @@ public ArrayTypeMismatchException(String message, Exception innerException)
 
         protected ArrayTypeMismatchException(SerializationInfo info, StreamingContext context) : base(info, context)
         {
-            throw new PlatformNotSupportedException();
         }
     }
 }

src/mscorlib/shared/System/BadImageFormatException.cs

@@ -17,6 +17,8 @@
 
 namespace System
 {
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public partial class BadImageFormatException : SystemException
     {
         private String _fileName;  // The name of the corrupt PE file.
@@ -56,12 +58,15 @@ public BadImageFormatException(String message, String fileName, Exception inner)
         protected BadImageFormatException(SerializationInfo info, StreamingContext context)
             : base(info, context)
         {
-            throw new PlatformNotSupportedException();
+            _fileName = info.GetString("BadImageFormat_FileName");
+            _fusionLog = info.GetString("BadImageFormat_FusionLog");
         }
 
         public override void GetObjectData(SerializationInfo info, StreamingContext context)
         {
             base.GetObjectData(info, context);
+            info.AddValue("BadImageFormat_FileName", _fileName, typeof(string));
+            info.AddValue("BadImageFormat_FusionLog", _fusionLog, typeof(string));
         }
 
         public override String Message

src/mscorlib/shared/System/Collections/Generic/KeyNotFoundException.cs

@@ -7,6 +7,8 @@
 
 namespace System.Collections.Generic
 {
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public class KeyNotFoundException : SystemException
     {
         public KeyNotFoundException()
@@ -29,7 +31,6 @@ public KeyNotFoundException(String message, Exception innerException)
 
         protected KeyNotFoundException(SerializationInfo info, StreamingContext context) : base(info, context)
         {
-            throw new PlatformNotSupportedException();
         }
     }
 }

src/mscorlib/shared/System/DataMisalignedException.cs

@@ -13,6 +13,8 @@
 
 namespace System
 {
+    [Serializable]
+    [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public sealed class DataMisalignedException : SystemException
     {
         public DataMisalignedException()
@@ -32,5 +34,9 @@ public DataMisalignedException(String message, Exception innerException)
         {
             HResult = __HResults.COR_E_DATAMISALIGNED;
         }
+
+        internal DataMisalignedException(SerializationInfo info, StreamingContext context) : base(info, context)
+        {
+        }
     }
 }

src/mscorlib/shared/System/Diagnostics/Tracing/EventSourceException.cs

@@ -18,9 +18,9 @@ namespace System.Diagnostics.Tracing
     /// <summary>
     /// Exception that is thrown when an error occurs during EventSource operation.
     /// </summary>
-#if !CORECLR && !ES_BUILD_PN && !ES_BUILD_PCL && !CORERT
+#if !ES_BUILD_PCL
     [Serializable]
-#endif // !CORECLR && !ES_BUILD_PN && !ES_BUILD_PCL && !CORERT
+#endif
     public class EventSourceException : Exception
     {
         /// <summary>