Add #if FEATURE_SERIALIZATION around non-functional [Serializable]

We're adding BinaryFormatter to corefx.  At present, ISerializable and friends are declared in corefx rather than being exported from System.Private.Corelib.  As a result, there are a fair number of types in mscorlib that try to customize their serialization, but because they're doing so using interfaces that aren't exported (and in some cases, aren't even currently compiled in), a formatter outside of Corelib sees a type as serializable but then tries to serialize it using the default rules and fails.

This commit ifdefs the [Serializable] attribute on types that try to customize their serialization.  If in the future we decide we want to expose ISerializable and friends from Corelib in order to enable the serialization of these types (which we'll likely want to), e.g Delegate, Exception, etc. we'll need to turn on FEATURE_SERIALIZATION for coreclr, and these will all come back automatically.

Author: stephentoub

src/mscorlib/src/System/AccessViolationException.cs

@@ -17,7 +17,9 @@ namespace System
     using System;
     using System.Runtime.Serialization;
     [System.Runtime.InteropServices.ComVisible(true)]
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     public class AccessViolationException : SystemException 
     {
         public AccessViolationException() 

src/mscorlib/src/System/AggregateException.cs

@@ -29,7 +29,9 @@ namespace System
     /// <see cref="AggregateException"/> is used to consolidate multiple failures into a single, throwable
     /// exception object.
     /// </remarks>
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     [DebuggerDisplay("Count = {InnerExceptionCount}")]
     public class AggregateException : Exception
     {

src/mscorlib/src/System/AppDomain.cs

@@ -111,15 +111,21 @@ public AssemblyLoadEventArgs(Assembly loadedAssembly)
     #if FEATURE_CORECLR
     [System.Security.SecurityCritical] // auto-generated
     #endif
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     [ComVisible(true)]
     public delegate Assembly ResolveEventHandler(Object sender, ResolveEventArgs args);
 
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     [ComVisible(true)]
     public delegate void AssemblyLoadEventHandler(Object sender, AssemblyLoadEventArgs args);
 
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     [ComVisible(true)]
     public delegate void AppDomainInitializer(string[] args);
 

src/mscorlib/src/System/AppDomainUnloadedException.cs

@@ -15,8 +15,10 @@ namespace System {
 
     using System.Runtime.Serialization;
 
-[System.Runtime.InteropServices.ComVisible(true)]
+    [System.Runtime.InteropServices.ComVisible(true)]
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     public class AppDomainUnloadedException : SystemException {
         public AppDomainUnloadedException() 
             : base(Environment.GetResourceString("Arg_AppDomainUnloadedException")) {

src/mscorlib/src/System/ApplicationException.cs

@@ -22,8 +22,10 @@ namespace System {
     // ApplicationException extends but adds no new functionality to 
     // RecoverableException.
     // 
-[System.Runtime.InteropServices.ComVisible(true)]
+    [System.Runtime.InteropServices.ComVisible(true)]
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     public class ApplicationException : Exception {
 
         // Creates a new ApplicationException with its message string set to

src/mscorlib/src/System/ArgumentException.cs

@@ -23,8 +23,10 @@ namespace System {
     // the contract of the method.  Ideally it should give a meaningful error
     // message describing what was wrong and which parameter is incorrect.
     // 
-[System.Runtime.InteropServices.ComVisible(true)]
+    [System.Runtime.InteropServices.ComVisible(true)]
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     public class ArgumentException : SystemException, ISerializable {
         private String m_paramName;
 

src/mscorlib/src/System/ArgumentNullException.cs

@@ -21,8 +21,11 @@ namespace System {
     // The ArgumentException is thrown when an argument 
     // is null when it shouldn't be.
     // 
-[System.Runtime.InteropServices.ComVisible(true)]
-    [Serializable] public class ArgumentNullException : ArgumentException
+    [System.Runtime.InteropServices.ComVisible(true)]
+#if FEATURE_SERIALIZATION
+    [Serializable]
+#endif
+    public class ArgumentNullException : ArgumentException
     {
         // Creates a new ArgumentNullException with its message 
         // string set to a default message explaining an argument was null.

src/mscorlib/src/System/ArgumentOutOfRangeException.cs

@@ -22,8 +22,10 @@ namespace System {
 
     // The ArgumentOutOfRangeException is thrown when an argument 
     // is outside the legal range for that argument.  
-[System.Runtime.InteropServices.ComVisible(true)]
+    [System.Runtime.InteropServices.ComVisible(true)]
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     public class ArgumentOutOfRangeException : ArgumentException, ISerializable {
 
         private static volatile String _rangeMessage;

src/mscorlib/src/System/ArithmeticException.cs

@@ -18,8 +18,11 @@ namespace System {
     // The ArithmeticException is thrown when overflow or underflow
     // occurs.
     // 
-[System.Runtime.InteropServices.ComVisible(true)]
-    [Serializable] public class ArithmeticException : SystemException
+    [System.Runtime.InteropServices.ComVisible(true)]
+#if FEATURE_SERIALIZATION
+    [Serializable]
+#endif
+    public class ArithmeticException : SystemException
     {        
         // Creates a new ArithmeticException with its message string set to
         // the empty string, its HRESULT set to COR_E_ARITHMETIC, 

src/mscorlib/src/System/ArrayTypeMismatchException.cs

@@ -18,8 +18,10 @@ namespace System {
     // The ArrayMismatchException is thrown when an attempt to store
     // an object of the wrong type within an array occurs.
     // 
-[System.Runtime.InteropServices.ComVisible(true)]
+    [System.Runtime.InteropServices.ComVisible(true)]
+#if FEATURE_SERIALIZATION
     [Serializable]
+#endif
     public class ArrayTypeMismatchException : SystemException {
 
         // Creates a new ArrayMismatchException with its message string set to