Fix issue #20076 createdump faults. (#20403)

Mike McLaughlin · web-flow · commit fd1893fa1a93 · 2018-10-25T10:55:05.000-07:00
Return E_FAIL instead of S_FALSE from ClrDataFrame::GetLocalSig(). Also issue dotnet/diagnostics#61
diff --git a/src/debug/daccess/stack.cpp b/src/debug/daccess/stack.cpp
@@ -1257,7 +1257,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig,
         {
             *sig = NULL;
             *count = 0;
-            return S_FALSE;
+            return E_FAIL;
         }
 
         COR_ILMETHOD_DECODER methodDecoder(m_methodDesc->GetILHeader());
@@ -1267,7 +1267,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig,
         {
             *sig = NULL;
             *count = 0;
-            return S_FALSE;
+            return E_FAIL;
         }
 
         ULONG tokenSigLen;

Original file line number	Diff line number	Diff line change
`@@ -1257,7 +1257,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig,`
`1257`	`1257`	`{`
`1258`	`1258`	`*sig = NULL;`
`1259`	`1259`	`*count = 0;`
`1260`		`- return S_FALSE;`
	`1260`	`+ return E_FAIL;`
`1261`	`1261`	`}`
`1262`	`1262`
`1263`	`1263`	`COR_ILMETHOD_DECODER methodDecoder(m_methodDesc->GetILHeader());`
`@@ -1267,7 +1267,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig,`
`1267`	`1267`	`{`
`1268`	`1268`	`*sig = NULL;`
`1269`	`1269`	`*count = 0;`
`1270`		`- return S_FALSE;`
	`1270`	`+ return E_FAIL;`
`1271`	`1271`	`}`
`1272`	`1272`
`1273`	`1273`	`ULONG tokenSigLen;`