Merge pull request #2176 from stephentoub/fix_linq_warnings

Fix System.Linq.Expressions.Tests build warnings and Console.WriteLine output

Author: stephentoub

src/System.Linq.Expressions/tests/Cast/IsNullableTests.cs

@@ -467,42 +467,7 @@ private static void VerifyGenericWithStructRestrictionIsObject<Ts>(Ts value) whe
                     Expression.TypeIs(Expression.Constant(value, typeof(Ts)), typeof(object)),
                     Enumerable.Empty<ParameterExpression>());
             Func<bool> f = e.Compile();
-
-            // compute the value with the expression tree
-            bool etResult = default(bool);
-            Exception etException = null;
-            try
-            {
-                etResult = f();
-            }
-            catch (Exception ex)
-            {
-                etException = ex;
-            }
-
-            // compute the value with regular IL
-            bool csResult = default(bool);
-            Exception csException = null;
-            try
-            {
-                csResult = value is object;
-            }
-            catch (Exception ex)
-            {
-                csException = ex;
-            }
-
-            // either both should have failed the same way or they should both produce the same result
-            if (etException != null || csException != null)
-            {
-                Assert.NotNull(etException);
-                Assert.NotNull(csException);
-                Assert.Equal(csException.GetType(), etException.GetType());
-            }
-            else
-            {
-                Assert.Equal(csResult, etResult);
-            }
+            Assert.True(f());
         }
 
         private static void VerifyGenericWithStructRestrictionIsValueType<Ts>(Ts value) where Ts : struct
@@ -512,42 +477,7 @@ private static void VerifyGenericWithStructRestrictionIsValueType<Ts>(Ts value)
                     Expression.TypeIs(Expression.Constant(value, typeof(Ts)), typeof(ValueType)),
                     Enumerable.Empty<ParameterExpression>());
             Func<bool> f = e.Compile();
-
-            // compute the value with the expression tree
-            bool etResult = default(bool);
-            Exception etException = null;
-            try
-            {
-                etResult = f();
-            }
-            catch (Exception ex)
-            {
-                etException = ex;
-            }
-
-            // compute the value with regular IL
-            bool csResult = default(bool);
-            Exception csException = null;
-            try
-            {
-                csResult = value is ValueType;
-            }
-            catch (Exception ex)
-            {
-                csException = ex;
-            }
-
-            // either both should have failed the same way or they should both produce the same result
-            if (etException != null || csException != null)
-            {
-                Assert.NotNull(etException);
-                Assert.NotNull(csException);
-                Assert.Equal(csException.GetType(), etException.GetType());
-            }
-            else
-            {
-                Assert.Equal(csResult, etResult);
-            }
+            Assert.True(f());
         }
 
         #endregion