Merge pull request #2080 from bartonjs/fix-x509tests-xlang

stephentoub · stephentoub · commit 1e1b6f7ee497 · 2015-06-17T13:05:03.000-04:00
Change TestByExtension_FriendlyName to look up the FriendlyName by OID.
diff --git a/src/System.Security.Cryptography.X509Certificates/tests/FindTests.cs b/src/System.Security.Cryptography.X509Certificates/tests/FindTests.cs
@@ -334,7 +334,9 @@ public static void TestBySerialNumber_NoMatch()
         [ActiveIssue(1993, PlatformID.AnyUnix)]
         public static void TestByExtension_FriendlyName()
         {
-            RunSingleMatchTest_MsCer(X509FindType.FindByExtension, "Enhanced Key Usage");
+            // Cannot just say "Enhanced Key Usage" here because the extension name is localized.
+            // Instead, look it up via the OID.
+            RunSingleMatchTest_MsCer(X509FindType.FindByExtension, new Oid("2.5.29.37").FriendlyName);
         }
 
         [Fact]

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,9 @@ public static void TestBySerialNumber_NoMatch()`
`334`	`334`	`[ActiveIssue(1993, PlatformID.AnyUnix)]`
`335`	`335`	`public static void TestByExtension_FriendlyName()`
`336`	`336`	`{`
`337`		`- RunSingleMatchTest_MsCer(X509FindType.FindByExtension, "Enhanced Key Usage");`
	`337`	`+ // Cannot just say "Enhanced Key Usage" here because the extension name is localized.`
	`338`	`+ // Instead, look it up via the OID.`
	`339`	`+ RunSingleMatchTest_MsCer(X509FindType.FindByExtension, new Oid("2.5.29.37").FriendlyName);`
`338`	`340`	`}`
`339`	`341`
`340`	`342`	`[Fact]`