Merge pull request #1939 from stephentoub/fix_process_asyncreading

stephentoub · stephentoub · commit 1f60b07a8323 · 2015-06-05T20:25:02.000-04:00
Fix bug in Process' AsyncStreamReader.BeginReadLine
diff --git a/src/System.Diagnostics.Process/src/System/Diagnostics/AsyncStreamReader.cs b/src/System.Diagnostics.Process/src/System/Diagnostics/AsyncStreamReader.cs
@@ -69,8 +69,7 @@ internal void BeginReadLine()
             if (_sb == null)
             {
                 _sb = new StringBuilder(DefaultBufferSize);
-                _readToBufferTask = Task.Factory.StartNew(s => ((AsyncStreamReader)s).ReadBuffer(),
-                    this, CancellationToken.None, TaskCreationOptions.DenyChildAttach, TaskScheduler.Default);
+                _readToBufferTask = Task.Run((Func<Task>)ReadBufferAsync);
             }
             else
             {
@@ -84,7 +83,7 @@ internal void CancelOperation()
         }
 
         // This is the async callback function. Only one thread could/should call this.
-        private async Task ReadBuffer()
+        private async Task ReadBufferAsync()
         {
             while (true)
             {

Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,7 @@ internal void BeginReadLine()`
`69`	`69`	`if (_sb == null)`
`70`	`70`	`{`
`71`	`71`	`_sb = new StringBuilder(DefaultBufferSize);`
`72`		`- _readToBufferTask = Task.Factory.StartNew(s => ((AsyncStreamReader)s).ReadBuffer(),`
`73`		`- this, CancellationToken.None, TaskCreationOptions.DenyChildAttach, TaskScheduler.Default);`
	`72`	`+ _readToBufferTask = Task.Run((Func<Task>)ReadBufferAsync);`
`74`	`73`	`}`
`75`	`74`	`else`
`76`	`75`	`{`
`@@ -84,7 +83,7 @@ internal void CancelOperation()`
`84`	`83`	`}`
`85`	`84`
`86`	`85`	`// This is the async callback function. Only one thread could/should call this.`
`87`		`- private async Task ReadBuffer()`
	`86`	`+ private async Task ReadBufferAsync()`
`88`	`87`	`{`
`89`	`88`	`while (true)`
`90`	`89`	`{`