Address pull request feedback and fix linux test run script to prevent copying test assemblies to the 'Overlay' directory.

Author: Sridhar-MS

run-test.sh

@@ -130,7 +130,7 @@ create_test_overlay()
 	echo "Corefx binaries not found at $CoreFxBins"
 	exit 1
   fi
-  find $CoreFxBins -name '*.dll' -exec cp '{}' "$OverlayDir" ";"
+  find $CoreFxBins -name '*.dll' -and -not -name "*Test*" -exec cp '{}' "$OverlayDir" ";"
 
   # Then the native CoreFX binaries
   #

src/System.Runtime.Loader/System.Runtime.Loader.sln

@@ -5,7 +5,7 @@ VisualStudioVersion = 14.0.23107.0
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "System.Runtime.Loader.Tests", "tests\System.Runtime.Loader.Tests.csproj", "{701CB3BC-00DC-435D-BDE4-C5FC29A708A7}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "System.Runtime.Loader.TestAssembly", "tests\System.Runtime.Loader.TestAssembly\System.Runtime.Loader.TestAssembly.csproj", "{396D6EBF-60BD-4DAF-8783-FB403E070A56}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "System.Runtime.Loader.Test.Assembly", "tests\System.Runtime.Loader.Test.Assembly\System.Runtime.Loader.Test.Assembly.csproj", "{396D6EBF-60BD-4DAF-8783-FB403E070A56}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution

src/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs

@@ -13,7 +13,7 @@ namespace System.Runtime.Loader.Tests
 {
     public class AssemblyLoadContextTest
     {
-        const string TESTASSEMBLY = "System.Runtime.Loader.TestAssembly";
+        private const string TestAssembly = "System.Runtime.Loader.Test.Assembly";
 
         [Fact]
         public static void GetAssemblyNameTest_ValidAssembly()
@@ -40,7 +40,7 @@ public static void GetAssemblyNameTest_NullParameter()
         [Fact]
         public static void LoadAssemblyByPath_ValidUserAssembly()
         {            
-            var asmName = new AssemblyName(TESTASSEMBLY);
+            var asmName = new AssemblyName(TestAssembly);
             var loadContext = new ResourceAssemblyLoadContext();
             loadContext.LoadBy = LoadBy.Path;
 
@@ -53,7 +53,7 @@ public static void LoadAssemblyByPath_ValidUserAssembly()
         [Fact]
         public static void LoadAssemblyByStream_ValidUserAssembly()
         {
-            var asmName = new AssemblyName(TESTASSEMBLY);
+            var asmName = new AssemblyName(TestAssembly);
             var loadContext = new ResourceAssemblyLoadContext();
             loadContext.LoadBy = LoadBy.Stream;
 
@@ -90,14 +90,14 @@ public static void LoadFromAssemblyName_ValidTrustedPlatformAssembly()
         [Fact]
         public static void GetLoadContextTest_ValidUserAssembly()
         {
-            var asmName = new AssemblyName(TESTASSEMBLY);
-            var loadContext = new ResourceAssemblyLoadContext();
-            loadContext.LoadBy = LoadBy.Stream;
+            var asmName = new AssemblyName(TestAssembly);
+            var expectedContext = new ResourceAssemblyLoadContext();
+            expectedContext.LoadBy = LoadBy.Stream;
 
-            var asm = loadContext.LoadFromAssemblyName(asmName);
-            var context = AssemblyLoadContext.GetLoadContext(asm);
+            var asm = expectedContext.LoadFromAssemblyName(asmName);
+            var actualContext = AssemblyLoadContext.GetLoadContext(asm);
 
-            Assert.True(context == loadContext);
+            Assert.Equal(expectedContext, actualContext);
         }
 
         [Fact]

src/System.Runtime.Loader/tests/System.Runtime.Loader.Test.Assembly.dll

@@ -6,8 +6,8 @@
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
-    <RootNamespace>System.Runtime.Loader.TestAssembly</RootNamespace>
-    <AssemblyName>System.Runtime.Loader.TestAssembly</AssemblyName>
+    <RootNamespace>System.Runtime.Loader.Test.Assembly</RootNamespace>
+    <AssemblyName>System.Runtime.Loader.Test.Assembly</AssemblyName>
     <ProjectGuid>{396D6EBF-60BD-4DAF-8783-FB403E070A56}</ProjectGuid>
   </PropertyGroup>
   <ItemGroup>

src/System.Runtime.Loader/tests/System.Runtime.Loader.TestAssembly/System.Runtime.Loader.TestAssembly.csproj renamed to src/System.Runtime.Loader/tests/System.Runtime.Loader.Test.Assembly/System.Runtime.Loader.Test.Assembly.csproj

@@ -1,5 +1,5 @@
 {
-  "locked": false,
+  "locked": true,
   "version": -9996,
   "targets": {
     "DNXCore,Version=v5.0": {

src/System.Runtime.Loader/tests/System.Runtime.Loader.TestAssembly/TestClass.cs renamed to src/System.Runtime.Loader/tests/System.Runtime.Loader.Test.Assembly/TestClass.cs

@@ -19,7 +19,7 @@
     <None Include="project.json" />
   </ItemGroup>
   <ItemGroup>
-    <EmbeddedResource Include="System.Runtime.Loader.TestAssembly.dll" />
+    <EmbeddedResource Include="System.Runtime.Loader.Test.Assembly.dll" />
   </ItemGroup>
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
   <PropertyGroup>