Merge pull request #2451 from Sridhar-MS/env-tests2

Add missing unit tests for System.Environment class

Author: Sridhar-MS

src/System.Runtime.Extensions/tests/System.Runtime.Extensions.Tests.csproj

@@ -45,7 +45,11 @@
     <Compile Include="System\Convert.ToUInt64.cs" />
     <Compile Include="System\Environment.ExpandEnvironmentVariables.cs" />
     <Compile Include="System\Environment.GetEnvironmentVariable.cs" />
+    <Compile Include="System\Environment.NewLine.cs" />
+    <Compile Include="System\Environment.ProcessorCount.cs" />
     <Compile Include="System\Environment.SetEnvironmentVariable.cs" />
+    <Compile Include="System\Environment.StackTrace.cs" />
+    <Compile Include="System\Environment.TickCount.cs" />
     <Compile Include="System\Math.cs" />
     <Compile Include="System\Progress.cs" />
     <Compile Include="System\Random.cs" />

src/System.Runtime.Extensions/tests/System/Environment.NewLine.cs

@@ -0,0 +1,26 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+using System.Runtime.InteropServices;
+using Xunit;
+
+namespace System.Runtime.Extensions.Tests
+{
+    public class EnvironmentNewLine
+    {
+        [PlatformSpecific(PlatformID.Windows)]
+        [Fact]
+        public void Windows_NewLineTest()
+        {
+            Assert.Equal("\r\n", Environment.NewLine);
+        }
+
+        [PlatformSpecific(PlatformID.AnyUnix)]
+        [Fact]
+        public void Unix_NewLineTest()
+        {
+            Assert.Equal("\n", Environment.NewLine);
+        }
+    }
+}

src/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs

@@ -0,0 +1,66 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+using System.Runtime.InteropServices;
+using Xunit;
+
+namespace System.Runtime.Extensions.Tests
+{
+    public class EnvironmentProcessorCount
+    {
+        [PlatformSpecific(PlatformID.Windows)]
+        [Fact]
+        public void Windows_ProcessorCountTest()
+        {
+            //arrange
+            SYSTEM_INFO sysInfo = new SYSTEM_INFO();
+            GetSystemInfo(ref sysInfo);
+            int expected = sysInfo.dwNumberOfProcessors;
+
+            //act
+            int actual = Environment.ProcessorCount;
+
+            //assert
+            Assert.True(actual > 0);
+            Assert.Equal(expected, actual);
+        }
+
+        [PlatformSpecific(PlatformID.AnyUnix)]
+        [Fact]
+        public void Unix_ProcessorCountTest()
+        {
+            //arrange
+            int _SC_NPROCESSORS_ONLN = Interop.IsOSX || Interop.IsFreeBSD ? 58 : 84;
+            int expected = (int)sysconf(_SC_NPROCESSORS_ONLN);
+
+            //act
+            int actual = Environment.ProcessorCount;
+
+            //assert
+            Assert.True(actual > 0);
+            Assert.Equal(expected, actual);
+        }
+
+        [DllImport("libc")]
+        private static extern long sysconf(int name);
+
+        [DllImport("api-ms-win-core-sysinfo-l1-1-0.dll", SetLastError = true)]
+        internal static extern void GetSystemInfo(ref SYSTEM_INFO lpSystemInfo);
+
+        [StructLayout(LayoutKind.Sequential)]
+        internal struct SYSTEM_INFO
+        {
+            internal int dwOemId; // This is a union of a DWORD and a struct containing 2 WORDs.
+            internal int dwPageSize;
+            internal IntPtr lpMinimumApplicationAddress;
+            internal IntPtr lpMaximumApplicationAddress;
+            internal IntPtr dwActiveProcessorMask;
+            internal int dwNumberOfProcessors;
+            internal int dwProcessorType;
+            internal int dwAllocationGranularity;
+            internal short wProcessorLevel;
+            internal short wProcessorRevision;
+        }
+    }
+}

src/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs

@@ -0,0 +1,70 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+using System.Collections.Generic;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+using System.Text;
+using System.Threading.Tasks;
+using Xunit;
+
+namespace System.Runtime.Extensions.Tests
+{
+    public class EnvironmentStackTrace
+    {
+        static string s_stackTrace;
+
+        [Fact]
+        public void StackTraceTest()
+        {
+            //arrange
+            List<string> knownFrames = new List<string>()
+            {
+                "System.Runtime.Extensions.Tests.EnvironmentStackTrace.StaticFrame(Object obj)",
+                "System.Runtime.Extensions.Tests.EnvironmentStackTrace.TestClass..ctor()",
+                "System.Runtime.Extensions.Tests.EnvironmentStackTrace.GenericFrame[T1,T2](T1 t1, T2 t2)",
+                "System.Runtime.Extensions.Tests.EnvironmentStackTrace.TestFrame()"
+            };
+
+            //act
+            Task.Run(() => TestFrame()).Wait();
+
+            //assert
+            int index = 0;
+            foreach(string frame in knownFrames)
+            {
+                index = s_stackTrace.IndexOf(frame, index);
+                Assert.True(index > -1);
+                index += frame.Length;
+            }
+        }
+
+        [MethodImpl(MethodImplOptions.NoInlining)]
+        public void TestFrame()
+        {
+            GenericFrame<DateTime, StringBuilder>(DateTime.Now, null);
+        }
+
+        [MethodImpl(MethodImplOptions.NoInlining)]
+        public void GenericFrame<T1, T2>(T1 t1, T2 t2)
+        {
+            var test = new TestClass();
+        }
+
+        [MethodImpl(MethodImplOptions.NoInlining)]
+        public static void StaticFrame(object obj)
+        {
+            s_stackTrace = Environment.StackTrace;
+        }
+
+        class TestClass
+        {
+            [MethodImpl(MethodImplOptions.NoInlining)]
+            public TestClass()
+            {
+                EnvironmentStackTrace.StaticFrame(null);
+            }
+        }
+    }
+}

src/System.Runtime.Extensions/tests/System/Environment.TickCount.cs

@@ -0,0 +1,20 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+using System.Runtime.InteropServices;
+using System.Threading;
+using Xunit;
+
+namespace System.Runtime.Extensions.Tests
+{
+    public class EnvironmentTickCount
+    {
+        [Fact]
+        public void TickCountTest()
+        {
+            int start = Environment.TickCount;
+            Assert.True(SpinWait.SpinUntil(() => Environment.TickCount > start, TimeSpan.FromSeconds(1)));
+        }
+    }
+}