Merge pull request #2899 from stephentoub/add_readasync_broken_test

Extend existing ReadFromPipeWithClosedPartner test for ReadAsync

Author: stephentoub

src/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.Read.cs

@@ -65,12 +65,12 @@ protected override ServerClientPair CreateServerClientPair()
 
         // InOut pipes can be written/read from either direction
         public override void WriteToReadOnlyPipe_Throws_NotSupportedException() { }
-        public override void ReadFromPipeWithClosedPartner_ReadNoBytes()
+        public override async Task ReadFromPipeWithClosedPartner_ReadNoBytes()
         {
             // On Unix a read from an InOut pipe with a closed partner will wait indefinitely
             // for bytes to be sent.
             if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-                base.ReadFromPipeWithClosedPartner_ReadNoBytes();
+                await base.ReadFromPipeWithClosedPartner_ReadNoBytes();
         }
     }
 }

src/System.IO.Pipes/tests/PipeTest.Read.cs

@@ -189,16 +189,21 @@ public void ReadOnDisposedReadablePipe_Throws_ObjectDisposedException()
         }
 
         [Fact]
-        public virtual void ReadFromPipeWithClosedPartner_ReadNoBytes()
+        public virtual async Task ReadFromPipeWithClosedPartner_ReadNoBytes()
         {
             using (ServerClientPair pair = CreateServerClientPair())
             {
                 pair.writeablePipe.Dispose();
                 byte[] buffer = new byte[] { 0, 0, 0, 0 };
 
-                int length = pair.readablePipe.Read(buffer, 0, buffer.Length);
-                Assert.Equal(0, length);
-                pair.readablePipe.ReadByte();
+                // The pipe won't be marked as Broken until the first read, so prime it
+                // to test both the case where it's not yet marked as "Broken" and then 
+                // where it is.
+                Assert.Equal(0, pair.readablePipe.Read(buffer, 0, buffer.Length));
+
+                Assert.Equal(0, pair.readablePipe.Read(buffer, 0, buffer.Length));
+                Assert.Equal(-1, pair.readablePipe.ReadByte());
+                Assert.Equal(0, await pair.readablePipe.ReadAsync(buffer, 0, buffer.Length));
             }
         }