Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 6d8a7b5

Browse files
committed
Merge pull request #2617 from mmitche/use-built-live-bits
Remove run-test native binaries workaround
2 parents 8613407 + 23e2f6f commit 6d8a7b5

File tree

1 file changed

+31
-19
lines changed

1 file changed

+31
-19
lines changed

run-test.sh

Lines changed: 31 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,23 +22,25 @@ usage()
2222
echo "usage: run-test [options]"
2323
echo
2424
echo "Input sources:"
25-
echo " --coreclr-bins <location> Location of root of the binaries directory"
26-
echo " containing the linux/mac coreclr build"
27-
echo " default: <repo_root>/bin/Product/<OS>.x64.<Configuration>"
28-
echo " --mscorlib-bins <location> Location of the root binaries directory containing"
29-
echo " the linux/mac mscorlib.dll"
30-
echo " default: <repo_root>/bin/Product/<OS>.x64.<Configuration>"
31-
echo " --corefx-tests <location> Location of the root binaries location containing"
32-
echo " the windows tests"
33-
echo " default: <repo_root>/bin/tests/Windows_NT.AnyCPU.<Configuration>"
34-
echo " --corefx-bins <location> Location of the linux/mac corefx binaries"
35-
echo " default: <repo_root>/bin/<OS>.AnyCPU.<Configuration>"
25+
echo " --coreclr-bins <location> Location of root of the binaries directory"
26+
echo " containing the linux/mac coreclr build"
27+
echo " default: <repo_root>/bin/Product/<OS>.x64.<Configuration>"
28+
echo " --mscorlib-bins <location> Location of the root binaries directory containing"
29+
echo " the linux/mac mscorlib.dll"
30+
echo " default: <repo_root>/bin/Product/<OS>.x64.<Configuration>"
31+
echo " --corefx-tests <location> Location of the root binaries location containing"
32+
echo " the windows tests"
33+
echo " default: <repo_root>/bin/tests/Windows_NT.AnyCPU.<Configuration>"
34+
echo " --corefx-bins <location> Location of the linux/mac corefx binaries"
35+
echo " default: <repo_root>/bin/<OS>.AnyCPU.<Configuration>"
36+
echo " --corefx-native-bins <location> Location of the linux/mac native corefx binaries"
37+
echo " default: <repo_root>/bin/<OS>.x64.<Configuration>"
3638
echo
3739
echo "Flavor/OS options:"
38-
echo " --configuration <config> Configuration to run (Debug/Release)"
39-
echo " default: Debug"
40-
echo " --os <os> OS to run (OSX/Linux)"
41-
echo " default: detect current OS"
40+
echo " --configuration <config> Configuration to run (Debug/Release)"
41+
echo " default: Debug"
42+
echo " --os <os> OS to run (OSX/Linux)"
43+
echo " default: detect current OS"
4244
echo
4345
echo "Execution options:"
4446
echo " --restrict-proj <regex> Run test projects that match regex"
@@ -133,10 +135,12 @@ create_test_overlay()
133135
find $CoreFxBins -name '*.dll' -and -not -name "*Test*" -exec cp '{}' "$OverlayDir" ";"
134136

135137
# Then the native CoreFX binaries
136-
#
137-
# TODO: Currently, CI does not build the native CoreFX components so build them here
138-
# in the test phase for now.
139-
( $ProjectRoot/src/Native/build.sh && cp $ProjectRoot/bin/$OS.x64.$Configuration/Native/* $OverlayDir ) || exit 1
138+
if [ ! -d $CoreFxNativeBins ]
139+
then
140+
echo "Corefx native binaries should be built (use build.sh in root)"
141+
exit 1
142+
fi
143+
cp $CoreFxNativeBins/* $OverlayDir
140144
}
141145

142146
copy_test_overlay()
@@ -220,6 +224,9 @@ do
220224
--corefx-bins)
221225
CoreFxBins=$2
222226
;;
227+
--corefx-native-bins)
228+
CoreFxNativeBins=$2
229+
;;
223230
--restrict-proj)
224231
TestSelection=$2
225232
;;
@@ -257,6 +264,11 @@ then
257264
CoreFxBins="$ProjectRoot/bin/$OS.AnyCPU.$Configuration"
258265
fi
259266

267+
if [ "$CoreFxNativeBins" == "" ]
268+
then
269+
CoreFxNativeBins="$ProjectRoot/bin/$OS.x64.$Configuration/Native"
270+
fi
271+
260272
# Check parameters up front for valid values:
261273

262274
if [ ! "$Configuration" == "Debug" ] && [ ! "$Configuration" == "Release" ]

0 commit comments

Comments
 (0)