Update the tests, fix typos in comments, and address review comments

Author: khdang

src/System.Runtime.Serialization.Xml/tests/SerializationTypes.cs

@@ -2109,3 +2109,13 @@ public class TypeWithXmlDocumentProperty
 {
     public XmlDocument Document;
 }
+
+public class TypeWithNonParameterlessConstructor
+{
+    public string StringProperty { get; set; }
+
+    public TypeWithNonParameterlessConstructor(string value)
+    {
+        StringProperty = value;
+    }
+}

src/System.Xml.XmlSerializer/src/System/Xml/Serialization/XmlSerializationWriterILGen.cs

@@ -2419,8 +2419,8 @@ internal void ILGenForCreateInstance(CodeGenerator ilg, Type type, Type cast, bo
             Label labelReturn = ilg.DefineLabel();
             Label labelEndIf = ilg.DefineLabel();
 
-            // Type typeInfo = type.GetTypeInfo();
-            LocalBuilder typeInfo = ilg.DeclareLocal(typeof(TypeInfo), "typeInfo");
+            // TypeInfo typeInfo = type.GetTypeInfo();
+            // typeInfo not declared explicitly
             ilg.Ldc(type);
             MethodInfo getTypeInfoMehod = typeof(IntrospectionExtensions).GetMethod(
                   "GetTypeInfo",
@@ -2429,11 +2429,10 @@ internal void ILGenForCreateInstance(CodeGenerator ilg, Type type, Type cast, bo
                   );
             ilg.Call(getTypeInfoMehod);
 
-            // IEnumerator e = typeInfo.DeclaredConstructors.GetEnumerator();
-            LocalBuilder enumerator = ilg.DeclareLocal(typeof(IEnumerator), "e");
+            // IEnumerator<ConstructorInfo> e = typeInfo.DeclaredConstructors.GetEnumerator();
+            LocalBuilder enumerator = ilg.DeclareLocal(typeof(IEnumerator<>).MakeGenericType(typeof(ConstructorInfo)), "e");
             MethodInfo getDeclaredConstructors = typeof(TypeInfo).GetMethod("get_DeclaredConstructors");
-            MethodInfo getEnumerator =
-                typeof(IEnumerable<>).MakeGenericType(typeof(ConstructorInfo)).GetMethod("GetEnumerator");
+            MethodInfo getEnumerator = typeof(IEnumerable<>).MakeGenericType(typeof(ConstructorInfo)).GetMethod("GetEnumerator");
             ilg.Call(getDeclaredConstructors);
             ilg.Call(getEnumerator);
             ilg.Stloc(enumerator);
@@ -2446,7 +2445,7 @@ internal void ILGenForCreateInstance(CodeGenerator ilg, Type type, Type cast, bo
             LocalBuilder constructorInfo = ilg.DeclareLocal(typeof(ConstructorInfo), "constructorInfo");
             ilg.Stloc(constructorInfo);
 
-            // if (!constructorInfo.IsStatic || constructorInfo.GetParameters.Length() == 0)
+            // if (!constructorInfo.IsStatic && constructorInfo.GetParameters.Length() == 0)
             ilg.Ldloc(constructorInfo);
             MethodInfo constructorIsStatic = typeof(ConstructorInfo).GetMethod("get_IsStatic");
             ilg.Call(constructorIsStatic);

src/System.Xml.XmlSerializer/tests/XmlSerializerTests.cs

@@ -8,6 +8,7 @@
 using System.Globalization;
 using System.IO;
 using System.Linq;
+using System.Reflection;
 using System.Xml;
 using System.Xml.Serialization;
 using System.Xml.Linq;
@@ -1114,14 +1115,21 @@ public static void Xml_TypeWithMismatchBetweenAttributeAndPropertyType()
     [Fact]
     public static void Xml_TypeWithNonPublicDefaultConstructor()
     {
-        System.Reflection.TypeInfo ti = System.Reflection.IntrospectionExtensions.GetTypeInfo(typeof(TypeWithNonPublicDefaultConstructor));
+        TypeInfo ti = IntrospectionExtensions.GetTypeInfo(typeof(TypeWithNonPublicDefaultConstructor));
         TypeWithNonPublicDefaultConstructor value = null;
         value = (TypeWithNonPublicDefaultConstructor)FindDefaultConstructor(ti).Invoke(null);
         Assert.StrictEqual("Mr. FooName", value.Name);
-        var actual = SerializeAndDeserialize<TypeWithNonPublicDefaultConstructor>(value, "<?xml version=\"1.0\"?>\r\n<TypeWithNonPublicDefaultConstructor xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\">\r\n  <Name>Mr. FooName</Name>\r\n</TypeWithNonPublicDefaultConstructor>");
+        var actual = SerializeAndDeserialize(value, "<?xml version=\"1.0\"?>" + Environment.NewLine + "<TypeWithNonPublicDefaultConstructor xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\">" + Environment.NewLine + "  <Name>Mr. FooName</Name>" + Environment.NewLine + "</TypeWithNonPublicDefaultConstructor>");
         Assert.StrictEqual(value.Name, actual.Name);
     }
 
+    [Fact]
+    public static void Xml_TypeWithNonParameterlessConstructor()
+    {
+        var obj = new TypeWithNonParameterlessConstructor("string value");
+        Assert.Throws<InvalidOperationException>(() => { SerializeAndDeserialize(obj, string.Empty); });
+    }
+
     private static T SerializeAndDeserialize<T>(T value, string baseline, Func<XmlSerializer> serializerFactory = null)
     {
         XmlSerializer serializer = new XmlSerializer(typeof(T));