Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 998c72c

Browse files
Priya91Priya91
committed
Merge pull request #2230 from Priya91/addlib
Rename test methods in System.Reflection.Emit.Tests to describe the test meaning.
2 parents 774cc01 + c65df32 commit 998c72c

File tree

177 files changed

+1341
-1468
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

177 files changed

+1341
-1468
lines changed

‎src/System.Reflection.Emit/tests/AssemblyBuilder/AssemblyBuilderDefineDynamicModule1.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ namespace System.Reflection.Emit.Tests
1414
public class AssemblyGetModuleTests
1515
{
1616
[Fact]
17-
public void PosTest1()
17+
public void TestCreateDynamicModule()
1818
{
1919
AssemblyName myAsmName = new AssemblyName("TestAssembly1");
2020
AssemblyBuilder myAssembly = AssemblyBuilder.DefineDynamicAssembly(myAsmName, AssemblyBuilderAccess.Run);
2121
ModuleBuilder mb = TestLibrary.Utilities.GetModuleBuilder(myAssembly, "Module1");
2222
}
2323

2424
[Fact]
25-
public void PosTest2()
25+
public void TestDefineDynamicModuleDefined()
2626
{
2727
AssemblyName myAsmName = new AssemblyName("TestAssembly2");
2828
AssemblyBuilder myAssembly = AssemblyBuilder.DefineDynamicAssembly(myAsmName, AssemblyBuilderAccess.Run);
@@ -35,31 +35,31 @@ public void PosTest2()
3535
}
3636

3737
[Fact]
38-
public void PosTest3()
38+
public void TestDefineDynamicModuleWithLargeName()
3939
{
4040
AssemblyName myAsmName = new AssemblyName("TestAssembly3");
4141
AssemblyBuilder myAssembly = AssemblyBuilder.DefineDynamicAssembly(myAsmName, AssemblyBuilderAccess.Run);
4242
ModuleBuilder mb = myAssembly.DefineDynamicModule(new string('a', 259));
4343
}
4444

4545
[Fact]
46-
public void NegTest1()
46+
public void TestThrowsExceptionOnEmptyName()
4747
{
4848
AssemblyName myAsmName = new AssemblyName("TestAssembly4");
4949
AssemblyBuilder myAssembly = AssemblyBuilder.DefineDynamicAssembly(myAsmName, AssemblyBuilderAccess.Run);
5050
Assert.Throws<ArgumentException>(() => { ModuleBuilder mb = myAssembly.DefineDynamicModule(""); });
5151
}
5252

5353
[Fact]
54-
public void NegTest2()
54+
public void TestThrowsExceptionOnNullName()
5555
{
5656
AssemblyName myAsmName = new AssemblyName("TestAssembly5");
5757
AssemblyBuilder myAssembly = AssemblyBuilder.DefineDynamicAssembly(myAsmName, AssemblyBuilderAccess.Run);
5858
Assert.Throws<ArgumentNullException>(() => { ModuleBuilder mb = myAssembly.DefineDynamicModule(null); });
5959
}
6060

6161
[Fact]
62-
public void NegTest3()
62+
public void TestThrowsExceptionOnNullTerminatedString()
6363
{
6464
AssemblyName myAsmName = new AssemblyName("TestAssembly6");
6565
AssemblyBuilder myAssembly = AssemblyBuilder.DefineDynamicAssembly(myAsmName, AssemblyBuilderAccess.Run);
@@ -69,7 +69,7 @@ public void NegTest3()
6969

7070

7171
[Fact]
72-
public void NegTest4()
72+
public void TestThrowsExceptionOnMultipleModuleDefinition()
7373
{
7474
AssemblyName myAsmName = new AssemblyName("TestAssembly7");
7575
AssemblyBuilder myAssembly = AssemblyBuilder.DefineDynamicAssembly(myAsmName, AssemblyBuilderAccess.Run);

‎src/System.Reflection.Emit/tests/AssemblyBuilder/AssemblyBuilderGetManifestResourceNames.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,11 @@ namespace System.Reflection.Emit.Tests
1111
{
1212
public class AssemblyBuilderGetManifestResourceNames
1313
{
14-
private const AssemblyBuilderAccess DefaultBuilderAccess = AssemblyBuilderAccess.Run;
15-
1614
[Fact]
17-
public void NegTest1()
15+
public void TestThrowsExceptionOnDynamicAssembly()
1816
{
1917
AssemblyName name = new AssemblyName("NegTest1Assembly");
20-
AssemblyBuilder builder = AssemblyBuilder.DefineDynamicAssembly(name, DefaultBuilderAccess);
18+
AssemblyBuilder builder = AssemblyBuilder.DefineDynamicAssembly(name, AssemblyBuilderAccess.Run);
2119
Assert.Throws<NotSupportedException>(() => { string[] myName = builder.GetManifestResourceNames(); });
2220
}
2321
}

‎src/System.Reflection.Emit/tests/AssemblyBuilder/AssemblyBuilderGetManifestResourceStream1.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,11 @@ namespace System.Reflection.Emit.Tests
1212
{
1313
public class AssemblyBuilderGetManifestResourceStream1
1414
{
15-
private const AssemblyBuilderAccess DefaultBuilderAccess = AssemblyBuilderAccess.Run;
16-
1715
[Fact]
18-
public void NegTest1()
16+
public void TestThrowsExceptionOnMethodNotSupported()
1917
{
2018
AssemblyName name = new AssemblyName("NegTest1Assembly");
21-
AssemblyBuilder builder = AssemblyBuilder.DefineDynamicAssembly(name, DefaultBuilderAccess);
19+
AssemblyBuilder builder = AssemblyBuilder.DefineDynamicAssembly(name, AssemblyBuilderAccess.Run);
2220
Assert.Throws<NotSupportedException>(() => { Stream myStream = builder.GetManifestResourceStream(""); });
2321
}
2422
}

‎src/System.Reflection.Emit/tests/AssemblyBuilder/AssemblyBuilderSetCustomAttribute.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public ABAttribute1(bool s)
2525
public class AssemblyBuilderSetCustomAttribute1
2626
{
2727
[Fact]
28-
public void PosTest1()
28+
public void TestSetCustomAttribute()
2929
{
3030
AssemblyBuilder asmBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("PT1"), AssemblyBuilderAccess.Run);
3131
ConstructorInfo c = typeof(ABAttribute1).GetConstructor(new Type[] { typeof(bool) });
@@ -35,14 +35,14 @@ public void PosTest1()
3535
}
3636

3737
[Fact]
38-
public void NegTest1()
38+
public void TestThrowsExceptionOnNullConstructorInfo()
3939
{
4040
AssemblyBuilder asmBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("NT1"), AssemblyBuilderAccess.Run);
4141
Assert.Throws<ArgumentNullException>(() => { asmBuilder.SetCustomAttribute(null, new byte[] { }); });
4242
}
4343

4444
[Fact]
45-
public void NegTest2()
45+
public void TestThrowsExceptionOnNullByteArray()
4646
{
4747
AssemblyBuilder asmBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("NT2"), AssemblyBuilderAccess.Run);
4848
ConstructorInfo dummyCtor = typeof(DateTime).GetConstructor(new Type[] { });

‎src/System.Reflection.Emit/tests/AssemblyBuilder/AssemblyBuilderSetCustomAttribute2.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public ABClassAttribute(int i)
3636
public class AssemblyBuilderSetCustomAttribute2
3737
{
3838
[Fact]
39-
public void PosTest1()
39+
public void TestSetCustomAttribute()
4040
{
4141
AssemblyName TestAssemblyName = new AssemblyName();
4242
TestAssemblyName.Name = "TestAssembly";
@@ -49,7 +49,7 @@ public void PosTest1()
4949
}
5050

5151
[Fact]
52-
public void NegTest1()
52+
public void TestThrowsExceptionOnNullCustomAttributeBuilder()
5353
{
5454
AssemblyName TestAssemblyName = new AssemblyName();
5555
TestAssemblyName.Name = "TestAssembly";

‎src/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderAttributes.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace System.Reflection.Emit.Tests
1111
public class ConstructorBuilderAttributes
1212
{
1313
[Fact]
14-
public void PosTest1()
14+
public void TestContainsAccessorAttribute()
1515
{
1616
AssemblyName an = new AssemblyName();
1717
an.Name = "DynamicRandomAssembly";
@@ -33,7 +33,7 @@ public void PosTest1()
3333
}
3434

3535
[Fact]
36-
public void PosTest2()
36+
public void TestContainsAccessorAttributeWithDifferentOverload()
3737
{
3838
AssemblyName an = new AssemblyName();
3939
an.Name = "DynamicRandomAssembly";

‎src/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderCallingConvention.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class ConstructorBuilderCallingConvention
1515
CallingConventions.VarArgs };
1616

1717
[Fact]
18-
public void PosTest1()
18+
public void TestCallingConventions()
1919
{
2020
AssemblyName an = new AssemblyName();
2121
an.Name = "DynamicRandomAssembly";
@@ -36,7 +36,7 @@ public void PosTest1()
3636
}
3737

3838
[Fact]
39-
public void PosTest2()
39+
public void TestCallingConventionWithDifferentOverload()
4040
{
4141
AssemblyName an = new AssemblyName();
4242
an.Name = "DynamicRandomAssembly";

‎src/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderDeclaringType.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace System.Reflection.Emit.Tests
1111
public class ConstructorBuilderDeclaringType
1212
{
1313
[Fact]
14-
public void PosTest1()
14+
public void TestDeclaringType()
1515
{
1616
AssemblyName an = new AssemblyName();
1717
an.Name = "DynamicRandomAssembly";
@@ -35,7 +35,7 @@ public void PosTest1()
3535
}
3636

3737
[Fact]
38-
public void PosTest2()
38+
public void TestDeclaringTypeWithDifferentOverload()
3939
{
4040
AssemblyName an = new AssemblyName();
4141
an.Name = "DynamicRandomAssembly";

‎src/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderDefineParameter.cs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ private ModuleBuilder TestModuleBuilder
4343
}
4444

4545
[Fact]
46-
public void PosTest1()
46+
public void TestValidDataWithMultipleParameters()
4747
{
4848
int i = 0;
4949
Type[] parameterTypes = new Type[]
@@ -73,7 +73,7 @@ public void PosTest1()
7373
}
7474

7575
[Fact]
76-
public void PosTest2()
76+
public void TestValidDataWithSingleParameter()
7777
{
7878
int i = 0;
7979

@@ -101,7 +101,7 @@ public void PosTest2()
101101
}
102102

103103
[Fact]
104-
public void PosTest3()
104+
public void TestValidDataWithNullName()
105105
{
106106
int i = 0;
107107

@@ -128,7 +128,7 @@ public void PosTest3()
128128
}
129129

130130
[Fact]
131-
public void PosTest4()
131+
public void TestValidDataWithMultipleParametersAndNullName()
132132
{
133133
int i = 0;
134134

@@ -157,15 +157,16 @@ public void PosTest4()
157157
}
158158

159159
[Fact]
160-
public void PosTest5()
160+
public void TestParameterWithZeroSequence()
161161
{
162162
CreateConstructorBuilder("PosTest5_Type1", new Type[] { }).DefineParameter(0, ParameterAttributes.None, "p");
163163
CreateConstructorBuilder("PosTest5_Type5", new Type[] { typeof(int) }).DefineParameter(0, ParameterAttributes.None, "p");
164164
}
165165

166166
[Fact]
167-
public void NegTest1()
167+
public void TestThrowsExceptionOnIncorrectPosition()
168168
{
169+
// ArgumentOutOfRangeException should be thrown when position is less than or equal to zero, or it is greater than the number of parameters of the constructor.
169170
NegTestCaseVerificationHelper(CreateConstructorBuilder("NegTest1_Type2", new Type[] { }),
170171
-1, ParameterAttributes.None, "p", typeof(ArgumentOutOfRangeException));
171172
NegTestCaseVerificationHelper(CreateConstructorBuilder("NegTest1_Type3", new Type[] { }),
@@ -175,7 +176,7 @@ public void NegTest1()
175176
}
176177

177178
[Fact]
178-
public void NegTest2()
179+
public void TestThrowsExceptionOnCreateTypeCalled()
179180
{
180181
ConstructorBuilder constructor = CreateConstructorBuilder("NegTest2_Type1", new Type[] { typeof(int) });
181182
constructor.GetILGenerator().Emit(OpCodes.Ret);

‎src/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderGetILGenerator1.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ private ModuleBuilder TestModuleBuilder
2828
}
2929

3030
[Fact]
31-
public void PosTest1()
31+
public void TestILGeneratorOnNonDefaultConstructor()
3232
{
3333
int i = 0;
3434
MethodAttributes[] attributes = new MethodAttributes[] {
@@ -64,16 +64,17 @@ public void PosTest1()
6464
}
6565

6666
[Fact]
67-
public void NegTest1()
67+
public void TestThrowsExceptionWithNoMethodyBody()
6868
{
69+
// InvalidOperationException should be thrown when The constructor has MethodAttributes or MethodImplAttributes flags indicating that it should not have a method body.
6970
Assert.Throws<InvalidOperationException>(() =>
7071
{
7172
ILGenerator generator = CreateConstructorBuilder("NegTest1_Type1", MethodAttributes.PinvokeImpl).GetILGenerator();
7273
});
7374
}
7475

7576
[Fact]
76-
public void NegTest2()
77+
public void TestThrowsExceptionOnDefaultConstructor()
7778
{
7879
TypeBuilder type = TestModuleBuilder.DefineType("NegTest2_Type1");
7980

0 commit comments

Comments
 (0)