Merge pull request #2831 from hackcraft/remove_redundant_check

VSadov · VSadov · commit bea1b9d6f5ca · 2015-08-16T06:37:14.000-07:00
Remove redundant check.
diff --git a/src/System.Linq.Expressions/src/System/Linq/Expressions/DefaultExpression.cs b/src/System.Linq.Expressions/src/System/Linq/Expressions/DefaultExpression.cs
@@ -58,7 +58,7 @@ public partial class Expression
         /// </returns>
         public static DefaultExpression Empty()
         {
-            return new DefaultExpression(typeof(void));
+            return new DefaultExpression(typeof(void)); // Create new object each time for different identity 
         }
 
         /// <summary>
@@ -71,10 +71,6 @@ public static DefaultExpression Empty()
         /// </returns>
         public static DefaultExpression Default(Type type)
         {
-            if (type == typeof(void))
-            {
-                return Empty();
-            }
             return new DefaultExpression(type);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public partial class Expression`
`58`	`58`	`/// </returns>`
`59`	`59`	`public static DefaultExpression Empty()`
`60`	`60`	`{`
`61`		`- return new DefaultExpression(typeof(void));`
	`61`	`+ return new DefaultExpression(typeof(void)); // Create new object each time for different identity`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`/// <summary>`
`@@ -71,10 +71,6 @@ public static DefaultExpression Empty()`
`71`	`71`	`/// </returns>`
`72`	`72`	`public static DefaultExpression Default(Type type)`
`73`	`73`	`{`
`74`		`- if (type == typeof(void))`
`75`		`- {`
`76`		`- return Empty();`
`77`		`- }`
`78`	`74`	`return new DefaultExpression(type);`
`79`	`75`	`}`
`80`	`76`	`}`