Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit eb986d1

Browse files
bartonjsbartonjs
committed
Add appropriate control attributes to X509Certificates tests.
The InteropTests tests are interoperating with Windows CAPI, so they should be [PlatformSpecific(PlatformID.Windows)]. The rest of the tests that are failing on Unix systems are due to issue 1993 (parts of X509Certificates being not yet implemented).
1 parent d243970 commit eb986d1

File tree

9 files changed

+88
-1
lines changed

9 files changed

+88
-1
lines changed

‎src/System.Security.Cryptography.X509Certificates/tests/CertTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ public static void X509Cert2Test()
8181
/// This test is for excerising X509Store and X509Chain code without actually installing any certificate
8282
/// </summary>
8383
[Fact]
84+
[ActiveIssue(1993, PlatformID.AnyUnix)]
8485
public static void X509CertStoreChain()
8586
{
8687
X509Store store = new X509Store("My", StoreLocation.LocalMachine);
@@ -104,6 +105,7 @@ public static void X509CertStoreChain()
104105
}
105106

106107
[Fact]
108+
[ActiveIssue(1993, PlatformID.AnyUnix)]
107109
public static void X509Cert2ToStringVerbose()
108110
{
109111
X509Store store = new X509Store("My", StoreLocation.CurrentUser);

‎src/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ public static void ImportNull()
154154
}
155155

156156
[Fact]
157+
[ActiveIssue(1993, PlatformID.AnyUnix)]
157158
public static void ImportPfx()
158159
{
159160
using (var pfxCer = new X509Certificate2(TestData.PfxData, TestData.PfxDataPassword))
@@ -175,6 +176,7 @@ public static void ImportPfx()
175176
}
176177

177178
[Fact]
179+
[ActiveIssue(1993, PlatformID.AnyUnix)]
178180
public static void ImportStoreSavedAsCerData()
179181
{
180182
using (var pfxCer = new X509Certificate2(TestData.PfxData, TestData.PfxDataPassword))
@@ -196,6 +198,7 @@ public static void ImportStoreSavedAsCerData()
196198
}
197199

198200
[Fact]
201+
[ActiveIssue(1993, PlatformID.AnyUnix)]
199202
public static void ImportStoreSavedAsSerializedCerData()
200203
{
201204
using (var pfxCer = new X509Certificate2(TestData.PfxData, TestData.PfxDataPassword))
@@ -217,6 +220,7 @@ public static void ImportStoreSavedAsSerializedCerData()
217220
}
218221

219222
[Fact]
223+
[ActiveIssue(1993, PlatformID.AnyUnix)]
220224
public static void ImportStoreSavedAsSerializedStoreData()
221225
{
222226
using (var msCer = new X509Certificate2(TestData.MsCertificate))
@@ -241,6 +245,7 @@ public static void ImportStoreSavedAsSerializedStoreData()
241245
}
242246

243247
[Fact]
248+
[ActiveIssue(1993, PlatformID.AnyUnix)]
244249
public static void ImportStoreSavedAsPfxData()
245250
{
246251
using (var msCer = new X509Certificate2(TestData.MsCertificate))
@@ -285,24 +290,28 @@ public static void ImportFromFileTests()
285290
}
286291

287292
[Fact]
293+
[ActiveIssue(1993, PlatformID.AnyUnix)]
288294
public static void ExportCert()
289295
{
290296
TestExportSingleCert(X509ContentType.Cert);
291297
}
292298

293299
[Fact]
300+
[ActiveIssue(1993, PlatformID.AnyUnix)]
294301
public static void ExportSerializedCert()
295302
{
296303
TestExportSingleCert(X509ContentType.SerializedCert);
297304
}
298305

299306
[Fact]
307+
[ActiveIssue(1993, PlatformID.AnyUnix)]
300308
public static void ExportSerializedStore()
301309
{
302310
TestExportStore(X509ContentType.SerializedStore);
303311
}
304312

305313
[Fact]
314+
[ActiveIssue(1993, PlatformID.AnyUnix)]
306315
public static void ExportPkcs7()
307316
{
308317
TestExportStore(X509ContentType.Pkcs7);

‎src/System.Security.Cryptography.X509Certificates/tests/ExportTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ namespace System.Security.Cryptography.X509Certificates.Tests
88
public static class ExportTests
99
{
1010
[Fact]
11+
[ActiveIssue(1993, PlatformID.AnyUnix)]
1112
public static void ExportAsCert()
1213
{
1314
using (X509Certificate2 c1 = new X509Certificate2(TestData.MsCertificate))
@@ -19,6 +20,7 @@ public static void ExportAsCert()
1920
}
2021

2122
[Fact]
23+
[ActiveIssue(1993, PlatformID.AnyUnix)]
2224
public static void ExportAsSerializedCert()
2325
{
2426
using (X509Certificate2 c1 = new X509Certificate2(TestData.MsCertificate))
@@ -36,6 +38,7 @@ public static void ExportAsSerializedCert()
3638
}
3739

3840
[Fact]
41+
[ActiveIssue(1993, PlatformID.AnyUnix)]
3942
public static void ExportAsPfx()
4043
{
4144
using (X509Certificate2 c1 = new X509Certificate2(TestData.MsCertificate))
@@ -52,6 +55,7 @@ public static void ExportAsPfx()
5255
}
5356

5457
[Fact]
58+
[ActiveIssue(1993, PlatformID.AnyUnix)]
5559
public static void ExportAsPfxWithPassword()
5660
{
5761
const string password = "Cotton";
@@ -70,6 +74,7 @@ public static void ExportAsPfxWithPassword()
7074
}
7175

7276
[Fact]
77+
[ActiveIssue(1993, PlatformID.AnyUnix)]
7378
public static void ExportAsPfxVerifyPassword()
7479
{
7580
const string password = "Cotton";

‎src/System.Security.Cryptography.X509Certificates/tests/ExtensionsTests.cs

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,60 +129,70 @@ public static void KeyUsageExtensionDefaultCtor()
129129
}
130130

131131
[Fact]
132+
[ActiveIssue(1993, PlatformID.AnyUnix)]
132133
public static void KeyUsageExtension_CrlSign()
133134
{
134135
TestKeyUsageExtension(X509KeyUsageFlags.CrlSign, false, "03020102".HexToByteArray());
135136
}
136137

137138
[Fact]
139+
[ActiveIssue(1993, PlatformID.AnyUnix)]
138140
public static void KeyUsageExtension_DataEncipherment()
139141
{
140142
TestKeyUsageExtension(X509KeyUsageFlags.DataEncipherment, false, "03020410".HexToByteArray());
141143
}
142144

143145
[Fact]
146+
[ActiveIssue(1993, PlatformID.AnyUnix)]
144147
public static void KeyUsageExtension_DecipherOnly()
145148
{
146149
TestKeyUsageExtension(X509KeyUsageFlags.DecipherOnly, false, "0303070080".HexToByteArray());
147150
}
148151

149152
[Fact]
153+
[ActiveIssue(1993, PlatformID.AnyUnix)]
150154
public static void KeyUsageExtension_DigitalSignature()
151155
{
152156
TestKeyUsageExtension(X509KeyUsageFlags.DigitalSignature, false, "03020780".HexToByteArray());
153157
}
154158

155159
[Fact]
160+
[ActiveIssue(1993, PlatformID.AnyUnix)]
156161
public static void KeyUsageExtension_EncipherOnly()
157162
{
158163
TestKeyUsageExtension(X509KeyUsageFlags.EncipherOnly, false, "03020001".HexToByteArray());
159164
}
160165

161166
[Fact]
167+
[ActiveIssue(1993, PlatformID.AnyUnix)]
162168
public static void KeyUsageExtension_KeyAgreement()
163169
{
164170
TestKeyUsageExtension(X509KeyUsageFlags.KeyAgreement, false, "03020308".HexToByteArray());
165171
}
166172

167173
[Fact]
174+
[ActiveIssue(1993, PlatformID.AnyUnix)]
168175
public static void KeyUsageExtension_KeyCertSign()
169176
{
170177
TestKeyUsageExtension(X509KeyUsageFlags.KeyCertSign, false, "03020204".HexToByteArray());
171178
}
172179

173180
[Fact]
181+
[ActiveIssue(1993, PlatformID.AnyUnix)]
174182
public static void KeyUsageExtension_KeyEncipherment()
175183
{
176184
TestKeyUsageExtension(X509KeyUsageFlags.KeyEncipherment, false, "03020520".HexToByteArray());
177185
}
178186

179187
[Fact]
188+
[ActiveIssue(1993, PlatformID.AnyUnix)]
180189
public static void KeyUsageExtension_None()
181190
{
182191
TestKeyUsageExtension(X509KeyUsageFlags.None, false, "030100".HexToByteArray());
183192
}
184193

185194
[Fact]
195+
[ActiveIssue(1993, PlatformID.AnyUnix)]
186196
public static void KeyUsageExtension_NonRepudiation()
187197
{
188198
TestKeyUsageExtension(X509KeyUsageFlags.NonRepudiation, false, "03020640".HexToByteArray());
@@ -204,30 +214,35 @@ public static void BasicConstraintsExtensionDefault()
204214
}
205215

206216
[Fact]
217+
[ActiveIssue(1993, PlatformID.AnyUnix)]
207218
public static void BasicConstraintsExtension_Leaf()
208219
{
209220
TestBasicConstraintsExtension(false, false, 0, false, "3000".HexToByteArray());
210221
}
211222

212223
[Fact]
224+
[ActiveIssue(1993, PlatformID.AnyUnix)]
213225
public static void BasicConstraintsExtension_CA_NoLength()
214226
{
215227
TestBasicConstraintsExtension(true, false, 0, false, "30030101ff".HexToByteArray());
216228
}
217229

218230
[Fact]
231+
[ActiveIssue(1993, PlatformID.AnyUnix)]
219232
public static void BasicConstraintsExtension_Leaf_Length0()
220233
{
221234
TestBasicConstraintsExtension(false, true, 0, false, "3003020100".HexToByteArray());
222235
}
223236

224237
[Fact]
238+
[ActiveIssue(1993, PlatformID.AnyUnix)]
225239
public static void BasicConstraintsExtension_LeafLongPath()
226240
{
227241
TestBasicConstraintsExtension(false, true, 7654321, false, "3005020374cbb1".HexToByteArray());
228242
}
229243

230244
[Fact]
245+
[ActiveIssue(1993, PlatformID.AnyUnix)]
231246
public static void BasicConstraintsExtension_CA_559()
232247
{
233248
TestBasicConstraintsExtension(true, true, 559, false, "30070101ff0202022f".HexToByteArray());
@@ -248,13 +263,15 @@ public static void EnhancedKeyUsageExtensionDefault()
248263
}
249264

250265
[Fact]
266+
[ActiveIssue(1993, PlatformID.AnyUnix)]
251267
public static void EnhancedKeyUsageExtension_Empty()
252268
{
253269
OidCollection usages = new OidCollection();
254270
TestEnhancedKeyUsageExtension(usages, false, "3000".HexToByteArray());
255271
}
256272

257273
[Fact]
274+
[ActiveIssue(1993, PlatformID.AnyUnix)]
258275
public static void EnhancedKeyUsageExtension_2Oids()
259276
{
260277
Oid oid1 = Oid.FromOidValue("1.3.6.1.5.5.7.3.1", OidGroup.EnhancedKeyUsage);
@@ -282,6 +299,7 @@ public static void SubjectKeyIdentifierExtensionDefault()
282299
}
283300

284301
[Fact]
302+
[ActiveIssue(1993, PlatformID.AnyUnix)]
285303
public static void SubjectKeyIdentifierExtension_Bytes()
286304
{
287305
byte[] sk = { 1, 2, 3, 4 };
@@ -296,6 +314,7 @@ public static void SubjectKeyIdentifierExtension_Bytes()
296314
}
297315

298316
[Fact]
317+
[ActiveIssue(1993, PlatformID.AnyUnix)]
299318
public static void SubjectKeyIdentifierExtension_String()
300319
{
301320
string sk = "01ABcd";
@@ -310,6 +329,7 @@ public static void SubjectKeyIdentifierExtension_String()
310329
}
311330

312331
[Fact]
332+
[ActiveIssue(1993, PlatformID.AnyUnix)]
313333
public static void SubjectKeyIdentifierExtension_PublicKey()
314334
{
315335
PublicKey pk = new X509Certificate2(TestData.MsCertificate).PublicKey;
@@ -324,6 +344,7 @@ public static void SubjectKeyIdentifierExtension_PublicKey()
324344
}
325345

326346
[Fact]
347+
[ActiveIssue(1993, PlatformID.AnyUnix)]
327348
public static void SubjectKeyIdentifierExtension_PublicKeySha1()
328349
{
329350
TestSubjectKeyIdentifierExtension(
@@ -335,6 +356,7 @@ public static void SubjectKeyIdentifierExtension_PublicKeySha1()
335356
}
336357

337358
[Fact]
359+
[ActiveIssue(1993, PlatformID.AnyUnix)]
338360
public static void SubjectKeyIdentifierExtension_PublicKeyShortSha1()
339361
{
340362
TestSubjectKeyIdentifierExtension(
@@ -346,6 +368,7 @@ public static void SubjectKeyIdentifierExtension_PublicKeyShortSha1()
346368
}
347369

348370
[Fact]
371+
[ActiveIssue(1993, PlatformID.AnyUnix)]
349372
public static void SubjectKeyIdentifierExtension_PublicKeyCapiSha1()
350373
{
351374
TestSubjectKeyIdentifierExtension(

0 commit comments

Comments
 (0)