System.Security: String.Compare -> String.Equals

Per the Best Practices for Using Strings at
http://msdn.microsoft.com/en-us/library/dd465121(v=vs.110).aspx

* Use an overload of the String.Equals method to test whether two
strings are equal.
* Use the String.Compare and String.CompareTo methods to sort strings,
not to check for equality.

Author: justinvp

src/System.Security.Cryptography.RSA/src/System/Security/Cryptography/CapiHelper.cs

@@ -37,7 +37,7 @@ public static string UpgradeDSS(int dwProvType, string wszProvider)
         {
             string wszUpgrade = null;
             SafeProvHandle safeProvHandle = SafeProvHandle.InvalidHandle;
-            if (string.Compare(wszProvider, MS_DEF_DSS_DH_PROV) == 0)
+            if (string.Equals(wszProvider, MS_DEF_DSS_DH_PROV, StringComparison.Ordinal))
             {
                 // If this is the base DSS/DH provider, see if we can use the enhanced provider instead.
                 if (S_OK == AcquireCryptContext(ref safeProvHandle, null, MS_ENH_DSS_DH_PROV, dwProvType,
@@ -64,8 +64,8 @@ public static string UpgradeDSS(int dwProvType, string wszProvider)
         /// <returns>Returns upgrade CSP name</returns>
         public static string UpgradeRSA(int dwProvType, string wszProvider)
         {
-            bool requestedEnhanced = (string.Compare(wszProvider, MS_ENHANCED_PROV) == 0);
-            bool requestedBase = (string.Compare(wszProvider, MS_DEF_PROV) == 0);
+            bool requestedEnhanced = string.Equals(wszProvider, MS_ENHANCED_PROV, StringComparison.Ordinal);
+            bool requestedBase = string.Equals(wszProvider, MS_DEF_PROV, StringComparison.Ordinal);
             string wszUpgrade = null;
             SafeProvHandle safeProvHandle = SafeProvHandle.InvalidHandle;
             if (requestedBase || requestedEnhanced)

src/System.Security.Cryptography.X509Certificates/src/System/Security/Cryptography/X509Certificates/X509ExtensionCollection.cs

@@ -55,7 +55,7 @@ public X509Extension this[String oid]
                 String oidValue = new Oid(oid).Value;
                 foreach (X509Extension extension in _list)
                 {
-                    if (String.Compare(extension.Oid.Value, oidValue, StringComparison.OrdinalIgnoreCase) == 0)
+                    if (String.Equals(extension.Oid.Value, oidValue, StringComparison.OrdinalIgnoreCase))
                         return extension;
                 }
                 return null;