Merge pull request #2758 from rajansingh10/myfeature

Enabling cookie container in HTTP xplat

Author: stephentoub

src/Common/src/Interop/Unix/libcurl/Interop.libcurl_types.cs

@@ -38,6 +38,7 @@ internal static partial class CURLoption
             internal const int CURLOPT_PROXY = CurlOptionObjectPointBase + 4;
             internal const int CURLOPT_PROXYUSERPWD = CurlOptionObjectPointBase + 6;
             internal const int CURLOPT_READDATA = CurlOptionObjectPointBase + 9;
+            internal const int CURLOPT_COOKIE = CurlOptionObjectPointBase + 22;
             internal const int CURLOPT_HTTPHEADER = CurlOptionObjectPointBase + 23;
             internal const int CURLOPT_HEADERDATA = CurlOptionObjectPointBase + 29;
             internal const int CURLOPT_ACCEPTENCODING = CurlOptionObjectPointBase + 102;

src/System.Net.Http/src/System/Net/Http/Unix/CurlHandler.cs

@@ -23,7 +23,7 @@
 using size_t = System.IntPtr;
 
 namespace System.Net.Http
-{
+{  
     internal partial class CurlHandler : HttpMessageHandler
     {
         #region Constants
@@ -40,7 +40,7 @@ internal partial class CurlHandler : HttpMessageHandler
         #endregion
 
         #region Fields
-
+  
         private volatile bool _anyOperationStarted;
         private volatile bool _disposed;
         private bool _automaticRedirection = true;
@@ -50,8 +50,10 @@ internal partial class CurlHandler : HttpMessageHandler
         private DecompressionMethods _automaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate;
         private SafeCurlMultiHandle _multiHandle;
         private GCHandle _multiHandlePtr = new GCHandle();
+        private CookieContainer _cookieContainer = null;
+        private bool _useCookie = false;
 
-        #endregion
+        #endregion        
 
         static CurlHandler()
         {
@@ -178,6 +180,34 @@ internal DecompressionMethods AutomaticDecompression
             }
         }
 
+        internal bool UseCookie
+        {
+            get
+            {
+                return _useCookie;
+            }
+
+            set
+            {               
+                CheckDisposedOrStarted();
+                _useCookie = value;
+            }
+        }
+
+        internal CookieContainer CookieContainer
+        {
+            get
+            {
+                return _cookieContainer;
+            }
+
+            set
+            {
+                CheckDisposedOrStarted();
+                _cookieContainer = value;
+            }
+        }
+
         #endregion
 
         protected override void Dispose(bool disposing)
@@ -370,6 +400,8 @@ private SafeCurlHandle CreateRequestHandle(RequestCompletionSource state, GCHand
 
             SetProxyOptions(requestHandle, state.RequestMessage.RequestUri);
 
+            SetCookieOption(requestHandle, state.RequestMessage.RequestUri);
+
             state.RequestHeaderHandle = SetRequestHeaders(requestHandle, state.RequestMessage);
 
             // TODO: Handle other options
@@ -441,6 +473,25 @@ private void SetProxyOptions(SafeCurlHandle requestHandle, Uri requestUri)
             }
         }
 
+        private void SetCookieOption(SafeCurlHandle requestHandle, Uri requestUri)
+        {
+            if (!_useCookie)
+            {
+                return;
+            }
+            else if (_cookieContainer == null)
+            {
+                throw new InvalidOperationException(SR.net_http_invalid_cookiecontainer);
+            }
+
+            string cookieValues = _cookieContainer.GetCookieHeader(requestUri);                    
+
+            if (cookieValues != null)
+            {
+                SetCurlOption(requestHandle, CURLoption.CURLOPT_COOKIE, cookieValues);
+            }           
+        }
+
         private NetworkCredential GetCredentials(ICredentials proxyCredentials, Uri requestUri)
         {
             if (proxyCredentials == null)

src/System.Net.Http/src/System/Net/Http/Unix/HttpClientHandler.Unix.cs

@@ -27,14 +27,28 @@ public virtual bool SupportsRedirectConfiguration
 
         public bool UseCookies
         {
-            get { throw NotImplemented.ByDesignWithMessage("HTTP stack not implemented"); }
-            set { throw NotImplemented.ByDesignWithMessage("HTTP stack not implemented"); }
+            get
+            {
+                return _curlHandler.UseCookie;
+            }
+
+            set
+            {
+                _curlHandler.UseCookie = value;
+            }          
         }
 
         public CookieContainer CookieContainer
         {
-            get { throw NotImplemented.ByDesignWithMessage("HTTP stack not implemented"); }
-            set { throw NotImplemented.ByDesignWithMessage("HTTP stack not implemented"); }
+            get
+            {
+                return _curlHandler.CookieContainer;
+            }
+
+            set
+            {
+                _curlHandler.CookieContainer = value;
+            }
         }
 
         public ClientCertificateOption ClientCertificateOptions