Allow specifying StringComparison when property patterns contain strings.

[pregress]

Would be great if we could do property patterns and specify the StringComparison enum to handle culture/casing.

The current pattern matching is great, but If you want to match string and ignore case there is no way to achieve this.
Hence you fall back on the string.Equals.

example is { foo: "bar" with StringComparison.OrdinalIgnoreCase   }

Or a different syntax.

Related:
#5551
#4117

[RikkiGibson]

#8612 includes the example definition:
static bool Insensitive(this string s, string str) => s.Equals(str, StringComparison.InvariantCultureIgnoreCase);
with usage like: foo is Insensitive("bar")

[jnm2]

Interesting. This seems like a vote in favor of with being an intuitive keyword for specifying a comparer for a collection-based operation.

Cc @CyrusNajmabadi

[HaloFour]

e.g.?

var dict1 = ["a": 1, "b": 2] with StringComparison.OrdinalIgnoreCase;
var dict2 = ["a": 1, "b": 2] with (comparer: StringComparison.OrdinalIgnoreCase);
var dict3 = ["a": 1, "b": 2] with (2, StringComparison.OrdinalIgnoreCase); // ew
var dict4 = ["a": 1, "b": 2] with (capacity: 2, comparer: StringComparison.OrdinalIgnoreCase);

[jnm2]

I was thinking more generally the keyword itself. The tentative syntax is still [with(args), items]. In terms of your example, full syntax symmetry with pattern matching would introduce the question, how far up the syntax tree from an individual string value would you be able to put the with?

[GabeSchaffer]

var dict4 = ["a": 1, "b": 2] with (capacity: 2, comparer: StringComparison.OrdinalIgnoreCase);

Due to C#'s left-to-right evaluation order, the contents of the collection would have to be evaluated and stored somewhere before the capacity is known. I think that makes the postfix with a non-starter -- which is a shame, because visually I think it's fairly attractive.