Split the workflow that runs our tools from the workflow that writes the checks. #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IEvangelist
reviewed
Jan 24, 2025
Co-authored-by: David Pine <[email protected]>
IEvangelist
reviewed
Jan 24, 2025
Co-authored-by: David Pine <[email protected]>
|
Closing in favor of #1269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the initial code to create a check run using a chained workflow.
This improves security. Our automated tools can run in the
pull_requestcontext, which means it runs in the context of a fork, rather than the context of the base repository.That means our actions can't create status checks. That REST API requires write access to the base repository.
So, run the tools and build the text output for the status check.
That workflow's completion triggers a workflow that writes the status check.