fix: Update GetOperationIdAsync and GetOperationDescriptionAsync methods to use prompt file parameter and improve method visibility

Author: ricwilson

DevProxy.Plugins/Generation/OpenApiSpecGeneratorPlugin.cs

@@ -235,25 +235,30 @@ protected virtual Task ProcessOpenApiDocumentAsync(OpenApiDocument openApiDoc)
         return Task.CompletedTask;
     }
 
-    private async Task<string> GetOperationIdAsync(string method, string serverUrl, string parametrizedPath)
+    protected virtual async Task<string> GetOperationIdAsync(string method, string serverUrl, string parametrizedPath, string promptyFile = "api_operation_id")
     {
+        ArgumentException.ThrowIfNullOrEmpty(method);
+        ArgumentException.ThrowIfNullOrEmpty(parametrizedPath);
+
         ILanguageModelCompletionResponse? id = null;
         if (await languageModelClient.IsEnabledAsync())
         {
-            id = await languageModelClient.GenerateChatCompletionAsync("api_operation_id", new()
+            id = await languageModelClient.GenerateChatCompletionAsync(promptyFile, new()
             {
                 { "request", $"{method.ToUpperInvariant()} {serverUrl}{parametrizedPath}" }
             });
         }
         return id?.Response ?? $"{method}{parametrizedPath.Replace('/', '.')}";
     }
 
-    private async Task<string> GetOperationDescriptionAsync(string method, string serverUrl, string parametrizedPath)
+    protected virtual async Task<string> GetOperationDescriptionAsync(string method, string serverUrl, string parametrizedPath, string promptyFile = "api_operation_description")
     {
+        ArgumentException.ThrowIfNullOrEmpty(method);
+
         ILanguageModelCompletionResponse? description = null;
         if (await languageModelClient.IsEnabledAsync())
         {
-            description = await languageModelClient.GenerateChatCompletionAsync("api_operation_description", new()
+            description = await languageModelClient.GenerateChatCompletionAsync(promptyFile, new()
             {
                 { "request", $"{method.ToUpperInvariant()} {serverUrl}{parametrizedPath}" }
             });

DevProxy.Plugins/Generation/PowerPlatformOpenApiSpecGeneratorPlugin.cs

@@ -237,55 +237,41 @@ private void RemoveResponseHeadersIfDisabled(OpenApiPathItem pathItem)
     /// <param name="method">The HTTP method.</param>
     /// <param name="serverUrl">The server URL.</param>
     /// <param name="parametrizedPath">The parametrized path.</param>
-    /// <returns>The generated operationId.</returns>
-    private async Task<string> GetOperationIdAsync(string method, string serverUrl, string parametrizedPath)
+    /// <param name="promptyFile">The prompt file to use for LLM generation.</param>
+    /// <returns>The generated operation id.</returns>
+    protected override Task<string> GetOperationIdAsync(string method, string serverUrl, string parametrizedPath, string promptyFile = "powerplatform_api_operation_id")
     {
-        ILanguageModelCompletionResponse? id = null;
-        if (await _languageModelClient.IsEnabledAsync())
-        {
-            id = await _languageModelClient.GenerateChatCompletionAsync("powerplatform_api_operation_id", new()
-            {
-                { "request", $"{method.ToUpper(CultureInfo.InvariantCulture)} {serverUrl}{parametrizedPath}" }
-            });
-        }
-        return id?.Response?.Trim() ?? $"{method}{parametrizedPath.Replace('/', '.')}";
+        return base.GetOperationIdAsync(method, serverUrl, parametrizedPath, promptyFile);
     }
 
     /// <summary>
-    /// Generates a summary for an OpenAPI operation using LLM or fallback logic.
+    /// Generates an operationId for an OpenAPI operation using LLM or fallback logic.
     /// </summary>
     /// <param name="method">The HTTP method.</param>
     /// <param name="serverUrl">The server URL.</param>
     /// <param name="parametrizedPath">The parametrized path.</param>
-    /// <returns>The generated summary.</returns>
-    private async Task<string> GetOperationSummaryAsync(string method, string serverUrl, string parametrizedPath)
+    /// <param name="promptyFile">The prompt file to use for LLM generation.</param>
+    /// <returns>The generated operation description.</returns>
+    protected override Task<string> GetOperationDescriptionAsync(string method, string serverUrl, string parametrizedPath, string promptyFile = "powerplatform_api_operation_description")
     {
-        ILanguageModelCompletionResponse? description = null;
-        if (await _languageModelClient.IsEnabledAsync())
-        {
-            description = await _languageModelClient.GenerateChatCompletionAsync("powerplatform_api_operation_summary", new()
-            {
-                { "request", @$"{method.ToUpper(CultureInfo.InvariantCulture)} {serverUrl}{parametrizedPath}" }
-            });
-        }
-        return description?.Response?.Trim() ?? $"{method} {parametrizedPath}";
+        return base.GetOperationDescriptionAsync(method, serverUrl, parametrizedPath, promptyFile);
     }
 
     /// <summary>
-    /// Generates a description for an OpenAPI operation using LLM or fallback logic.
+    /// Generates a summary for an OpenAPI operation using LLM or fallback logic.
     /// </summary>
     /// <param name="method">The HTTP method.</param>
     /// <param name="serverUrl">The server URL.</param>
     /// <param name="parametrizedPath">The parametrized path.</param>
-    /// <returns>The generated description.</returns>
-    private async Task<string> GetOperationDescriptionAsync(string method, string serverUrl, string parametrizedPath)
+    /// <returns>The generated summary.</returns>
+    private async Task<string> GetOperationSummaryAsync(string method, string serverUrl, string parametrizedPath)
     {
         ILanguageModelCompletionResponse? description = null;
         if (await _languageModelClient.IsEnabledAsync())
         {
-            description = await _languageModelClient.GenerateChatCompletionAsync("powerplatform_api_operation_description", new()
+            description = await _languageModelClient.GenerateChatCompletionAsync("powerplatform_api_operation_summary", new()
             {
-                { "request", $"{method.ToUpper(CultureInfo.InvariantCulture)} {serverUrl}{parametrizedPath}" }
+                { "request", @$"{method.ToUpper(CultureInfo.InvariantCulture)} {serverUrl}{parametrizedPath}" }
             });
         }
         return description?.Response?.Trim() ?? $"{method} {parametrizedPath}";