Revert all related new AfterRecordingStartAsync handler

Author: bartizan

DevProxy.Abstractions/Plugins/BasePlugin.cs

@@ -55,11 +55,6 @@ public virtual Task AfterRequestLogAsync(RequestLogArgs e, CancellationToken can
         return Task.CompletedTask;
     }
 
-    public virtual Task AfterRecordingStartAsync(EventArgs e, CancellationToken cancellationToken)
-    {
-        return Task.CompletedTask;
-    }
-
     public virtual Task AfterRecordingStopAsync(RecordingArgs e, CancellationToken cancellationToken)
     {
         return Task.CompletedTask;

DevProxy.Abstractions/Plugins/IPlugin.cs

@@ -22,7 +22,6 @@ public interface IPlugin
     Task BeforeResponseAsync(ProxyResponseArgs e, CancellationToken cancellationToken);
     Task AfterResponseAsync(ProxyResponseArgs e, CancellationToken cancellationToken);
     Task AfterRequestLogAsync(RequestLogArgs e, CancellationToken cancellationToken);
-    Task AfterRecordingStartAsync(EventArgs e, CancellationToken cancellationToken);
     Task AfterRecordingStopAsync(RecordingArgs e, CancellationToken cancellationToken);
     Task MockRequestAsync(EventArgs e, CancellationToken cancellationToken);
 }

DevProxy.Plugins/Inspection/OpenAITelemetryPlugin.cs

@@ -67,9 +67,7 @@ public sealed class OpenAITelemetryPlugin(
     private LanguageModelPricesLoader? _loader;
     private MeterProvider? _meterProvider;
     private TracerProvider? _tracerProvider;
-
     private readonly ConcurrentDictionary<string, List<OpenAITelemetryPluginReportModelUsageInformation>> _modelUsage = [];
-    private bool _isRecording;
 
     public override string Name => nameof(OpenAITelemetryPlugin);
 
@@ -194,16 +192,6 @@ public override Task AfterResponseAsync(ProxyResponseArgs e, CancellationToken c
         return Task.CompletedTask;
     }
 
-    public override Task AfterRecordingStartAsync(EventArgs e, CancellationToken cancellationToken)
-    {
-        Logger.LogTrace("{Method} called", nameof(AfterRecordingStartAsync));
-
-        _isRecording = true;
-
-        Logger.LogTrace("Left {Name}", nameof(AfterRecordingStartAsync));
-        return Task.CompletedTask;
-    }
-
     public override Task AfterRecordingStopAsync(RecordingArgs e, CancellationToken cancellationToken)
     {
         Logger.LogTrace("{Method} called", nameof(AfterRecordingStopAsync));
@@ -218,7 +206,6 @@ public override Task AfterRecordingStopAsync(RecordingArgs e, CancellationToken
         };
 
         StoreReport(report, e);
-        _isRecording = false;
         _modelUsage.Clear();
 
         Logger.LogTrace("Left {Name}", nameof(AfterRecordingStopAsync));
@@ -869,12 +856,8 @@ private void RecordUsageMetrics(Activity activity, OpenAIRequest request, OpenAI
             CompletionTokens = usage.CompletionTokens,
             CachedTokens = usage.PromptTokensDetails?.CachedTokens ?? 0L
         };
-
-        if (_isRecording)
-        {
-            var usagePerModel = _modelUsage.GetOrAdd(response.Model, model => []);
-            usagePerModel.Add(reportModelUsageInformation);
-        }
+        var usagePerModel = _modelUsage.GetOrAdd(response.Model, model => []);
+        usagePerModel.Add(reportModelUsageInformation);
 
         if (!Configuration.IncludeCosts || Configuration.Prices is null)
         {

DevProxy/ApiControllers/ProxyController.cs

@@ -42,7 +42,7 @@ public async Task<IActionResult> SetAsync([FromBody] ProxyInfo proxyInfo, Cancel
         {
             if (proxyInfo.Recording.Value)
             {
-                await _proxyStateController.StartRecordingAsync(cancellationToken);
+                _proxyStateController.StartRecording();
             }
             else
             {

DevProxy/Proxy/IProxyStateController.cs

@@ -9,7 +9,7 @@ public interface IProxyStateController
 #pragma warning restore CA1515
 {
     IProxyState ProxyState { get; }
-    Task StartRecordingAsync(CancellationToken cancellationToken);
+    void StartRecording();
     Task StopRecordingAsync(CancellationToken cancellationToken);
     Task MockRequestAsync(CancellationToken cancellationToken);
     void StopProxy();

DevProxy/Proxy/ProxyEngine.cs

@@ -147,7 +147,7 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
 
         if (_config.Record)
         {
-            await StartRecordingAsync(stoppingToken);
+            StartRecording();
         }
 
         if (_config.TimeoutSeconds.HasValue)
@@ -210,7 +210,7 @@ private async Task ReadKeysAsync(CancellationToken cancellationToken)
 #pragma warning restore IDE0010
         {
             case ConsoleKey.R:
-                await StartRecordingAsync(cancellationToken);
+                StartRecording();
                 break;
             case ConsoleKey.S:
                 await StopRecordingAsync(cancellationToken);
@@ -225,14 +225,14 @@ private async Task ReadKeysAsync(CancellationToken cancellationToken)
         }
     }
 
-    private async Task StartRecordingAsync(CancellationToken cancellationToken)
+    private void StartRecording()
     {
         if (_proxyController.ProxyState.IsRecording)
         {
             return;
         }
 
-        await _proxyController.StartRecordingAsync(cancellationToken);
+        _proxyController.StartRecording();
     }
 
     private async Task StopRecordingAsync(CancellationToken cancellationToken)

DevProxy/Proxy/ProxyStateController.cs

@@ -23,7 +23,7 @@ sealed class ProxyStateController(
     private readonly ILogger _logger = logger;
     private ExceptionHandler ExceptionHandler => ex => _logger.LogError(ex, "An error occurred in a plugin");
 
-    public async Task StartRecordingAsync(CancellationToken cancellationToken)
+    public void StartRecording()
     {
         if (ProxyState.IsRecording)
         {
@@ -32,19 +32,6 @@ public async Task StartRecordingAsync(CancellationToken cancellationToken)
 
         ProxyState.IsRecording = true;
         PrintRecordingIndicator(ProxyState.IsRecording);
-
-        var eventArgs = EventArgs.Empty;
-        foreach (var plugin in _plugins.Where(p => p.Enabled))
-        {
-            try
-            {
-                await plugin.AfterRecordingStartAsync(eventArgs, cancellationToken);
-            }
-            catch (Exception ex)
-            {
-                ExceptionHandler(ex);
-            }
-        }
     }
 
     public async Task StopRecordingAsync(CancellationToken cancellationToken)