Skip to content

Commit 0f93a9e

Browse files
Fixes prompty pattern matching. Closes #1325 (#1326)
Co-authored-by: Garry Trinder <[email protected]>
1 parent 7077cae commit 0f93a9e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

DevProxy.Abstractions/LanguageModel/BaseLanguageModelClient.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public async Task<bool> IsEnabledAsync(CancellationToken cancellationToken)
8383
return _lmAvailable.Value;
8484
}
8585

86-
protected abstract IEnumerable<ILanguageModelChatCompletionMessage> ConvertMessages(ChatMessage[] messages);
86+
protected abstract IEnumerable<ILanguageModelChatCompletionMessage> ConvertMessages(IEnumerable<ChatMessage> messages);
8787

8888
protected abstract Task<ILanguageModelCompletionResponse?> GenerateChatCompletionCoreAsync(IEnumerable<ILanguageModelChatCompletionMessage> messages, CompletionOptions? options, CancellationToken cancellationToken);
8989

@@ -105,8 +105,8 @@ public async Task<bool> IsEnabledAsync(CancellationToken cancellationToken)
105105
var promptContents = File.ReadAllText(filePath);
106106

107107
var prompty = Prompt.FromMarkdown(promptContents);
108-
if (prompty.Prepare(parameters) is not ChatMessage[] promptyMessages ||
109-
promptyMessages.Length == 0)
108+
if (prompty.Prepare(parameters) is not IEnumerable<ChatMessage> promptyMessages ||
109+
!promptyMessages.Any())
110110
{
111111
Logger.LogError("No messages found in the prompt file: {FilePath}", filePath);
112112
return (null, null);

DevProxy.Abstractions/LanguageModel/OllamaLanguageModelClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public sealed class OllamaLanguageModelClient(
7979
}
8080
}
8181

82-
protected override IEnumerable<ILanguageModelChatCompletionMessage> ConvertMessages(ChatMessage[] messages)
82+
protected override IEnumerable<ILanguageModelChatCompletionMessage> ConvertMessages(IEnumerable<ChatMessage> messages)
8383
{
8484
return messages.Select(m => new OllamaLanguageModelChatCompletionMessage
8585
{

DevProxy.Abstractions/LanguageModel/OpenAILanguageModelClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public sealed class OpenAILanguageModelClient(
8787
}
8888
}
8989

90-
protected override IEnumerable<ILanguageModelChatCompletionMessage> ConvertMessages(ChatMessage[] messages)
90+
protected override IEnumerable<ILanguageModelChatCompletionMessage> ConvertMessages(IEnumerable<ChatMessage> messages)
9191
{
9292
return messages.Select(m => new OpenAIChatCompletionMessage
9393
{

0 commit comments

Comments
 (0)