Fixes Dev Proxy API (#1257)

Author: waldekmastykarz

DevProxy/ApiControllers/ProxyController.cs

@@ -13,7 +13,9 @@ namespace DevProxy.ApiControllers;
 
 [ApiController]
 [Route("[controller]")]
-sealed class ProxyController(IProxyStateController proxyStateController, IProxyConfiguration proxyConfiguration) : ControllerBase
+#pragma warning disable CA1515 // required for the API controller
+public sealed class ProxyController(IProxyStateController proxyStateController, IProxyConfiguration proxyConfiguration) : ControllerBase
+#pragma warning restore CA1515
 {
     private readonly IProxyStateController _proxyStateController = proxyStateController;
     private readonly IProxyConfiguration _proxyConfiguration = proxyConfiguration;
@@ -52,7 +54,9 @@ public async Task<IActionResult> SetAsync([FromBody] ProxyInfo proxyInfo)
     }
 
     [HttpPost("mockRequest")]
+#pragma warning disable CA1030
     public async Task RaiseMockRequestAsync()
+#pragma warning restore CA1030
     {
         await _proxyStateController.MockRequestAsync();
         Response.StatusCode = 202;

DevProxy/ApiControllers/ProxyInfo.cs

@@ -7,13 +7,18 @@
 
 namespace DevProxy.ApiControllers;
 
-sealed class ProxyInfo
+#pragma warning disable CA1515 // required for the API controller
+public sealed class ProxyInfo
+#pragma warning restore CA1515
 {
     public bool? Recording { get; set; }
     public string? ConfigFile { get; init; }
 
     public static ProxyInfo From(IProxyState proxyState, IProxyConfiguration proxyConfiguration)
     {
+        ArgumentNullException.ThrowIfNull(proxyState);
+        ArgumentNullException.ThrowIfNull(proxyConfiguration);
+
         return new ProxyInfo
         {
             ConfigFile = proxyConfiguration.ConfigFile,

DevProxy/Jwt/JwtOptions.cs

@@ -4,10 +4,12 @@
 
 namespace DevProxy.Jwt;
 
-sealed class JwtOptions
+#pragma warning disable CA1515 // required for the API controller
+public sealed class JwtOptions
+#pragma warning restore CA1515
 {
     public IEnumerable<string>? Audiences { get; set; }
-    public Dictionary<string, string>? Claims { get; set; }
+    public Dictionary<string, string>? Claims { get; init; }
     public string? Issuer { get; set; }
     public string? Name { get; set; }
     public IEnumerable<string>? Roles { get; set; }

DevProxy/Proxy/IProxyState.cs

@@ -3,12 +3,15 @@
 // See the LICENSE file in the project root for more information.
 
 using DevProxy.Abstractions.Proxy;
+using System.Collections.ObjectModel;
 
 namespace DevProxy.Proxy;
 
-interface IProxyState
+#pragma warning disable CA1515 // required for the API controller
+public interface IProxyState
+#pragma warning restore CA1515
 {
-    Dictionary<string, object> GlobalData { get; set; }
+    Dictionary<string, object> GlobalData { get; }
     bool IsRecording { get; set; }
-    List<RequestLog> RequestLogs { get; set; }
+    Collection<RequestLog> RequestLogs { get; }
 }

DevProxy/Proxy/IProxyStateController.cs

@@ -4,7 +4,9 @@
 
 namespace DevProxy.Proxy;
 
-interface IProxyStateController
+#pragma warning disable CA1515 // required for the API controller
+public interface IProxyStateController
+#pragma warning restore CA1515
 {
     IProxyState ProxyState { get; }
     void StartRecording();

DevProxy/Proxy/ProxyState.cs

@@ -4,13 +4,14 @@
 
 using DevProxy.Abstractions.Proxy;
 using DevProxy.Abstractions.Utils;
+using System.Collections.ObjectModel;
 
 namespace DevProxy.Proxy;
 
 sealed class ProxyState : IProxyState
 {
     public bool IsRecording { get; set; }
-    public List<RequestLog> RequestLogs { get; set; } = [];
+    public Collection<RequestLog> RequestLogs { get; set; } = [];
     public Dictionary<string, object> GlobalData { get; set; } = new() {
         { ProxyUtils.ReportsKey, new Dictionary<string, object>() }
     };