Refactors APIC plugins (#762)

* Refactors APIC plugins

* Refactors API Center plugins

Author: waldekmastykarz

dev-proxy-plugins/RequestLogs/ApiCenterOnboardingPlugin.cs

@@ -42,6 +42,8 @@ public class ApiCenterOnboardingPlugin : BaseReportingPlugin
 {
     private ApiCenterOnboardingPluginConfiguration _configuration = new();
     private ApiCenterClient? _apiCenterClient;
+    private Api[]? _apis;
+    private Dictionary<string, ApiDefinition>? _apiDefinitionsByUrl;
 
     public ApiCenterOnboardingPlugin(IPluginEvents pluginEvents, IProxyContext context, ILogger logger, ISet<UrlToWatch> urlsToWatch, IConfigurationSection? configSection = null) : base(pluginEvents, context, logger, urlsToWatch, configSection)
     {
@@ -74,7 +76,7 @@ public override void Register()
             return;
         }
 
-        Logger.LogDebug("Plugin {plugin} checking Azure auth...", Name);
+        Logger.LogInformation("Plugin {plugin} connecting to Azure...", Name);
         try
         {
             _ = _apiCenterClient.GetAccessToken(CancellationToken.None).Result;
@@ -101,14 +103,21 @@ private async Task AfterRecordingStop(object sender, RecordingArgs e)
 
         Debug.Assert(_apiCenterClient is not null);
 
-        var apis = await _apiCenterClient.GetApis();
-        if (apis == null || !apis.Any())
+        if (_apis is null)
+        {
+            _apis = await _apiCenterClient.GetApis();
+        }
+
+        if (_apis == null || !_apis.Any())
         {
             Logger.LogInformation("No APIs found in API Center");
             return;
         }
 
-        var apiDefinitions = await apis.GetApiDefinitionsByUrl(_apiCenterClient, Logger);
+        if (_apiDefinitionsByUrl is null)
+        {
+            _apiDefinitionsByUrl = await _apis.GetApiDefinitionsByUrl(_apiCenterClient, Logger);
+        }
 
         var newApis = new List<(string method, string url)>();
         var interceptedRequests = e.RequestLogs
@@ -129,7 +138,7 @@ private async Task AfterRecordingStop(object sender, RecordingArgs e)
 
             Logger.LogDebug("Processing request {method} {url}...", method, url);
 
-            var apiDefinition = apiDefinitions.FirstOrDefault(x =>
+            var apiDefinition = _apiDefinitionsByUrl.FirstOrDefault(x =>
                 url.StartsWith(x.Key, StringComparison.OrdinalIgnoreCase)).Value;
             if (apiDefinition is null ||
                 apiDefinition.Id is null)

dev-proxy-plugins/RequestLogs/ApiCenterProductionVersionPlugin.cs

@@ -40,6 +40,7 @@ public class ApiCenterProductionVersionPlugin : BaseReportingPlugin
 {
     private ApiCenterProductionVersionPluginConfiguration _configuration = new();
     private ApiCenterClient? _apiCenterClient;
+    private Api[]? _apis;
 
     public ApiCenterProductionVersionPlugin(IPluginEvents pluginEvents, IProxyContext context, ILogger logger, ISet<UrlToWatch> urlsToWatch, IConfigurationSection? configSection = null) : base(pluginEvents, context, logger, urlsToWatch, configSection)
     {
@@ -72,7 +73,7 @@ public override void Register()
             return;
         }
 
-        Logger.LogDebug("Plugin {plugin} checking Azure auth...", Name);
+        Logger.LogInformation("Plugin {plugin} connecting to Azure...", Name);
         try
         {
             _ = _apiCenterClient.GetAccessToken(CancellationToken.None).Result;
@@ -104,14 +105,18 @@ private async Task AfterRecordingStop(object sender, RecordingArgs e)
 
         Debug.Assert(_apiCenterClient is not null);
 
-        var apisFromApiCenter = await _apiCenterClient.GetApis();
-        if (apisFromApiCenter == null || !apisFromApiCenter.Any())
+        if (_apis is null)
+        {
+            _apis = await _apiCenterClient.GetApis();
+        }
+
+        if (_apis == null || !_apis.Any())
         {
             Logger.LogInformation("No APIs found in API Center");
             return;
         }
 
-        foreach (var api in apisFromApiCenter)
+        foreach (var api in _apis)
         {
             Debug.Assert(api.Id is not null);
 
@@ -173,7 +178,7 @@ private async Task AfterRecordingStop(object sender, RecordingArgs e)
                 continue;
             }
 
-            var api = apisFromApiCenter.FindApiByUrl(url, Logger);
+            var api = _apis.FindApiByUrl(url, Logger);
             if (api == null)
             {
                 report.Add(new()